From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Kai Heng Feng <kai.heng.feng@canonical.com>
Cc: lenb@kernel.org, linux-acpi@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI / battery: add quirk for Asus GL502VSK and UX305LA
Date: Mon, 20 Nov 2017 15:18:27 +0100 [thread overview]
Message-ID: <9845028.VOqL70lqLX@aspire.rjw.lan> (raw)
In-Reply-To: <B100F55A-98C4-47D9-B177-2A5AA7F79A58@canonical.com>
On Monday, November 20, 2017 9:24:32 AM CET Kai Heng Feng wrote:
>
> > On 12 Oct 2017, at 1:16 PM, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
> >
> > On Fri, Sep 22, 2017 at 4:27 PM, Kai-Heng Feng
> > <kai.heng.feng@canonical.com> wrote:
> >> On Asus GL502VSK and UX305LA, ACPI incorrectly reports discharging when
> >> battery is full and AC is plugged.
> >>
> >> However rate_now is correct under this circumstance, hence we can use
> >> "rate_now == 0" as a predicate to report battery full status correctly.
> >>
> >> BugLink: https://bugs.launchpad.net/bugs/1482390
> >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> >> ---
> >> drivers/acpi/battery.c | 29 ++++++++++++++++++++++++++++-
> >> 1 file changed, 28 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> >> index 13e7b56e33ae..f9f008cf3da7 100644
> >> --- a/drivers/acpi/battery.c
> >> +++ b/drivers/acpi/battery.c
> >> @@ -70,6 +70,7 @@ static async_cookie_t async_cookie;
> >> static bool battery_driver_registered;
> >> static int battery_bix_broken_package;
> >> static int battery_notification_delay_ms;
> >> +static int battery_full_discharging;
> >> static unsigned int cache_time = 1000;
> >> module_param(cache_time, uint, 0644);
> >> MODULE_PARM_DESC(cache_time, "cache time in milliseconds");
> >> @@ -214,7 +215,10 @@ static int acpi_battery_get_property(struct power_supply *psy,
> >> return -ENODEV;
> >> switch (psp) {
> >> case POWER_SUPPLY_PROP_STATUS:
> >> - if (battery->state & ACPI_BATTERY_STATE_DISCHARGING)
> >> + if (battery_full_discharging && battery->rate_now == 0 &&
> >> + battery->state & ACPI_BATTERY_STATE_DISCHARGING)
> >> + val->intval = POWER_SUPPLY_STATUS_FULL;
> >> + else if (battery->state & ACPI_BATTERY_STATE_DISCHARGING)
> >> val->intval = POWER_SUPPLY_STATUS_DISCHARGING;
> >> else if (battery->state & ACPI_BATTERY_STATE_CHARGING)
> >> val->intval = POWER_SUPPLY_STATUS_CHARGING;
> >> @@ -1166,6 +1170,13 @@ battery_notification_delay_quirk(const struct dmi_system_id *d)
> >> return 0;
> >> }
> >>
> >> +static int __init
> >> +battery_full_discharging_quirk(const struct dmi_system_id *d)
> >> +{
> >> + battery_full_discharging = 1;
> >> + return 0;
> >> +}
> >> +
> >> static const struct dmi_system_id bat_dmi_table[] __initconst = {
> >> {
> >> .callback = battery_bix_broken_package_quirk,
> >> @@ -1183,6 +1194,22 @@ static const struct dmi_system_id bat_dmi_table[] __initconst = {
> >> DMI_MATCH(DMI_PRODUCT_NAME, "Aspire V5-573G"),
> >> },
> >> },
> >> + {
> >> + .callback = battery_full_discharging_quirk,
> >> + .ident = "ASUS GL502VSK",
> >> + .matches = {
> >> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> >> + DMI_MATCH(DMI_PRODUCT_NAME, "GL502VSK"),
> >> + },
> >> + },
> >> + {
> >> + .callback = battery_full_discharging_quirk,
> >> + .ident = "ASUS UX305LA",
> >> + .matches = {
> >> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> >> + DMI_MATCH(DMI_PRODUCT_NAME, "UX305LA"),
> >> + },
> >> + },
> >> {},
> >> };
> >>
> >
> > Hi,
> >
> > Is there any improvement I can make for this patch?
>
> Another gentle ping…
Sorry for the delay.
I've a couple of comments, I'll respond to the original patch later today.
Thanks,
Rafael
next prev parent reply other threads:[~2017-11-20 14:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 8:27 Kai-Heng Feng
2017-10-12 5:16 ` Kai-Heng Feng
2017-11-20 8:24 ` Kai Heng Feng
2017-11-20 14:18 ` Rafael J. Wysocki [this message]
2017-11-21 1:14 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9845028.VOqL70lqLX@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=kai.heng.feng@canonical.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®