Re: [PATCH] riscv: dts: sophgo: fix DMA data-width configuration for CV18xx

[Ze Huang <huangze@whut.edu.cn>]

On 4/30/25 2:54 PM, Inochi Amaoto wrote:
> On Mon, Apr 28, 2025 at 05:24:36PM +0800, Ze Huang wrote:
>> The "snps,data-width" property[1] defines the AXI data width of the DMA
>> controller as:
>>
>>      width = 8 × (2^n) bits
>>
>> (0 = 8 bits, 1 = 16 bits, 2 = 32 bits, ..., 6 = 512 bits)
>> where "n" is the value of "snps,data-width".
>>
>> For the CV18xx DMA controller, the correct AXI data width is 32 bits,
>> corresponding to "snps,data-width = 2".
>>
>> Test results on Milkv Duo S can be found here [2].
>>
>> Link: https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/dma/snps%2Cdw-axi-dmac.yaml#L74 [1]
>> Link: https://gist.github.com/Sutter099/4fa99bb2d89e5af975983124704b3861 [2]
>>
>> Co-developed-by: Yu Yuan <yu.yuan@sjtu.edu.cn>
>> Signed-off-by: Yu Yuan <yu.yuan@sjtu.edu.cn>

>> Signed-off-by: Ze Huang <huange@whut.edu.cn>

>> ---
>> Signed-off-by: Ze Huang <huangze@whut.edu.cn>
> I think there is a wrong sob here,

Yeah... There's a typo in mail address.

> also, please add a fixes tag if
> you fix something. I will take care of this when merging.
>
> Fixes: 514951a81a5e ("riscv: dts: sophgo: cv18xx: add DMA controller")
>

Thank you for your review and reminder. I will follow that :-)