mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	linux-arm-msm@vger.kernel.org, andersson@kernel.org,
	agross@kernel.org, krzysztof.kozlowski@linaro.org
Cc: marijn.suijten@somainline.org, Georgi Djakov <djakov@kernel.org>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 8/9] interconnect: qcom: rpm: Add a way to always set QoS registers
Date: Wed, 18 Jan 2023 13:49:30 +0100	[thread overview]
Message-ID: <9850c8a3-5d1e-d379-7994-14c04fc8c653@linaro.org> (raw)
In-Reply-To: <6e35de82-e539-35c1-fcb1-10c02af9bb8c@linaro.org>



On 17.01.2023 14:27, Bryan O'Donoghue wrote:
> On 16/01/2023 13:21, Konrad Dybcio wrote:
>> On newer SoCs (there's no clear boundary, but probably "new enough"
>> means every interconnect provider is either BIMC or QNoC and there
>> are no old-style NoC hosts) we're expected to set QoS registers
>> regardless of the ap_owned param. Add a bool in the qcom_icc_provider
>> and make the logic assume it's okay to set the registers when it's
>> set.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>>   drivers/interconnect/qcom/icc-rpm.c | 2 +-
>>   drivers/interconnect/qcom/icc-rpm.h | 2 ++
>>   2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c
>> index 509cadf398e9..343e6021a93a 100644
> 
> On next-20230116,
g fetch linux-next next-20230116
gco FETCH_HEAD
b4 am 20230116132152.405535-1-konrad.dybcio@linaro.org
g am ./v3_20230116_konrad_dybcio_the_great_interconnecification_fixation.mbx

Stosowanie: interconnect: qcom: rpm: make QoS INVALID default, separate out driver data
Stosowanie: interconnect: qcom: rpm: Always set QoS params on QNoC
Stosowanie: interconnect: qcom: rpm: Add support for specifying channel num
Stosowanie: interconnect: qcom: Sort kerneldoc entries
Stosowanie: interconnect: qcom: rpm: Rename icc desc clocks to bus_blocks
Stosowanie: interconnect: qcom: rpm: Rename icc provider num_clocks to num_bus_clocks
Stosowanie: interconnect: qcom: rpm: Handle interface clocks
Stosowanie: interconnect: qcom: rpm: Add a way to always set QoS registers
Stosowanie: interconnect: qcom: rpm: Don't use clk_get_optional for bus clocks anymore
(no errors)

Konrad
> 
> git am < ~/Downloads/v3-1-9-interconnect-qcom-rpm-make-QoS-INVALID-default-separate-out-driver-data.patch
> Applying: interconnect: qcom: rpm: make QoS INVALID default, separate out driver data
> Applying: interconnect: qcom: rpm: Add support for specifying channel num
> Applying: interconnect: qcom: rpm: Rename icc desc clocks to bus_blocks
> Applying: interconnect: qcom: rpm: Add a way to always set QoS registers
> 
> error: patch failed: drivers/interconnect/qcom/icc-rpm.c:243
> error: drivers/interconnect/qcom/icc-rpm.c: patch does not apply
> error: patch failed: drivers/interconnect/qcom/icc-rpm.h:28
> error: drivers/interconnect/qcom/icc-rpm.h: patch does not apply
> Patch failed at 0004 interconnect: qcom: rpm: Add a way to always set QoS registers
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> 
> Should I pick up another series from elsewhere to apply this ?
> 
> ---
> bod

  reply	other threads:[~2023-01-18 13:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230116132152.405535-1-konrad.dybcio@linaro.org>
2023-01-16 13:21 ` [PATCH v3 1/9] interconnect: qcom: rpm: make QoS INVALID default, separate out driver data Konrad Dybcio
2023-01-16 13:21 ` [PATCH v3 2/9] interconnect: qcom: rpm: Always set QoS params on QNoC Konrad Dybcio
2023-01-18 20:36   ` Konrad Dybcio
2023-01-19  0:27     ` Bryan O'Donoghue
2023-01-25  1:57       ` Konrad Dybcio
2023-01-16 13:21 ` [PATCH v3 3/9] interconnect: qcom: rpm: Add support for specifying channel num Konrad Dybcio
2023-01-16 13:21 ` [PATCH v3 4/9] interconnect: qcom: Sort kerneldoc entries Konrad Dybcio
2023-01-16 13:21 ` [PATCH v3 5/9] interconnect: qcom: rpm: Rename icc desc clocks to bus_blocks Konrad Dybcio
2023-01-16 13:21 ` [PATCH v3 6/9] interconnect: qcom: rpm: Rename icc provider num_clocks to num_bus_clocks Konrad Dybcio
2023-01-16 13:21 ` [PATCH v3 7/9] interconnect: qcom: rpm: Handle interface clocks Konrad Dybcio
2023-01-16 13:21 ` [PATCH v3 8/9] interconnect: qcom: rpm: Add a way to always set QoS registers Konrad Dybcio
2023-01-17 13:27   ` Bryan O'Donoghue
2023-01-18 12:49     ` Konrad Dybcio [this message]
2023-01-18 19:54   ` Konrad Dybcio
2023-01-16 13:21 ` [PATCH v3 9/9] interconnect: qcom: rpm: Don't use clk_get_optional for bus clocks anymore Konrad Dybcio
2023-01-23 18:41   ` Arnaud Vrac
2023-01-23 19:11     ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9850c8a3-5d1e-d379-7994-14c04fc8c653@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=djakov@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®