mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Thumshirn <jth@kernel.org>
To: "Rodríguez Barbarin,
	José Javier" <JoseJavier.Rodriguez@duagon.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "Sanjuán García, Jorge" <Jorge.SanjuanGarcia@duagon.com>,
	"mmoese@suse.de" <mmoese@suse.de>
Subject: Re: [PATCH 1/1] mcb: Remove requesting memory region to avoid memory overlapping
Date: Thu, 23 Mar 2023 16:53:12 +0100	[thread overview]
Message-ID: <9851e06c-8430-0303-f5c2-ebcb5e38996b@kernel.org> (raw)
In-Reply-To: <121decd1d4f8c4aa469636756557fce02b245ddc.camel@duagon.com>

On 23.03.23 16:11, Rodríguez Barbarin, José Javier wrote:
> One thing we can do is modify the chameleon_parse_cells prototype to
> return the actual "chameleon table" size instead of the number of cells
> which can have an undetermined size. At the moment, the return value is
> only used for error checking but the number of cells is never used.
>
> After that, we can check the actual "chameleon table" size and
> drop/reallocate if needed.
Hi Javier,

Yeah that sounds reasonable. mcb_bus_add_devices() calls device_attach()
for the respective IP cores, so they individual driver's ->probe() function
shouldn't be called before mcb_bus_add_devices(). So you could shrink
the resource between chameleon_parse_cells() and mcb_add_devices().

Btw, mcb-lpc.c needs the same fix as well.

Byte,
    Johannes

      reply	other threads:[~2023-03-23 15:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23 12:49 [PATCH 0/1] mcb-pci: fix memory overlapping on MCB devices Rodríguez Barbarin, José Javier
2023-03-23 12:49 ` [PATCH 1/1] mcb: Remove requesting memory region to avoid memory overlapping Rodríguez Barbarin, José Javier
2023-03-23 14:25   ` Johannes Thumshirn
2023-03-23 15:11     ` Rodríguez Barbarin, José Javier
2023-03-23 15:53       ` Johannes Thumshirn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9851e06c-8430-0303-f5c2-ebcb5e38996b@kernel.org \
    --to=jth@kernel.org \
    --cc=Jorge.SanjuanGarcia@duagon.com \
    --cc=JoseJavier.Rodriguez@duagon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmoese@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®