From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751418AbdJEPhP (ORCPT ); Thu, 5 Oct 2017 11:37:15 -0400 Received: from ale.deltatee.com ([207.54.116.67]:58816 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751123AbdJEPhO (ORCPT ); Thu, 5 Oct 2017 11:37:14 -0400 To: Colin King , Kurt Schwemmer , Bjorn Helgaas , linux-pci@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171005100145.29309-1-colin.king@canonical.com> From: Logan Gunthorpe Message-ID: <985dc2ab-8ba6-3bb7-502d-4927427e2fa8@deltatee.com> Date: Thu, 5 Oct 2017 09:37:09 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171005100145.29309-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-pci@vger.kernel.org, bhelgaas@google.com, kurt.schwemmer@microsemi.com, colin.king@canonical.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH] switchtec: make struct event_regs static X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks! Acked-by: Logan Gunthorpe On 10/5/2017 4:01 AM, Colin King wrote: > From: Colin Ian King > > The structure event_regs is local to the source and does not need to > be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'event_regs' was not declared. Should it be static > > Signed-off-by: Colin Ian King > --- > drivers/pci/switch/switchtec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c > index af81b2dec42e..da45dbea20ce 100644 > --- a/drivers/pci/switch/switchtec.c > +++ b/drivers/pci/switch/switchtec.c > @@ -943,7 +943,7 @@ static u32 __iomem *pff_ev_reg(struct switchtec_dev *stdev, > #define EV_PAR(i, r)[i] = {offsetof(struct part_cfg_regs, r), part_ev_reg} > #define EV_PFF(i, r)[i] = {offsetof(struct pff_csr_regs, r), pff_ev_reg} > > -const struct event_reg { > +static const struct event_reg { > size_t offset; > u32 __iomem *(*map_reg)(struct switchtec_dev *stdev, > size_t offset, int index); >