From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BBAEC43143 for ; Sat, 29 Sep 2018 02:05:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8C1C206B8 for ; Sat, 29 Sep 2018 02:05:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8C1C206B8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727418AbeI2Ibr (ORCPT ); Sat, 29 Sep 2018 04:31:47 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:40913 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727295AbeI2Ibr (ORCPT ); Sat, 29 Sep 2018 04:31:47 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id AB2EDABFCF434; Sat, 29 Sep 2018 10:05:13 +0800 (CST) Received: from [127.0.0.1] (10.134.22.195) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.399.0; Sat, 29 Sep 2018 10:05:10 +0800 Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: fix missing up_read To: Jaegeuk Kim , , CC: References: <20180928174854.65978-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: <9865a464-11bc-f8ae-b11f-9bd2f7dd66ec@huawei.com> Date: Sat, 29 Sep 2018 10:05:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180928174854.65978-1-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/9/29 1:48, Jaegeuk Kim wrote: > This patch fixes missing up_read call. I guess we need to add additional type of error injection to simulate on-disk blkaddr corruption, then we can cover all those error paths. > > Fixes: c9b60788fc76 ("f2fs: fix to do sanity check with block address in main area") > Cc: # 4.19+ > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks,