From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABC0731B133 for ; Wed, 15 Oct 2025 10:34:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760524447; cv=none; b=nbHZ30C7q9yldvFOKUiFgNUFL9aCm/vDVNSrgnOhiGw6ZO6oCiPh5FvbA3d8bOGkU4aKaNE9O+m+xceZz0XyiTBAizsaL08LizQPi3ZWb6f/5Mw3y3uxwICnvBvINqtiOj6BTh2U66kfVGVeEbK/3AFeYYJnfd9Otj0O6toDmt0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760524447; c=relaxed/simple; bh=t6s+5a0qx+cIEfZCgFCpVTM/4YgqdDw3vQzbv5i/B/E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Wi8IF/giOEzX5Hl0f5+pw+o3KCa0P7EejE6tITlLtya8WlfXayhmj7z4GZu3PRxbEyCsWRDW7U50AzmBDGvB3AYZ52EkbfKct8F81OrH2SJPnenB2j3qhcyN4SHqV4fTo9hA8tzyJr6T97V2Ad4bzSRal1RpXDdqWM0xpg5KDjA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=daI0TSIY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="daI0TSIY" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59F2sEhY024859 for ; Wed, 15 Oct 2025 10:34:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mb5K7hg5DYmN+vjryrnWGrqFCcB0tj4IX+2kkXwfhVo=; b=daI0TSIYaUZDjzfR +GYt6d8RuXp7zbwVTvPiQKNOH31SP5m9idoxQ/aebzSp6iq2YFZ6I784gbAlrGI9 z5LNpGfEMh9ir13YqF29b5jm70EXk1p4HQgES16Z8bfas08NtJOHMC88143jiB5F bN1LsZIp7EGN1/CpbA+ARevHJ14LHrIWaTg6sldTQ0Ggw6dc9KR+xvWHy0UUvY6Z KB+7T7XkssZkssYH62j729PxhZH7VsNpgndB0BOO6PApO0xSdAUZzZFdjUyocREF fhn650yqr6T9dUGFyen5z5NJi8/4M4aVwrWYUyG+80s3XchLi6Rc2S8BRyNZcTCi t2yfNw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49qff0v28n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 15 Oct 2025 10:34:05 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2711a55da20so68911905ad.1 for ; Wed, 15 Oct 2025 03:34:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760524444; x=1761129244; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mb5K7hg5DYmN+vjryrnWGrqFCcB0tj4IX+2kkXwfhVo=; b=T4HQVuvnJuu7gvf1/R+9nk+CVk4lMF8b55Xw5dE3u60GggCE6GkmmU4xsmgTL22h1y mSe+wFdbpaQXb/cuNP4Vktsf07gpJHrOaQ3QuLxEZOZmQhSJ16PvC+n0ExeQWWyUI74/ DUzxeFRqVc15J/RfXc+NTCiqZkYQLkU8GZj2Hj+9AdnMu+U7naPZQFAqrgBnrPPbe66c gad2jRbq2bTSH1gNFI3UMAfyY9KVpmXF2+2slUAFA7P6NkBEQQu6VVmeZDBKVoXIvYJE q7xoS8YJR/r413zGRe0hqtDkRUpRWNVg7moxtO95DdO/vJLoMDdaM2VcjUvnYO7sXVdk r5rg== X-Forwarded-Encrypted: i=1; AJvYcCWp1WDr5M0hbE+Qm3ZAyJEq8ugZq4kDj3SzcV2Fc+m/6YHIejMHg6TOm0TpBSRCjiMGvTsfVoZeqJoTloE=@vger.kernel.org X-Gm-Message-State: AOJu0YyYZ8x7+UyE9sueMfzq1EFfxavId9x8ZeuBmFxg/uBOgXivUjUP celtyp6q4VFSOh/28MmlcsDSJeeEO+bH9xFAMBSPhfRdxsULvUXL4XUEZSajvY/T71QOYQSHag+ 3hf3Md2qXyY330ka4WYR4ywyo4VmKDH8xrt4CKMz2a+334Urc5cOc38ATZcI+Gh+s8HQ= X-Gm-Gg: ASbGncsU3muk+pBdAlWLY6a1E8dpIyVuxK5zOKJtHMFhzEovho8cV42wBRr+0vyzZ19 whCmMf9ledC1Myt2SiHI34aoWxhjSCsuLVGRsuX0J1SwcV6pZgIIgazYWUIp4gziMOtw6ljfta1 wGrxxuNCheiv51q+o/nkOQzS39tptgUeYV0UN0kwTHhZ3mSWXjmasGaOZKLPaX+FKCYAeLpUwKY M2EMXpLEzNbvx4OWV1D2pZ9J3W3VhwjIL9mSj/QJUDoA0dcybUWIFF61f06DfZ72oS1Cyhb1vaK x8vjNtXYwMZK4kKWNUBXsdC96Q3Wco+a86Lqubp4CXSIoXuRKKRBiA72kZQTsyMBUFTReQs= X-Received: by 2002:a17:903:320b:b0:275:b1cf:6dd7 with SMTP id d9443c01a7336-290272c376amr391441645ad.34.1760524444087; Wed, 15 Oct 2025 03:34:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHh9WZGfNKaBgWbNK5aLHNx3mn34hyNL6G/4cHtFJK8KrqDiYbFvJ33yvdZKEBJYvqMbGPfkQ== X-Received: by 2002:a17:903:320b:b0:275:b1cf:6dd7 with SMTP id d9443c01a7336-290272c376amr391441275ad.34.1760524443506; Wed, 15 Oct 2025 03:34:03 -0700 (PDT) Received: from [10.218.44.34] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29034f07741sm192379045ad.61.2025.10.15.03.34.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Oct 2025 03:34:03 -0700 (PDT) Message-ID: <9865ae77-0051-4a4b-95a6-6e655fc274f3@oss.qualcomm.com> Date: Wed, 15 Oct 2025 16:03:58 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/24] arm64: dts: qcom: glymur: Add QUPv3 configuration for serial engines To: Abel Vesa , Pankaj Patil Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250925-v3_glymur_introduction-v1-0-24b601bbecc0@oss.qualcomm.com> <20250925-v3_glymur_introduction-v1-4-24b601bbecc0@oss.qualcomm.com> <3af57kktkwevbxkno4o54w3o2qajoco5x7dlj3ckepcutlzmdh@2bnqqxndbvf3> Content-Language: en-US From: Jyothi Kumar Seerapu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDExMDAxOCBTYWx0ZWRfX6zjZjBUbQ2dF 3v9xKW+EjOA+g3H7BkiEOTudQrmR85nwUfuTop1K9UZzJ7Bzk0pJasYd2RpCKbqfDTxeUfVKZd4 yTWbkR5tDXiA9fZg8s69o9DafU9EAKsVrWcpunEC8me4D/f9KlrMGBXLmUUb+tmuRIYd8K/ZTrh PJsojfXtzUovO68T2Y1kVEiIY7KJrz9Jj9S3qOq4s0Hr0bfvjCTcdThK99isJHJVDERPH8IVFyT 1rdYQDBc7t6v+c5+VnYFtIINxldDnk3dJbhofyU+M3XwSibqo/7TS8K8iiC00uVb78Bzic1lm7d 3bxRAs+jkFoJRbmFxtCwGBgdGo/yH08pjZf2t3BDw== X-Proofpoint-GUID: u2qQY9ori_EGgAFro1B51yXBoYpTKsW3 X-Authority-Analysis: v=2.4 cv=PriergM3 c=1 sm=1 tr=0 ts=68ef789d cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=RnZ6wvZhTJBgIj8N7VsA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: u2qQY9ori_EGgAFro1B51yXBoYpTKsW3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-15_04,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510110018 On 10/11/2025 4:41 PM, Abel Vesa wrote: > On 25-10-11 14:06:44, Abel Vesa wrote: >> On 25-09-25 12:02:12, Pankaj Patil wrote: >>> From: Jyothi Kumar Seerapu >>> >>> Add device tree support for QUPv3 serial engine protocols on Glymur. >>> Glymur has 24 QUP serial engines across 3 QUP wrappers, each with >>> support of GPI DMA engines. >>> >>> Signed-off-by: Jyothi Kumar Seerapu >>> Signed-off-by: Pankaj Patil >>> --- >>> arch/arm64/boot/dts/qcom/glymur-crd.dts | 43 + >>> arch/arm64/boot/dts/qcom/glymur.dtsi | 3041 +++++++++++++++++++++++++++++-- >>> 2 files changed, 2936 insertions(+), 148 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi >>> index f1c5a0cb483670e9f8044e250950693b4a015479..8674465b22707207523caa8ad635d95a3396497a 100644 >>> --- a/arch/arm64/boot/dts/qcom/glymur.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi >>> @@ -707,6 +707,32 @@ gcc: clock-controller@100000 { >>> #power-domain-cells = <1>; >>> }; >>> >>> + gpi_dma2: dma-controller@800000 { >>> + compatible = "qcom,glymur-gpi-dma", "qcom,sm6350-gpi-dma"; >>> + reg = <0 0x00800000 0 0x60000>; >>> + interrupts = , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + ; >>> + dma-channels = <16>; >>> + dma-channel-mask = <0x3f>; >>> + #dma-cells = <3>; >>> + iommus = <&apps_smmu 0xd76 0x0>; >>> + status = "ok"; >> >> s/ok/okay/ >> >> Everywhere actually. >> > > Actually no. Maybe drop entirely like Konrad already suggested. > > But then everywhere else you do "ok" please replace with "okay", > otherwise dtbs_check complains. Sure, will review it.>