From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6523EC47404 for ; Wed, 2 Oct 2019 20:06:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D92620673 for ; Wed, 2 Oct 2019 20:06:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="cHRFCtRp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726924AbfJBUG5 (ORCPT ); Wed, 2 Oct 2019 16:06:57 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:37906 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726523AbfJBUG5 (ORCPT ); Wed, 2 Oct 2019 16:06:57 -0400 Received: by mail-pg1-f196.google.com with SMTP id x10so190262pgi.5 for ; Wed, 02 Oct 2019 13:06:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=j7Oj9/NMOxxlIgyK+rsgtpkeEf8Sqt/NUKWjxaLjPJg=; b=cHRFCtRp3DATBrikB2f0LyWMSc83/gSCADBiAFa1Soi99gYQUDknOBH4kygMKEsecc 6YAxpO8sFAQciMNcrj7gajbPZlQ5cg/uTOU+EfGdO5XKdL1oC9JT5K0o/pmeq3YFuZgv ch0tgm7SgDkNk7LnIy2NaX0hZ6cH+3u8MQNJE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=j7Oj9/NMOxxlIgyK+rsgtpkeEf8Sqt/NUKWjxaLjPJg=; b=LaBdQKPmHflHlAaAJ4QiimUlDWL5a8ahpAYAwh2F102MdXXVWaZ29TirXzRq6bolKz 2eBKnG5wFFRLCivProb/52h6Xtm3idL1X8/T1F6ia1sQjkRZu0hURE4TTmcTRClRJDes mULJ8Nlu4zog4iQiUds6IR1z5eV0rwn10+BNlRvzqpzpWrEWS2nscPDcv9rIrVy39RvJ g4vLjg7lNVj6p9IbkUq9O3UAHeCTsIaIzFoOh9DPwbGlkCOasxOXhcLYRewoeApKBsZQ V484zVoRslcifkiJAws8pTwQRUkE/bYRhSvtGpxwwSMPdnqjCQvQ6BAKP4Z9v/kEEER2 Zw6g== X-Gm-Message-State: APjAAAXVGWcjikBGd+2kRVTOcNYphyqn4g6BaVT6wEmJMqDBfGKaBbTS wRnSIGq/8q44mWPRZ0jSYnB0OhABLRcmew== X-Google-Smtp-Source: APXvYqyu6n7HoKtW73I6bmR7b9yCXCzVyoPrRrWKJvExM8umAgR+ZD3X1S/OKEevg5PH5Sxrj6XJDQ== X-Received: by 2002:a65:6709:: with SMTP id u9mr5780827pgf.59.1570046816188; Wed, 02 Oct 2019 13:06:56 -0700 (PDT) Received: from [10.136.13.65] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id x11sm8343937pja.3.2019.10.02.13.06.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Oct 2019 13:06:55 -0700 (PDT) Subject: Re: [PATCH] ns2: Fix off by one bugs in ns2_pinmux_enable() To: Dan Carpenter , Ray Jui , Yendapally Reddy Dhananjaya Reddy Cc: Scott Branden , bcm-kernel-feedback-list@broadcom.com, Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20190926081426.GB2332@mwanda> From: Scott Branden Message-ID: <98717865-0417-96d7-58f3-84f6394a1bf3@broadcom.com> Date: Wed, 2 Oct 2019 13:06:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190926081426.GB2332@mwanda> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org thanks for fix. On 2019-09-26 1:14 a.m., Dan Carpenter wrote: > The pinctrl->functions[] array has pinctrl->num_functions elements and > the pinctrl->groups[] array is the same way. These are set in > ns2_pinmux_probe(). So the > comparisons should be >= so that we don't > read one element beyond the end of the array. > > Fixes: b5aa1006e4a9 ("pinctrl: ns2: add pinmux driver support for Broadcom NS2 SoC") > Signed-off-by: Dan Carpenter Acked-by: Scott Branden > --- > drivers/pinctrl/bcm/pinctrl-ns2-mux.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c > index 2bf6af7df7d9..9fabc451550e 100644 > --- a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c > +++ b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c > @@ -640,8 +640,8 @@ static int ns2_pinmux_enable(struct pinctrl_dev *pctrl_dev, > const struct ns2_pin_function *func; > const struct ns2_pin_group *grp; > > - if (grp_select > pinctrl->num_groups || > - func_select > pinctrl->num_functions) > + if (grp_select >= pinctrl->num_groups || > + func_select >= pinctrl->num_functions) > return -EINVAL; > > func = &pinctrl->functions[func_select];