From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 536F12F5307 for ; Tue, 17 Jun 2025 21:34:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750196044; cv=none; b=jTI8h2Ax8rYwDpSuOvzluN+wuJ1aTacOk/XKkEglQdwF9k9JtqFTWcmTyrc98wbLmEljdEFudd0tzgozGSM19myEDC3IxPD9oZurx1dX3nGc/6bAmxDOCkysBpLMlfR/D6IA1pwUlXXte84MS88rv3bHFrNedZQN+cP0WliAl+A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750196044; c=relaxed/simple; bh=Pl08BmccorofN96veIsvJhzpBR3459nI0QTAznB/bdw=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=DwggrkWbpmQ3gCTT6LLe4BeuYvvNySLJ74A+B9JtwJm9jQ88ebd0cW+MAhfVkQt77LKOyG08Ju2MiC2dM8RqAYLqYHm04/KoIRbGVsiWC951qiM9JtVRNEJgLOMVr/3ELfdBK1QDnA3zVcnlvHUYm9U/YiKPw219al1z8YvnNmg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=GyQcnGLv; arc=none smtp.client-ip=95.215.58.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="GyQcnGLv" Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1750196039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pl08BmccorofN96veIsvJhzpBR3459nI0QTAznB/bdw=; b=GyQcnGLvg8h6hfTrTnUw/0Mlbot+ywLtBdkd0+Vkkb4QwF7jiTY61UX6IL5bPLI/7IRtB9 22zhM/nLC9/bZ8M8bCprToPjuZ777Brfleg5eqdEpAxsoGyMEWOUDY20xXz8m3084PgtCf dB4URG47uJM+KMreFv0/V/KZEVLn6fc= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3853.100.6.1.1\)) Subject: Re: [PATCH 0/2] Add nokbdwakeup quirk and enable it for MSI Claw X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Matthew Schwartz In-Reply-To: <5isz34mtyxezwrhmvtedygszhhnstsqa4dmcttb33p5dgw47st@3n6wswp2p6di> Date: Tue, 17 Jun 2025 14:33:34 -0700 Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <98727492-5E7C-41A5-B0EF-1A21852FFB05@linux.dev> References: <20250617051930.3376981-1-matthew.schwartz@linux.dev> <5isz34mtyxezwrhmvtedygszhhnstsqa4dmcttb33p5dgw47st@3n6wswp2p6di> To: Dmitry Torokhov X-Migadu-Flow: FLOW_OUT > On Jun 17, 2025, at 1:50=E2=80=AFPM, Dmitry Torokhov = wrote: >=20 > Hi Matthew, >=20 > On Mon, Jun 16, 2025 at 10:19:28PM -0700, Matthew Schwartz wrote: >> This patch series aims to solve an issue on the MSI Claw, a series of >> handheld gaming PCs, where their volume buttons will wake the system = out >> of s2idle because they are registered via an i8042 keyboard device. = This >> is not expected behavior on a handheld device that lacks an actual >> keyboard, as it is very easy to press the volume buttons while = handling >> the device in its suspended state.=20 >>=20 >> To solve this, introduce a new quirk based on DMI match that will = disable >> the wakeup property of an i8042 keyboard device and enable it for = current >> MSI Claw models. >=20 > Why does this need to be done in kernel instead of having a udev rule > to toggle this through sysfs: >=20 > /sys/devices/platform/i8042/serio0/power/wakeup >=20 > Thanks. Yes this would work, but it would also mean relying on individual = distros to discover such a udev rule is necessary and figure out how to = ship this as a device specific workaround within userspace such that it = won=E2=80=99t apply to other devices that do want to maintain i8042 = keyboard wakeup functionality. I will investigate implementing this via = udev in some sort of packaged fashion, but a kernel quirk seemed like = the better option here in my opinion, especially because a quirk system = is already in place for i8042 within the kernel. >=20 > --=20 > Dmitry