From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F4163BED2D; Thu, 10 Sep 2026 06:17:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789021071; cv=none; b=sTkazAibx/S4oLHlMy1uWplWrGhIMSUQWxQperD+TJenXY+AJS6CHdSDQobynrtuH3tgQlGEfud0MRSBt8t42OwVJkMqeiWP/4RFIbAsaGaVXA3F1v28DcROB37jztcpfrrxO6n0jPfANprbVN6JnQph6pdRavXEG2mvB+fEpDA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789021071; c=relaxed/simple; bh=Ms0yOXypc5wLcy3yOT1m/Xn6XaaNftGOIeeUF3yXm08=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YeiAMa1ptOYV2zvxwJ1vwrMSb7EWnt+vwoOaqqqpqvcR8HkqOgGULG1LdVJ2Ok0CDTG6DC2SScsmFh/+uiHLRkhReXgUla+VRXpuSrBF+zVsn7otHbamkTbKJJePoN0o9skF6lf5+d1j9sskNVIRKmoooEu7jHQ6Z/3vPGlopZg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=cEvJl8++; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=uMOkTqbi; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=pUIROSvz; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=wG9UONeP; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="cEvJl8++"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="uMOkTqbi"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="pUIROSvz"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="wG9UONeP" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E50AC1FD84; Thu, 10 Sep 2026 06:17:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789021050; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3CVKuI/VbVmqDMc9J2e9l/Z4QHyH87FLXFKjl6Gc9/U=; b=cEvJl8++LGlfWfctJgtEtaL7Y3fwVSwo68yxCS/1rahqy9rw2qIfDnrO6zLH+Lgp4K+pMD MbebRaiUVKkHulK678pik9GboUYD8CMCN3nZkfz9b5Yi4r2FZY6y85JyGU00WE2LHtUfrz IZn5oLEyY6R1k7Sce8lVdR5UGsNKrYg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789021050; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3CVKuI/VbVmqDMc9J2e9l/Z4QHyH87FLXFKjl6Gc9/U=; b=uMOkTqbiB0lGRjs0OoeYX7QQDtPc+Ims+sduLXcsDOo2ftKGjEjQ0X0qTauZUPydcmgoGc cJNQ12hrdVJO+JAQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=pUIROSvz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=wG9UONeP DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789021045; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3CVKuI/VbVmqDMc9J2e9l/Z4QHyH87FLXFKjl6Gc9/U=; b=pUIROSvzA4484QtT5UKZlHKVs9WYqhhw+DrCpLELN5jp63+FtMLVRXdKWOFh2p4tvNkoEX 7rNDnVHzrOqch0jXNhfovOcbk+NSpG8j/inaAq+l969JZAg+loEEVrGJ05NvQPCIpnPS8A iJzFdvfkcjTZewO2BIBrG0KTRMfHpTY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789021045; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3CVKuI/VbVmqDMc9J2e9l/Z4QHyH87FLXFKjl6Gc9/U=; b=wG9UONePj5uqzv+ae30mggYxUVYDQe5vnZ2sMsFytCQfgr0Yvp5olVEwr79n+0KUZRPsAl kv6MLKmF9NSq1/Bg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 87C6713185; Thu, 10 Sep 2026 06:17:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ZRLuFXVLomoCVgAAD6G6ig (envelope-from ); Thu, 10 Sep 2026 06:17:25 +0000 Message-ID: <987a45d3-2765-4583-b417-6aae5d350c45@suse.de> Date: Thu, 10 Sep 2026 08:17:24 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/gud: Ignore damage clips in full update mode To: Sophie D , Ruben Wauters Cc: Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260907230849.31032-1-patches@scd31.com> <20260910014910.8564-1-patches@scd31.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260910014910.8564-1-patches@scd31.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Level: X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: E50AC1FD84 X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FREEMAIL_ENVRCPT(0.00)[aol.com,gmail.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[9]; MID_RHS_MATCH_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[linux.intel.com,kernel.org,gmail.com,ffwll.ch,lists.freedesktop.org,vger.kernel.org]; FREEMAIL_TO(0.00)[scd31.com,aol.com]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim,suse.de:email,suse.de:mid,suse.com:url,scd31.com:email]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Spam-Flag: NO X-Spam-Score: -4.51 Am 10.09.26 um 03:49 schrieb Sophie D: > When running in full update mode, previously small updates (such as > moving the mouse across the screen) would cause many full frames to be > generated. This would bog down the bus and lower the effective framerate > significantly - I was seeing a drop from 60 FPS to 2 FPS. > > Set ignore_damage_clips in full update mode so the damage iterator > yields a single full-plane rectangle instead of one per clip. > > Fixes: 73cfd166e045 ("drm/gud: Replace simple display pipe with DRM atomic helpers") > Cc: # 6.18.x > Signed-off-by: Sophie D Reviewed-by: Thomas Zimmermann Thanks for the fix. > --- > v2: set ignore_damage_clips in atomic_check instead of merging clips in > atomic_update (Thomas Zimmermann) > > drivers/gpu/drm/gud/gud_pipe.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/gud/gud_pipe.c b/drivers/gpu/drm/gud/gud_pipe.c > index 5ef887d84..3388fdc8e 100644 > --- a/drivers/gpu/drm/gud/gud_pipe.c > +++ b/drivers/gpu/drm/gud/gud_pipe.c > @@ -482,6 +482,9 @@ int gud_plane_atomic_check(struct drm_plane *plane, > if (!new_plane_state->visible) > return 0; > > + if (gdrm->flags & GUD_DISPLAY_FLAG_FULL_UPDATE) > + new_plane_state->ignore_damage_clips = true; > + > if (old_plane_state->rotation != new_plane_state->rotation) > crtc_state->mode_changed = true; > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)