From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753993AbdJIIgY (ORCPT ); Mon, 9 Oct 2017 04:36:24 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:39589 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751733AbdJIIgV (ORCPT ); Mon, 9 Oct 2017 04:36:21 -0400 X-AuditID: cbfec7f2-f793b6d000003243-33-59db3501bfb1 MIME-version: 1.0 Content-type: text/plain; charset="utf-8"; format="flowed" Subject: Re: [PATCH 3/3] iio: adc: ina2xx: Allow setting Shunt Voltage PGA gain and Bus Voltage range To: Jonathan Cameron , =?UTF-8?Q?Stefan_Br=c3=bcns?= Cc: linux-iio@vger.kernel.org, Peter Meerwald-Stadler , linux-kernel@vger.kernel.org, "Andrew F . Davis" , Javier Martinez Canillas , Lars-Peter Clausen , Hartmut Knaack From: Maciej Purski Message-id: <987bc8e8-c1a6-1bfe-f963-92f4aaa40411@samsung.com> Date: Mon, 09 Oct 2017 10:36:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 In-reply-to: <20171008110756.6eb9cab7@archlinux> Content-language: en-US Content-transfer-encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRzGec/Zzs5Gi+O0/KemMPKLlJkVHE3NIOp8SLAIalLZyMO03LQd lUw/eEHbFPHObIpFZB/UUpZprfAyTMNFWkp5J6w0w5nXTERr25ngtx/v8/xvDy+Jy0xCLzJB k8JqNcpEOSERtPasfziEjo8pgsyzNP27r1REz9kaMfprTj1Gm//N4fTj8gdCurZ7XkAPmmsI esPcI6Kz+2qEkWJmYfEaY6rXE8zjOYuQaSmeEDH9ud2I6Z+0EUzvcBvGLJt8o8kYSVgcm5iQ xmoPR1yXxI9U+yY/j7jTYDXjWagyqACJSaCOQXP3OMHzXhiYbHKyjKpD8KXoZgGS2HkZQe2r TuF2wcJaNsYLTxAU/lnCHYKUcoO/5ZMCB+NUKExv5Ql50zSC+bpakUNwp1RgLHjmNHnYufTp LOEw4ZQeg/WSAXsFSRJUADTei+WbRsCnH53OWgHlD7acSeewPdRlGDCtYw4WU0FQs1ruGuwJ uXkjLvaDrqEZgaM/UGsEVL3fcp1wGlaMehHP7vCrt8XFPqDXdWE8Z8DHVbMrl0zIHmt2eU7A clkLzg/YDWWtBtyxM1BS0OXLeAsDuva3rudT8K2L5BPdQNDemVyC/Iw74jLuiMu44wLjjgse IkE98mBTObWK5Y4Gcko1l6pRBd5IUpuQ/SdZt3qXXqLVd6EWRJFIvks6XDWqkAmVaVy62oKA xOUe0sXgMYVMGqdMv8tqk2K1qYksZ0HepEDuKQ2PyVfIKJUyhb3FssmsdlvFSLFXFuo0Rt1O rogUzXTM96YZLNOMDzcR2ENsNISEvcCKbBXVbSVluRc/G0TWyvtn9CHrCqg86JN1cso9Vp8Y rbP2j15J8vzpNZCfGmXUCLNEQ8MxKebXU94GZjM8p1TudiEjv7Amc3ZQwlw6f0DctFK8uf/q 2Tdz3x9JxoP3nfPvGJQLuHjlkQBcyyn/A3+ozZpFAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupikeLIzCtJLcpLzFFi42I5/e/4FV1G09uRBk13FCzen5rIbvHm7Rom iwdNq5gsdv1/w2yxZPJ8Vot5R96xWFzeNYfN4veuY+wWjafmsDpwenz4GOexaVUnm8eSN4dY Pbb032X3ON98hNHj/L23bB7Hb2xn8vi8SS6AI4rLJiU1J7MstUjfLoEr4+ZsuYLNdhWrT+9i bmCcatDFyMkhIWAi8eF7IxOELSZx4d56ti5GLg4hgSWMEj+Pr2UBSfAKCEr8mHwPzGYWMJP4 8vIwK0TRM0aJGX+XsoIkhAXSJW6uusAIYosA2ZPu3QMrYhboZJJY1b2REaLjN6PE5fPzgRwO DjYBLYk17fEQG+wkLj09wA5iswioSrxtuscMUiIqECGxYSM/SJhTwEBiztfJUEeISzS33oSy 5SUOXnnOMoFRcBaSW2chuXUWkpZZSFoWMLKsYhRJLS3OTc8tNtQrTswtLs1L10vOz93ECIyh bcd+bt7BeGlj8CFGAQ5GJR7ehmm3IoVYE8uKK3MPMUpwMCuJ8H40uh0pxJuSWFmVWpQfX1Sa k1p8iFGag0VJnLd3z+pIIYH0xJLU7NTUgtQimCwTB6dUAyNPvFdXfxTvpCniuw2ElrxQ/e13 /B6fttlyAau4a6vW/LxtJB/LP9dXcYppz2Wj05tr3Sctf6KnHXtfY9aZ7585LvS/6N5ZqJTC LVd9KO+n7jH3RRIbUv9eMD1/N2Ga7/+cNRyvrnx60tLr4LnvX+KsQlWXBbnsZ9P0/q34+jv0 rZCK0xRtK0ElluKMREMt5qLiRAClAYdpnQIAAA== X-CMS-MailID: 20171009083617eucas1p1ad6630f05793b4298e8d1f8a8d60ee82 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?TWFjaWVqIFB1cnNraRtTZWN1cml0eSAoVFApG1NhbXN1bmcg?= =?UTF-8?B?RWxlY3Ryb25pY3MbVHJhaW5lZSAoKQ==?= X-Global-Sender: =?UTF-8?B?TWFjaWVqIFB1cnNraRtTZWN1cml0eSAoVFApG1NhbXN1bmcg?= =?UTF-8?B?RWxlY3Ryb25pY3MbVHJhaW5lZSAoKQ==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTU=?= CMS-TYPE: 201P X-CMS-RootMailID: 20171008100804epcas1p3d852423023b6516d064c7276d2f0fc1f X-RootMTR: 20171008100804epcas1p3d852423023b6516d064c7276d2f0fc1f References: <20171001194818.26017-1-stefan.bruens@rwth-aachen.de> <18deb1c0-05f7-4ca9-947e-09da4d2e10a6@rwthex-w2-a.rwth-ad.de> <20171008110756.6eb9cab7@archlinux> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/08/2017 12:07 PM, Jonathan Cameron wrote: > On Sun, 1 Oct 2017 21:48:18 +0200 > Stefan Brüns wrote: > >> Reducing shunt and bus voltage range improves the accuracy, so allow >> altering the default settings. >> >> Both settings are exposed as gain values. While for the shunt voltage >> this is straightforward, the bus range settings of 32V (default) and 16V >> are mapped to gain values of 1 resp. 2, to provide a uniform API to >> userspace. >> >> As the gain settings are incorporated into the raw values by the sensor >> itself, adjusting of the scale attributes is not necessary. >> >> Signed-off-by: Stefan Brüns > > cc'd Maciej Purski who is working to improve the current calibration > elements - I'd like you both to review each others patches if possible > as the ABI is getting complex in here! > > I think what you have here won't interfere with Maciej's work, but > would like you two to confirm that. Note that patch set probably > needs a revision as I've suggested a rather different approach. > > Thanks, > > Jonathan > Hi, it looks fine to me. The patches shouldn't interfere with each other. Regards, Maciej >> >> --- >> >> drivers/iio/adc/ina2xx-adc.c | 111 +++++++++++++++++++++++++++++++++++++++++-- >> 1 file changed, 108 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c >> index 1930f853e8c5..7e9ce43ad15d 100644 >> --- a/drivers/iio/adc/ina2xx-adc.c >> +++ b/drivers/iio/adc/ina2xx-adc.c >> @@ -48,8 +48,10 @@ >> #define INA2XX_MAX_REGISTERS 8 >> >> /* settings - depend on use case */ >> -#define INA219_CONFIG_DEFAULT 0x399F /* PGA=8 */ >> +#define INA219_CONFIG_DEFAULT 0x399F /* PGA=1/8, BRNG=32V */ >> #define INA219_DEFAULT_IT 532 >> +#define INA219_DEFAULT_BRNG 1 /* 32V */ >> +#define INA219_DEFAULT_PGA 125 /* 1000/8 */ >> #define INA226_CONFIG_DEFAULT 0x4327 >> #define INA226_DEFAULT_AVG 4 >> #define INA226_DEFAULT_IT 1110 >> @@ -62,6 +64,14 @@ >> */ >> #define INA2XX_MODE_MASK GENMASK(3, 0) >> >> +/* Gain for VShunt: 1/8 (default), 1/4, 1/2, 1 */ >> +#define INA219_PGA_MASK GENMASK(12, 11) >> +#define INA219_SHIFT_PGA(val) ((val) << 11) >> + >> +/* VBus range: 32V (default), 16V */ >> +#define INA219_BRNG_MASK BIT(13) >> +#define INA219_SHIFT_BRNG(val) ((val) << 13) >> + >> /* Averaging for VBus/VShunt/Power */ >> #define INA226_AVG_MASK GENMASK(11, 9) >> #define INA226_SHIFT_AVG(val) ((val) << 9) >> @@ -131,6 +141,8 @@ struct ina2xx_chip_info { >> int avg; >> int int_time_vbus; /* Bus voltage integration time uS */ >> int int_time_vshunt; /* Shunt voltage integration time uS */ >> + int range_vbus; /* Bus voltage maximum in V */ >> + int pga_gain_vshunt; /* Shunt voltage PGA gain */ >> bool allow_async_readout; >> }; >> >> @@ -227,6 +239,18 @@ static int ina2xx_read_raw(struct iio_dev *indio_dev, >> *val = 1; >> return IIO_VAL_INT; >> } >> + >> + case IIO_CHAN_INFO_HARDWAREGAIN: >> + switch (chan->address) { >> + case INA2XX_SHUNT_VOLTAGE: >> + *val = chip->pga_gain_vshunt; >> + *val2 = 1000; >> + return IIO_VAL_FRACTIONAL; >> + >> + case INA2XX_BUS_VOLTAGE: >> + *val = chip->range_vbus == 32 ? 1 : 2; >> + return IIO_VAL_INT; >> + } >> } >> >> return -EINVAL; >> @@ -361,6 +385,74 @@ static int ina219_set_int_time_vshunt(struct ina2xx_chip_info *chip, >> return 0; >> } >> >> +static const int ina219_vbus_range_tab[] = { 1, 2 }; >> +static int ina219_set_vbus_range_denom(struct ina2xx_chip_info *chip, >> + unsigned int range, >> + unsigned int *config) >> +{ >> + if (range == 1) >> + chip->range_vbus = 32; >> + else if (range == 2) >> + chip->range_vbus = 16; >> + else >> + return -EINVAL; >> + >> + *config &= ~INA219_BRNG_MASK; >> + *config |= INA219_SHIFT_BRNG(range == 1 ? 1 : 0) & INA219_BRNG_MASK; >> + >> + return 0; >> +} >> + >> +static const int ina219_vshunt_gain_tab[] = { 125, 250, 500, 1000 }; >> +static const int ina219_vshunt_gain_frac[] = { >> + 125, 1000, 250, 1000, 500, 1000, 1000, 1000 }; >> + >> +static int ina219_set_vshunt_pga_gain(struct ina2xx_chip_info *chip, >> + unsigned int gain, >> + unsigned int *config) >> +{ >> + int bits; >> + >> + if (gain < 125 || gain > 1000) >> + return -EINVAL; >> + >> + bits = find_closest(gain, ina219_vshunt_gain_tab, >> + ARRAY_SIZE(ina219_vshunt_gain_tab)); >> + >> + chip->pga_gain_vshunt = ina219_vshunt_gain_tab[bits]; >> + bits = 3 - bits; >> + >> + *config &= ~INA219_PGA_MASK; >> + *config |= INA219_SHIFT_PGA(bits) & INA219_PGA_MASK; >> + >> + return 0; >> +} >> + >> +static int ina2xx_read_avail(struct iio_dev *indio_dev, >> + struct iio_chan_spec const *chan, >> + const int **vals, int *type, int *length, >> + long mask) >> +{ >> + switch (mask) { >> + case IIO_CHAN_INFO_HARDWAREGAIN: >> + switch (chan->address) { >> + case INA2XX_SHUNT_VOLTAGE: >> + *type = IIO_VAL_FRACTIONAL; >> + *length = sizeof(ina219_vshunt_gain_frac) / sizeof(int); >> + *vals = ina219_vshunt_gain_frac; >> + return IIO_AVAIL_LIST; >> + >> + case INA2XX_BUS_VOLTAGE: >> + *type = IIO_VAL_INT; >> + *length = sizeof(ina219_vbus_range_tab) / sizeof(int); >> + *vals = ina219_vbus_range_tab; >> + return IIO_AVAIL_LIST; >> + } >> + } >> + >> + return -EINVAL; >> +} >> + >> static int ina2xx_write_raw(struct iio_dev *indio_dev, >> struct iio_chan_spec const *chan, >> int val, int val2, long mask) >> @@ -403,6 +495,14 @@ static int ina2xx_write_raw(struct iio_dev *indio_dev, >> } >> break; >> >> + case IIO_CHAN_INFO_HARDWAREGAIN: >> + if (chan->address == INA2XX_SHUNT_VOLTAGE) >> + ret = ina219_set_vshunt_pga_gain(chip, val * 1000000 + >> + val2, &tmp); >> + else >> + ret = ina219_set_vbus_range_denom(chip, val, &tmp); >> + break; >> + >> default: >> ret = -EINVAL; >> } >> @@ -547,7 +647,10 @@ static ssize_t ina2xx_shunt_resistor_store(struct device *dev, >> .channel = (_index), \ >> .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \ >> BIT(IIO_CHAN_INFO_SCALE) | \ >> - BIT(IIO_CHAN_INFO_INT_TIME), \ >> + BIT(IIO_CHAN_INFO_INT_TIME) | \ >> + BIT(IIO_CHAN_INFO_HARDWAREGAIN), \ >> + .info_mask_separate_available = \ >> + BIT(IIO_CHAN_INFO_HARDWAREGAIN), \ >> .info_mask_shared_by_dir = BIT(IIO_CHAN_INFO_SAMP_FREQ), \ >> .scan_index = (_index), \ >> .scan_type = { \ >> @@ -758,7 +861,6 @@ static IIO_CONST_ATTR_NAMED(ina226_integration_time_available, >> integration_time_available, >> "0.000140 0.000204 0.000332 0.000588 0.001100 0.002116 0.004156 0.008244"); >> >> - >> static IIO_DEVICE_ATTR(in_allow_async_readout, S_IRUGO | S_IWUSR, >> ina2xx_allow_async_readout_show, >> ina2xx_allow_async_readout_store, 0); >> @@ -793,6 +895,7 @@ static const struct iio_info ina219_info = { >> .driver_module = THIS_MODULE, >> .attrs = &ina219_attribute_group, >> .read_raw = ina2xx_read_raw, >> + .read_avail = ina2xx_read_avail, >> .write_raw = ina2xx_write_raw, >> .debugfs_reg_access = ina2xx_debug_reg, >> }; >> @@ -874,6 +977,8 @@ static int ina2xx_probe(struct i2c_client *client, >> chip->avg = 1; >> ina219_set_int_time_vbus(chip, INA219_DEFAULT_IT, &val); >> ina219_set_int_time_vshunt(chip, INA219_DEFAULT_IT, &val); >> + ina219_set_vbus_range_denom(chip, INA219_DEFAULT_BRNG, &val); >> + ina219_set_vshunt_pga_gain(chip, INA219_DEFAULT_PGA, &val); >> } >> >> ret = ina2xx_init(chip, val); > > > >