From: Jessica Zhang <quic_jesszhan@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>,
"Marijn Suijten" <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krishna Manikandan <quic_mkrishn@quicinc.com>,
Jonathan Marek <jonathan@marek.ca>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Neil Armstrong <neil.armstrong@linaro.org>
Cc: <linux-arm-msm@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<freedreno@lists.freedesktop.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Srini Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH v2 08/16] drm/msm/dpu: Drop useless comments
Date: Wed, 19 Feb 2025 13:19:25 -0800 [thread overview]
Message-ID: <987f0dae-be8e-4818-b69b-dde03134d440@quicinc.com> (raw)
In-Reply-To: <20250217-b4-sm8750-display-v2-8-d201dcdda6a4@linaro.org>
On 2/17/2025 8:41 AM, Krzysztof Kozlowski wrote:
> Drop comments about SoC before each 'struct dpu_lm_sub_blks' for given
> SoC because it's duplicating the actual name of structure.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> index 7ea424d7c1b75e06312692225f4e888e81621283..4ff29be965c39b29cf7e3b9761634b7f39ca97b0 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> @@ -362,8 +362,6 @@ static const struct dpu_sspp_sub_blks dpu_dma_sblk = _DMA_SBLK();
> * MIXER sub blocks config
> *************************************************************/
>
> -/* MSM8998 */
> -
> static const struct dpu_lm_sub_blks msm8998_lm_sblk = {
> .maxwidth = DEFAULT_DPU_OUTPUT_LINE_WIDTH,
> .maxblendstages = 7, /* excluding base layer */
> @@ -373,8 +371,6 @@ static const struct dpu_lm_sub_blks msm8998_lm_sblk = {
> },
> };
>
> -/* SDM845 */
> -
> static const struct dpu_lm_sub_blks sdm845_lm_sblk = {
> .maxwidth = DEFAULT_DPU_OUTPUT_LINE_WIDTH,
> .maxblendstages = 11, /* excluding base layer */
> @@ -384,8 +380,6 @@ static const struct dpu_lm_sub_blks sdm845_lm_sblk = {
> },
> };
>
> -/* SC7180 */
> -
> static const struct dpu_lm_sub_blks sc7180_lm_sblk = {
> .maxwidth = DEFAULT_DPU_OUTPUT_LINE_WIDTH,
> .maxblendstages = 7, /* excluding base layer */
> @@ -394,8 +388,6 @@ static const struct dpu_lm_sub_blks sc7180_lm_sblk = {
> },
> };
>
> -/* QCM2290 */
> -
> static const struct dpu_lm_sub_blks qcm2290_lm_sblk = {
> .maxwidth = DEFAULT_DPU_LINE_WIDTH,
> .maxblendstages = 4, /* excluding base layer */
>
> --
> 2.43.0
>
next prev parent reply other threads:[~2025-02-19 21:19 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 16:41 [PATCH v2 00/16] drm/msm: Add support for SM8750 Krzysztof Kozlowski
2025-02-17 16:41 ` [PATCH v2 01/16] dt-bindings: display/msm: dsi-controller-main: Combine if:then: entries Krzysztof Kozlowski
2025-02-19 23:19 ` Rob Herring (Arm)
2025-02-17 16:41 ` [PATCH v2 02/16] dt-bindings: display/msm: dsi-controller-main: Add missing minItems Krzysztof Kozlowski
2025-02-19 23:20 ` Rob Herring (Arm)
2025-02-17 16:41 ` [PATCH v2 03/16] dt-bindings: display/msm: dsi-phy-7nm: Add SM8750 Krzysztof Kozlowski
2025-02-19 23:20 ` Rob Herring (Arm)
2025-02-17 16:41 ` [PATCH v2 04/16] dt-bindings: display/msm: dsi-controller-main: " Krzysztof Kozlowski
2025-02-19 23:21 ` Rob Herring (Arm)
2025-02-17 16:41 ` [PATCH v2 05/16] dt-bindings: display/msm: dp-controller: " Krzysztof Kozlowski
2025-02-17 18:58 ` Dmitry Baryshkov
2025-02-19 17:02 ` Krzysztof Kozlowski
2025-02-19 17:08 ` Dmitry Baryshkov
2025-02-24 18:59 ` Abhinav Kumar
2025-02-25 3:14 ` Dmitry Baryshkov
2025-03-03 21:23 ` Abhinav Kumar
2025-03-04 0:06 ` Dmitry Baryshkov
2025-02-17 16:41 ` [PATCH v2 06/16] dt-bindings: display/msm: qcom,sm8650-dpu: " Krzysztof Kozlowski
2025-02-19 23:23 ` Rob Herring (Arm)
2025-02-17 16:41 ` [PATCH v2 07/16] dt-bindings: display/msm: qcom,sm8750-mdss: " Krzysztof Kozlowski
2025-02-19 23:27 ` Rob Herring
2025-02-17 16:41 ` [PATCH v2 08/16] drm/msm/dpu: Drop useless comments Krzysztof Kozlowski
2025-02-17 19:22 ` Dmitry Baryshkov
2025-02-19 21:19 ` Jessica Zhang [this message]
2025-02-17 16:41 ` [PATCH v2 09/16] drm/msm/dpu: Add LM_7, DSC_[67], PP_[67] and MERGE_3D_5 Krzysztof Kozlowski
2025-02-17 19:00 ` Dmitry Baryshkov
2025-02-19 21:22 ` Jessica Zhang
2025-02-19 21:24 ` Jessica Zhang
2025-02-17 16:41 ` [PATCH v2 10/16] drm/msm/dpu: Add handling of LM_6 and LM_7 bits in pending flush mask Krzysztof Kozlowski
2025-02-17 19:01 ` Dmitry Baryshkov
2025-02-19 21:28 ` Jessica Zhang
2025-02-17 16:41 ` [PATCH v2 11/16] drm/msm/dsi/phy: Add support for SM8750 Krzysztof Kozlowski
2025-02-17 19:03 ` Dmitry Baryshkov
2025-02-20 0:50 ` Jessica Zhang
2025-02-21 10:41 ` Krzysztof Kozlowski
2025-02-21 10:43 ` Krzysztof Kozlowski
2025-02-17 16:41 ` [PATCH v2 12/16] drm/msm/dsi: " Krzysztof Kozlowski
2025-02-17 19:05 ` Dmitry Baryshkov
2025-02-21 11:14 ` Krzysztof Kozlowski
2025-02-21 11:14 ` Krzysztof Kozlowski
2025-02-17 16:41 ` [PATCH v2 13/16] drm/msm/dpu: " Krzysztof Kozlowski
2025-02-17 19:07 ` Dmitry Baryshkov
2025-02-17 16:41 ` [PATCH v2 14/16] drm/msm/dpu: Add missing "fetch" name to set_active_pipes() Krzysztof Kozlowski
2025-02-17 19:08 ` Dmitry Baryshkov
2025-02-20 22:52 ` Jessica Zhang
2025-02-17 16:41 ` [PATCH v2 15/16] drm/msm/dpu: Implement new v12.0 DPU differences Krzysztof Kozlowski
2025-02-17 19:18 ` Dmitry Baryshkov
2025-02-19 17:04 ` Krzysztof Kozlowski
2025-02-19 17:24 ` Dmitry Baryshkov
2025-02-21 12:36 ` Krzysztof Kozlowski
2025-02-21 13:33 ` Dmitry Baryshkov
2025-02-17 16:41 ` [PATCH v2 16/16] drm/msm/mdss: Add support for SM8750 Krzysztof Kozlowski
2025-02-19 21:17 ` [PATCH v2 00/16] drm/msm: " Jessica Zhang
2025-02-19 22:02 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=987f0dae-be8e-4818-b69b-dde03134d440@quicinc.com \
--to=quic_jesszhan@quicinc.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_mkrishn@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=srinivas.kandagatla@linaro.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®