mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: MANISH PANDEY <quic_mapa@quicinc.com>
To: Bart Van Assche <bvanassche@acm.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <quic_cang@quicinc.com>,
	<quic_nguyenb@quicinc.com>, <quic_nitirawa@quicinc.com>,
	<quic_bhaskarv@quicinc.com>, <quic_narepall@quicinc.com>,
	<quic_rampraka@quicinc.com>
Subject: Re: [PATCH 3/3] scsi: ufs: ufs-qcom: Apply DELAY_AFTER_LPM quirk for Toshiba devices
Date: Tue, 27 Aug 2024 10:36:03 +0530	[thread overview]
Message-ID: <9881058a-5897-4f01-a5ed-7ae6c58b0906@quicinc.com> (raw)
In-Reply-To: <7527d15c-9318-47f7-99f8-028c865a698b@acm.org>



On 8/21/2024 3:05 AM, Bart Van Assche wrote:
> On 8/20/24 5:37 AM, Manish Pandey wrote:
>> +    { .wmanufacturerid = UFS_VENDOR_TOSHIBA,
>> +      .model = UFS_ANY_MODEL,
>> +      .quirk = UFS_DEVICE_QUIRK_DELAY_AFTER_LPM },
> 
> Isn't three patches a bit much for these changes? I think all three
> patches can be combined into a single patch without making it harder for
> reviewers to understand what is going on.
> 
> Thanks,
> 
> Bart.
> 
> 

Thanks Bart for quick review.
I will merge all 3 changes to a single change in next patch set [V2].

Regards
Manish

      reply	other threads:[~2024-08-27  5:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-20 12:37 [PATCH 0/3] add fixup_dev_quirks vops for ufs-qcom Manish Pandey
2024-08-20 12:37 ` [PATCH 1/3] scsi: ufs: ufs-qcom: add fixup_dev_quirks vops Manish Pandey
2024-08-20 21:32   ` Bart Van Assche
2024-08-20 12:37 ` [PATCH 2/3] scsi: ufs: ufs-qcom: Add DELAY_BEFORE_LPM quirk for Micron and Skhynix Manish Pandey
2024-08-20 21:33   ` Bart Van Assche
2024-08-20 12:37 ` [PATCH 3/3] scsi: ufs: ufs-qcom: Apply DELAY_AFTER_LPM quirk for Toshiba devices Manish Pandey
2024-08-20 21:35   ` Bart Van Assche
2024-08-27  5:06     ` MANISH PANDEY [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9881058a-5897-4f01-a5ed-7ae6c58b0906@quicinc.com \
    --to=quic_mapa@quicinc.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=bvanassche@acm.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=martin.petersen@oracle.com \
    --cc=quic_bhaskarv@quicinc.com \
    --cc=quic_cang@quicinc.com \
    --cc=quic_narepall@quicinc.com \
    --cc=quic_nguyenb@quicinc.com \
    --cc=quic_nitirawa@quicinc.com \
    --cc=quic_rampraka@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®