From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87400768EA for ; Wed, 15 Jul 2026 00:13:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784074422; cv=none; b=ST0P7FrMZ2zb/qdjT+lP/U62G1ycSVEbi14jEhGADLMEeVa5sl03p6cEt3W7HG6I+g1qj4BmT08JC7XuSoPJLHJJat5sIsHMbDTdLW0bc+KfO1L4J1GPShb1wqm7xv9qiqTYfPuNIFklKQ6kLqishyTTufNhUFxu7bCfzBIEtiA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784074422; c=relaxed/simple; bh=8AXyAqhasfY7wRdYuXm0Py4OabfXua0ulV/T1L8jNEw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jXTxwXSOuEbQGb1bSKRvU/Zla3NOoWg/+ci62f3F5BTEOYpmdRwDLgc0sw/4QNU4w3bqzzj5h3cSF4KKidAbJlWrR8JKwk5OPM5/rqzyC62O7EFKUKMM26otDqZO2dsCWEHuivFgASQcpsBaJgowsTP5tPH6LP+yi6fRXGrySFM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hjeO4YTG; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=FAvB13di; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hjeO4YTG"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="FAvB13di" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784074419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aADQWG87fq6XITbxBIYillliqdnDSadEcTkAR2o/L7Q=; b=hjeO4YTGKTf5UnBFkbukJSlnns4YB9f5iJS1J/FDP3h1XXtd1NhLUFw8bId63z8hfw38wX AO+0AZYGqYl/RPcXjkLO1GqHZDXL0u2x0M2jv28S0rS3yB/AlWEZ5dnUmjAqRwVuix/TnK xgYvX21dei4S/ngHccRtCr7uLYhYvHY= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-Uo9XUrMiOAC9_BXFGiWE9Q-1; Tue, 14 Jul 2026 20:13:38 -0400 X-MC-Unique: Uo9XUrMiOAC9_BXFGiWE9Q-1 X-Mimecast-MFC-AGG-ID: Uo9XUrMiOAC9_BXFGiWE9Q_1784074417 Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c890bac374eso12391386a12.1 for ; Tue, 14 Jul 2026 17:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784074417; x=1784679217; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aADQWG87fq6XITbxBIYillliqdnDSadEcTkAR2o/L7Q=; b=FAvB13diBei5DZx9oiTJvqRndOcuCYRVl9LegMwatpQObpnb7CxL2xGHajneNbCApc FIe8Dk9GubqWdTlJJ8HMadmi51w9jcQqewmW7sur01/E+aA3+UpOzcCIDVEUGYz+gY4A sIvyVRmATMk8FCJS9ert+NMc6tKgr1iXOCtNpXsQwOEd1PdjQAN6IF9UJ8/lIkSg6IWT DB8ir5dWFObT1eo/540S6xhcsM0mM2CPi7rMjAXx92MMM/H38dNbTM8Qg+UOCkuKpt9l xNbDNapB8c4KICwn2NBbbeq83Na6lPVlQKKHOT4wjvVccmqDwX48uE2YsgP7EoSHUpTm 7fJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784074417; x=1784679217; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aADQWG87fq6XITbxBIYillliqdnDSadEcTkAR2o/L7Q=; b=jy6X+PWyi1LpKsZwfm/hyfUxDS9LM8C6Pw5mFGhcYVMhiZwG96ACn/OrJ9nbk2JCgC 8iP67yZaozktrF9a0uTma8fzV4351L0IITahV0oCuQ6xDg71QamBwTKvIu0PiBKn6DGs xyNXOJEFGP5tTzJv/NWAnWn0WaNptlWNHYYsfyE+de88QPzs00gRkFQGtN8aHL5fwzKO NgBnbQPnOrtUgzN6KIhQLoCR8tdpAmbA5vcB5gEbLWhauUJwqZpmy25yMkqzVRAoQkEv Jta4swv14oFC5FmS/gmTcfLTZ+n+lSEVRiGMl9+C9O1npZINoT/+4w7+rZ0VRLoBwYKc wTRg== X-Forwarded-Encrypted: i=1; AHgh+Ro2hdUVbT+970RwpBYLHeDLrM8cqI7FwDNXYX7agaMzBX6TMOruFUAUgqFv6eGWqbtt0rJuxHxiYX4CXkI=@vger.kernel.org X-Gm-Message-State: AOJu0YxGGEVQ2HOhFbUeBd4OdqMOHIPsqmXiQz4Gy8OfT5ej+qnNpt+5 NedwbZ5AdikikqV5Y+g5teGsBrWGHr/lE50/Bt9nW2tpON5rlqeppnSVhceFHFlQJF+5kZcCAqp 8qvGi8h5hm+zlUjiUHO7rz9cHMpGNmxe32Vb3DUcVYlvyASg0lWlMr1xRFMMcs+rMYQ== X-Gm-Gg: AfdE7cnKQNkIdAk4Wq2hoifzmD0fM3jXN985lqVr/XP3djX43tL0NQ62lBNFHDLulic 1pshZB6ytuKcRB985ikEELP/ubWNUIH+iY/LPqVEn/aRZ7R7utc7bzeogEjkj7z5WnUHoGx1vwI dTveNh7lSkZqzdeNfpoBVKmFARLvQYuq4X/00ncQKRSn9uGF1fqRfF7m19ljBTedPOuoRlIduKh QE+nXLf40dv8CfTpiWrek2InNiVz9j1qkBGEOkGpMYvSKxtBrTmNjkgkEw+1OpnU0xZsczfsk/O hTfNcAg8PfFGQdlCYN+IlJomkH3tbmwS/K+48+Bl/I3KA2Y7V+usGzlgII9G6wDAwM+kZZhq2hW QnV/fePEJXfC7A2QkSa2waedk0THecxMhQTd5WKmEMcTf1b5QTjFOlw== X-Received: by 2002:a05:6a21:3998:b0:3bf:6c08:fb98 with SMTP id adf61e73a8af0-3c36c4099b7mr705226637.58.1784074416918; Tue, 14 Jul 2026 17:13:36 -0700 (PDT) X-Received: by 2002:a05:6a21:3998:b0:3bf:6c08:fb98 with SMTP id adf61e73a8af0-3c36c4099b7mr705190637.58.1784074416440; Tue, 14 Jul 2026 17:13:36 -0700 (PDT) Received: from [192.168.68.51] (n175-34-8-244.mrk21.qld.optusnet.com.au. [175.34.8.244]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b659c865asm92038212c88.11.2026.07.14.17.13.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jul 2026 17:13:35 -0700 (PDT) Message-ID: <9892de2f-9e29-41ff-997b-a6a2e7c98585@redhat.com> Date: Wed, 15 Jul 2026 10:13:28 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/3] x86,fs/resctrl,arm_mpam: Factor MBA parse-time conversion to be per-arch To: Ben Horgan Cc: james.morse@arm.com, reinette.chatre@intel.com, fenghuay@nvidia.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, corbet@lwn.net, x86@kernel.org, linux-doc@vger.kernel.org, dave.martin@arm.com References: <20260709093111.367851-1-ben.horgan@arm.com> Content-Language: en-US From: Gavin Shan In-Reply-To: <20260709093111.367851-1-ben.horgan@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/9/26 7:31 PM, Ben Horgan wrote: > This version fixes a couple of non-functional mistakes in v4 pointed out by Reinette. > > The patches should stay together so please could this all go via tip. > > Changelogs in patches. > > From cover letter of v3: > > This is a new version of Dave Martin's patch [1] to delegate rounding of > bandwidth control user values to the arch code. As there is now more than one > architecture using resctrl, I split the original patch into two, a core resctrl > patch and an x86 patch, and added an MPAM patch. Please let me know if the patch > break down and ordering is sensible and whether the pattern should be followed > for any future similar changes. > > This does have a user visible effect on MB schema when using MPAM hardware > with 'bandwidth_gran' greater than 1. I'm not sure if MPAM hardware with such > coarse controls exists in the wild but it is spec compliant and I've tested it > on a model. > > [1] https://lore.kernel.org/lkml/20251031154225.14799-1-Dave.Martin@arm.com/ > > v3: https://lore.kernel.org/lkml/20260515140612.1205251-1-ben.horgan@arm.com/ > v4: https://lore.kernel.org/lkml/20260706160639.2136674-1-ben.horgan@arm.com/ > > Based on v7.2-rc2 > > Ben Horgan (1): > arm_mpam: resctrl: Add pass-through resctrl_arch_preconvert_bw() > > Dave Martin (2): > x86,fs/resctrl: Add resctrl_arch_preconvert_bw() > fs/resctrl: Factor MBA parse-time conversion to be per-arch > > Documentation/filesystems/resctrl.rst | 17 +++++++++-------- > arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 6 ++++++ > drivers/resctrl/mpam_resctrl.c | 5 +++++ > fs/resctrl/ctrlmondata.c | 6 +++--- > include/linux/resctrl.h | 19 +++++++++++++++++++ > 5 files changed, 42 insertions(+), 11 deletions(-) > Looks good in my tests on NVidia's grace-hopper machine. No errors found from the kunit-tests and the MBW limiting works with more precise granularity. The code changes look good to me either. Tested-by: Gavin Shan Reviewed-by: Gavin Shan Thanks, Gavin