From: Neil Armstrong <neil.armstrong@linaro.org>
To: Luca Weiss <luca@z3ntu.xyz>, linux-arm-msm@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: qcom-pma8084: fix vadc channel node names
Date: Mon, 26 Sep 2022 10:27:54 +0200 [thread overview]
Message-ID: <98960452-9f48-7b4d-9aa6-55c0002ad1b4@linaro.org> (raw)
In-Reply-To: <20220925202143.123208-1-luca@z3ntu.xyz>
On 25/09/2022 22:21, Luca Weiss wrote:
> Node names for the channel are supposed to be adc-chan@REG.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> arch/arm/boot/dts/qcom-pma8084.dtsi | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-pma8084.dtsi b/arch/arm/boot/dts/qcom-pma8084.dtsi
> index e77602e9f95c..7ad573c7b4ac 100644
> --- a/arch/arm/boot/dts/qcom-pma8084.dtsi
> +++ b/arch/arm/boot/dts/qcom-pma8084.dtsi
> @@ -64,22 +64,27 @@ pma8084_vadc: adc@3100 {
> #size-cells = <0>;
> #io-channel-cells = <1>;
>
> - die_temp {
> + adc-chan@8 {
> reg = <VADC_DIE_TEMP>;
> };
> - ref_625mv {
> +
> + adc-chan@9 {
> reg = <VADC_REF_625MV>;
> };
> - ref_1250v {
> +
> + adc-chan@10 {
> reg = <VADC_REF_1250MV>;
> };
> - ref_buf_625mv {
> +
> + adc-chan@12 {
> reg = <VADC_SPARE1>;
> };
> - ref_gnd {
> +
> + adc-chan@14 {
> reg = <VADC_GND_REF>;
> };
> - ref_vdd {
> +
> + adc-chan@15 {
> reg = <VADC_VDD_VADC>;
> };
> };
I don't see where this is required, bindings doesn't mandate this naming:
patternProperties:
"^.*@[0-9a-f]+$":
Neil
next prev parent reply other threads:[~2022-09-26 8:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 20:21 Luca Weiss
2022-09-26 8:27 ` Neil Armstrong [this message]
2022-09-26 14:57 ` Luca Weiss
2022-09-26 15:32 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98960452-9f48-7b4d-9aa6-55c0002ad1b4@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®