From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8014C2D0C82 for ; Tue, 30 Jun 2026 22:03:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782857041; cv=none; b=kINekRbDT9q66WcEFEwWySOcwrQ11rF6wkW8rUjwSbA9nUhs3k4cqf81flYBsl5lVGiGGnKUhpMzxTZVTaQjWCqW2VIqhJu5JIKHmMArtMIpkpMKCEmBD4rtYBYwXdqe1gXOc7avSMzcxKnUyg6ukIgFFuvJWAhdS1NI89tHoEw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782857041; c=relaxed/simple; bh=8ymipuRB9D5DQq6+y2O9ynj1qRZr8UbXvBj3NoQCjs0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tgrZno3KOLlaKRxEVMin+Ht1oDVz5DDZ3S/ReKeS3jOFrFyD9dGeYSPlq9H/M/EIFbSzIUjim8BQNe25Vb3RCgq0izMom79hf6iqZpNu2bVN+FB8Bc2pGSglmzEhosh+f/Bim3+WESr8lYRm5TuIJWSRqPOTIjNy7TDT6zGujcU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HFHkydXl; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HFHkydXl" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-493a7bd27c2so25660805e9.3 for ; Tue, 30 Jun 2026 15:03:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1782857037; x=1783461837; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tw2gpsI3jiI4P6kujg/K3R9aQhlaG+bVbRj+g5z/Ff4=; b=HFHkydXl9qNzDuK2ivnsAQd2h53E0oIA57kLA0rrCp747uvtzYeaf9cjaQnc/F3glZ ta0KhSbJKwXq5FoisQqw05UFsVizPp5hTwbk1YBuU95WQOj1gAxp9khcgRDmzQMtTyXY 1cUl7fD9mY9hSYmj1gQ7/YPYth8KxdNxaGf2GTHjXyTI9WOtyrgV/GZ46EQDBhrOh2E+ NXc8WZLNAQm4ly8FIv8HZ/5hwl8UF+g7IsLc0ZKsDM51ghSL89fD+2aPqJblSDZ81c5O DmpugiOO12AHfavcKcH6nFCMC732wtx8SFZ8XVtiRPlpG57KBqgoWUqkfRn5VhChvdRw R/wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782857037; x=1783461837; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tw2gpsI3jiI4P6kujg/K3R9aQhlaG+bVbRj+g5z/Ff4=; b=AGg1YWMXk6eAzW6NY45stR02rF/nqAhZ/49SZYSA01DHmiY//iIRxX+plnrpOPkUpf Y0r4upzAZ7Re3PSVqxBosFmTKvrXZQtjY/ZQrdcN4kft/Xgi18TRHQhWng3foxCdSmqy yyPPhhRD1ml8RwsOkanGFoWDXcLoKc5iBKIfG3DdIy0UfjMpb55VvE4gLssWnWfqDymz Jxo8mtLkSvao6/LjcP3lVlkCyxNdKELrqMZOxq24cfeoFl4nEw5SGNJFe5kQCdgXzlGL s/2eFtkNzBs2suYcF1x4arXOCSJEzMbeotflgKiyYfvbBM9H8uJdnha7coSE9Z8fTnSs bOgw== X-Forwarded-Encrypted: i=1; AFNElJ8pKv2HnJ8Cf09X3ja46ZB6vjO64LDEJmI1idFTr84UPEz1A+f21UOAUekdC45yXwixmD0zWPg3GDwnlz0=@vger.kernel.org X-Gm-Message-State: AOJu0YyzkcBamxrtvsi9cng+b7EpCUDTgU8pP6SNmm6L2mqYLB7atQ8U NTVGX9BnYM86gKUaxLv2dONt8XyhikCuFsLxw1UzrTuScqAMoyJ9Ocw8nYYwTQV87ec= X-Gm-Gg: AfdE7ckWFs9EfBRQvEe/qDV95/bi9CFyWB6bPg8C9/x6pIotO9NJUf9GH5VXshcJrKc 0x+NU7DQc/UqdPbp8KGfb6a/qHMmtdCfbcKoE4j4shDuqhNpr/+03ob3oakXu6R1UQRDwa4gIly YWvgNeoNIyH71VRlXfpZ2Zo/d7Rp2a8nWEpEkZ8ylAfO5AEZUcis1F+7ksdKxY28ZbA0ZTY+75F v+AjBOzHDPrynfx01fYGx0FKbmuPisJxE6c5RYqDmRo1LYfP9w3YlzO4deBmJQjDQXB22Dha5Bd HROS3ocVr/cF4uIgjwtRt758IJ/LVVA9sK2W0B8EDPhXcJADuSgqHTJKVlCP2qP86bxPQ5vRbyK gYTjAdReZtQRP+W5TWcn0UVAjTyC1Ons+bo6DCgaQVFv9XQnjPQj6QiG1C6axQvNAqbusovfhxA I/UCbzsbHRociTQrNXTtZQqsmeMg== X-Received: by 2002:a05:600c:6290:b0:492:40f2:4d78 with SMTP id 5b1f17b1804b1-493b827ee28mr76178765e9.2.1782857036849; Tue, 30 Jun 2026 15:03:56 -0700 (PDT) Received: from [192.168.0.101] ([109.76.103.114]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-475643cd85dsm10663533f8f.15.2026.06.30.15.03.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 15:03:56 -0700 (PDT) Message-ID: <9898d7cd-45fb-478d-affb-d3cf0e7df8b7@linaro.org> Date: Tue, 30 Jun 2026 23:03:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6] media: qcom: iris: use disable_irq() during power-off To: Hungyu Lin , linux-media@vger.kernel.org Cc: vikash.garodia@oss.qualcomm.com, abhinav.kumar@linux.dev, mchehab@kernel.org, konrad.dybcio@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260630152617.568-1-dennylin0707@gmail.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20260630152617.568-1-dennylin0707@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30/06/2026 16:26, Hungyu Lin wrote: > The IRQ is registered as a threaded IRQ. > > Using disable_irq_nosync() in iris_vpu_power_off() does not wait > for an already queued threaded IRQ handler to complete before > returning. > > As a result, a threaded IRQ handler may still run after the VPU has > been powered down and access hardware registers after power-off. > > Replace disable_irq_nosync() with disable_irq() so the power-off path > waits for any in-flight threaded IRQ handler to complete before > returning. > > Fixes: bb8a95aa038e ("media: iris: implement power management") > Cc: stable@vger.kernel.org > Suggested-by: Konrad Dybcio > Reviewed-by: Dmitry Baryshkov > Reviewed-by: Konrad Dybcio > Signed-off-by: Hungyu Lin > --- > drivers/media/platform/qcom/iris/iris_vpu_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.c b/drivers/media/platform/qcom/iris/iris_vpu_common.c > index 69e6126dc4d9..538659284c7b 100644 > --- a/drivers/media/platform/qcom/iris/iris_vpu_common.c > +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c > @@ -236,7 +236,7 @@ void iris_vpu_power_off(struct iris_core *core) > iris_unset_icc_bw(core); > > if (!iris_vpu_watchdog(core, core->intr_status)) > - disable_irq_nosync(core->irq); > + disable_irq(core->irq); > } > > int iris_vpu_power_on_controller(struct iris_core *core) > -- > 2.34.1 > > Reviewed-by: Bryan O'Donoghue --- bod