From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755599AbcH1PHq (ORCPT ); Sun, 28 Aug 2016 11:07:46 -0400 Received: from srv-hp10-72.netsons.net ([94.141.22.72]:32915 "EHLO srv-hp10.netsons.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752567AbcH1PHp (ORCPT ); Sun, 28 Aug 2016 11:07:45 -0400 Subject: Re: [PATCH 3/6] rtl8188eu: declare internal function as static To: Andy Shevchenko , devel@driverdev.osuosl.org References: <1472301649-18694-1-git-send-email-luca@lucaceresoli.net> <1472301649-18694-3-git-send-email-luca@lucaceresoli.net> <1472387282.4887.320.camel@linux.intel.com> Cc: Greg Kroah-Hartman , Bhaktipriya Shridhar , Geliang Tang , Jakub Sitnicki , Ivan Safonov , Kyle Kuffermann , linux-kernel@vger.kernel.org From: Luca Ceresoli Message-ID: <989d413c-9110-cb3a-e762-eb370e01d493@lucaceresoli.net> Date: Sun, 28 Aug 2016 17:07:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1472387282.4887.320.camel@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - srv-hp10.netsons.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: srv-hp10.netsons.net: authenticated_id: luca+lucaceresoli.net/only user confirmed/virtual account not confirmed X-Authenticated-Sender: srv-hp10.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Andy, thanks for your review. On 28/08/2016 14:28, Andy Shevchenko wrote: > On Sat, 2016-08-27 at 14:40 +0200, Luca Ceresoli wrote: > > Put here few words _why_ you are doing this. I'm doing it because this function is only used inside rtw_recv.c. Which is quite logical, since it's a timer callback: it is passed as the _fn argument to setup_timer(). Sorry for not having explained this in my original commit. I suppose now the best thing is to wait for a few days for more comments, then resubmit with these changes. Do you think it is? > Perhaps, add output of sparse static analyzer. sparse does not detect this issue, and I don't think it could. I found it by code inspection while working on other patches of this series. -- Luca