From: Yonghong Song <yhs@fb.com>
To: Matthieu Baerts <matthieu.baerts@tessares.net>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>
Cc: mptcp@lists.linux.dev, bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v2] bpf: Fix 'dubious one-bit signed bitfield' warnings
Date: Mon, 11 Jul 2022 08:47:50 -0700 [thread overview]
Message-ID: <989e1d04-788d-57c9-9e72-7552e6adc815@fb.com> (raw)
In-Reply-To: <20220711081200.2081262-1-matthieu.baerts@tessares.net>
On 7/11/22 1:12 AM, Matthieu Baerts wrote:
> Our CI[1] reported these warnings when using Sparse:
>
> $ touch net/mptcp/bpf.c
> $ make C=1 net/mptcp/bpf.o
> net/mptcp/bpf.c: note: in included file:
> include/linux/bpf_verifier.h:348:26: error: dubious one-bit signed bitfield
> include/linux/bpf_verifier.h:349:29: error: dubious one-bit signed bitfield
>
> Set them as 'unsigned' to avoid warnings.
>
> [1] https://github.com/multipath-tcp/mptcp_net-next/actions/runs/2643588487
>
> Fixes: 1ade23711971 ("bpf: Inline calls to bpf_loop when callback is known")
> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Acked-by: Yonghong Song <yhs@fb.com>
next prev parent reply other threads:[~2022-07-11 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 8:12 Matthieu Baerts
2022-07-11 15:47 ` Yonghong Song [this message]
2022-07-12 4:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=989e1d04-788d-57c9-9e72-7552e6adc815@fb.com \
--to=yhs@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®