mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Donnelly <John.P.Donnelly@Oracle.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: linux-kernel@vger.kernel.org, Lu Baolu <baolu.lu@linux.intel.com>
Subject: Re: [PATCH v3 ] iommu/vt-d: Fix panic after kexec -p for kdump
Date: Wed, 30 Oct 2019 08:01:51 -0500	[thread overview]
Message-ID: <98a3f2c3-e3a6-ffe2-6972-f6f901635e50@Oracle.com> (raw)
In-Reply-To: <20191030093313.GA7254@8bytes.org>

On 10/30/19 4:33 AM, Joerg Roedel wrote:
> Hi John,
> 
> On Mon, Oct 21, 2019 at 09:48:10PM -0500, John Donnelly wrote:
>> Fixes: 8af46c784ecfe ("iommu/vt-d: Implement is_attach_deferred iommu ops
>> entry")
>> Cc: stable@vger.kernel.org # v5.3+
>>
>> Signed-off-by: John Donnelly <john.p.donnelly@oracle.com>
>> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
>>
>>
>> ---
>>   drivers/iommu/intel-iommu.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
>> index c4e0e4a9ee9e..f83a9a302f8e 100644
>> --- a/drivers/iommu/intel-iommu.c
>> +++ b/drivers/iommu/intel-iommu.c
>> @@ -2783,7 +2783,7 @@ static int identity_mapping(struct device *dev)
>>   	struct device_domain_info *info;
>>
>>   	info = dev->archdata.iommu;
>> -	if (info && info != DUMMY_DEVICE_DOMAIN_INFO)
>> +	if (info && info != DUMMY_DEVICE_DOMAIN_INFO && info !=
>> DEFER_DEVICE_DOMAIN_INFO)
>>   		return (info->domain == si_domain);
>>
>>   	return 0;
> 
> I applied your patch for v5.4, but it needed manual fixup because your
> mailer screwed up the patch format by inserting line-breaks and
> converting tabs to spaces.
> 
> Please consider to setup and use 'git send-email' for your next patches.
> This will get it all right and makes life easier for maintainers that
> want to apply your patches.
> 
> Thanks,
> 
> 	Joerg
> 
Thank you .

I tried using the git mailer from my development server but 
vger.kernel.org mailer rejected it because the generated email did not 
match the subscription email and was rejected.





-- 
Thank You,
John

      reply	other threads:[~2019-10-30 13:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-22  2:48 John Donnelly
2019-10-30  9:33 ` Joerg Roedel
2019-10-30 13:01   ` John Donnelly [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98a3f2c3-e3a6-ffe2-6972-f6f901635e50@Oracle.com \
    --to=john.p.donnelly@oracle.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®