From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC97E204F93; Tue, 24 Feb 2026 00:19:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771892399; cv=none; b=PT4cxDU0Wk1WlXdC4ZOlFX9eGhzdw7BECZuLHk3CJfhlnCSrqVcjpqS4ErROC3Zh2qyQ1VhE0O+mFhTIePxkKDnrRERkpITbQ+d7h/bbaop8P6lozSOUlzpn2a/x742YmuKFsqSiBUC+Eu5Ulb+nxmOjlOwHS5hqUz9P+kfViBg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771892399; c=relaxed/simple; bh=dciRGoN7WFLoFqpHkJ0YEkum8LTzaOwjLNnQ7VOOkfU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=onPkQNc97GR2wfx5RGXpjQRuuqXh4BTV0W7soGTOKAPPqXEhE3CfztH3B4gnwNf9uJoYKyH1S/fwX0z0aE2yaCfiyknksCEI4zNM60LlQ6UxM8gFug3I72etUPovCulcsqQD1meOy1JndB8ULUgAvPgtf4UHYFzD7to8pmjJAHg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=j2D3bokk; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="j2D3bokk" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=GHaSrimv6EXgmCgAuKFl87ZenTVFS/f/vOi6bxFR7ZE=; b=j2D3bokk5i9uu70gM1qaSvgjQf PwdUFU4jYX3ZRyGT0KV3T15FoSy+02Gj3pSMUHbawLY047VRD4lbY50wXw+FXywXZIENQ9/92PlqF PJDLkYVcHlDsEnB4dYWTI2hzcSbrNxvXD8cpd08Hxl2k1hA0X8RUtTgw0P3DXC9WspUs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1vug8z-008WuR-Om; Tue, 24 Feb 2026 01:19:17 +0100 Date: Tue, 24 Feb 2026 01:19:17 +0100 From: Andrew Lunn To: Bart Van Assche Cc: Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , linux-kernel@vger.kernel.org, Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , Bart Van Assche , Daniel Golle , Jakub Kicinski , Xu Liang , netdev@vger.kernel.org Subject: Re: [PATCH 23/62] net: phy: mxl-86110: Fix locking in an error path Message-ID: <98a65068-a1c2-4292-bde9-61efcee53df4@lunn.ch> References: <20260223220102.2158611-1-bart.vanassche@linux.dev> <20260223220102.2158611-24-bart.vanassche@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260223220102.2158611-24-bart.vanassche@linux.dev> On Mon, Feb 23, 2026 at 02:00:23PM -0800, Bart Van Assche wrote: > From: Bart Van Assche > > Only call phy_unlock_mdio_bus() if phy_lock_mdio_bus() has been called > first. This has been detected by the Clang thread-safety analyzer. > > Cc: Daniel Golle > Cc: Andrew Lunn > Cc: Jakub Kicinski > Cc: Xu Liang > Cc: netdev@vger.kernel.org > Fixes: 3d1b3f4ffc0a ("net: phy: mxl-86110: add basic support for MxL86111 PHY") > Signed-off-by: Bart Van Assche Reviewed-by: Andrew Lunn Andrew