From: Jens Axboe <axboe@kernel.dk>
To: Kaitao Cheng <pilgrimtao@gmail.com>
Cc: damien.lemoal@wdc.com, bvanassche@acm.org, ming.lei@redhat.com,
martin.petersen@oracle.com, satyat@google.com,
chaitanya.kulkarni@wdc.com, houtao1@huawei.com,
asml.silence@gmail.com, ajay.joshi@wdc.com,
linux-kernel@vger.kernel.org, songmuchun@bytedance.com
Subject: Re: [PATCH] linux/blkdev.h: Use ilog2() directly in blksize_bits()
Date: Sat, 23 May 2020 11:07:32 -0600 [thread overview]
Message-ID: <98a69358-9976-e0e6-9cc6-f9c4676d8f3f@kernel.dk> (raw)
In-Reply-To: <20200523155048.29369-1-pilgrimtao@gmail.com>
On 5/23/20 9:50 AM, Kaitao Cheng wrote:
> blksize_bits() can be achieved through ilog2(), and ilog2() is
> more efficient.
I like the simplification, but do you have any results to back up
that claim? Is the generated code shorter? Runs faster?
--
Jens Axboe
next prev parent reply other threads:[~2020-05-23 17:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-23 15:50 Kaitao Cheng
2020-05-23 17:07 ` Jens Axboe [this message]
2020-05-23 18:33 ` Bart Van Assche
2020-05-23 18:50 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98a69358-9976-e0e6-9cc6-f9c4676d8f3f@kernel.dk \
--to=axboe@kernel.dk \
--cc=ajay.joshi@wdc.com \
--cc=asml.silence@gmail.com \
--cc=bvanassche@acm.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=damien.lemoal@wdc.com \
--cc=houtao1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=pilgrimtao@gmail.com \
--cc=satyat@google.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®