mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Gow <david@davidgow.net>
To: "Alexandre Courbot" <acourbot@nvidia.com>,
	"Brendan Higgins" <brendan.higgins@linux.dev>,
	"David Gow" <davidgow@google.com>,
	"Rae Moar" <raemoar63@gmail.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Shuah Khan" <skhan@linuxfoundation.org>
Cc: linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] rust: kunit: fix warning when !CONFIG_PRINTK
Date: Tue, 24 Feb 2026 21:56:17 +0800	[thread overview]
Message-ID: <98a8f99b-35c1-4de3-ae06-e5c1ac8c0adf@davidgow.net> (raw)
In-Reply-To: <20260224-unused_var_err-v2-1-337f9359d98e@nvidia.com>

Le 24/02/2026 à 6:37 PM, 'Alexandre Courbot' via KUnit Development a écrit :
> If `CONFIG_PRINTK` is not set, then the following warnings are issued
> during build:
> 
>    warning: unused variable: `args`
>      --> ../rust/kernel/kunit.rs:16:12
>      |
>    16 | pub fn err(args: fmt::Arguments<'_>) {
>      |            ^^^^ help: if this is intentional, prefix it with an underscore: `_args`
>      |
>      = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
> 
>    warning: unused variable: `args`
>      --> ../rust/kernel/kunit.rs:32:13
>      |
>    32 | pub fn info(args: fmt::Arguments<'_>) {
>      |             ^^^^ help: if this is intentional, prefix it with an underscore: `_args`
> 
> Fix this by adding a no-op assignment using `args` when `CONFIG_PRINTK`
> is not set.
> 
> Fixes: a66d733da801 ("rust: support running Rust documentation tests as KUnit ones")
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
> Changes in v2:
> - Use a no-op assignment instead of the wider `#[allow(unused_variables)]`.
> - Link to v1: https://patch.msgid.link/20260224-unused_var_err-v1-1-c51d805eceb5@nvidia.com
> ---

Reviewed-by: David Gow <david@davidgow.net>

Cheers,
-- David

  parent reply	other threads:[~2026-02-24 13:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Qrs5fItWst004EC_jGHvnTB2s8QuVM9cnRKIhUuImhaSV8qhL9DmqifhAqLFPSEf1JYNS9J-1hWqvptIARahvQ==@protonmail.internalid>
2026-02-24 10:37 ` Alexandre Courbot
2026-02-24 11:44   ` Alice Ryhl
2026-02-24 11:51   ` Andreas Hindborg
2026-02-24 13:07     ` Alexandre Courbot
2026-02-24 13:15       ` Alice Ryhl
2026-02-24 13:56       ` David Gow
2026-02-24 14:23         ` Alexandre Courbot
2026-02-24 13:56   ` David Gow [this message]
2026-03-04  2:34   ` Miguel Ojeda
2026-03-04  9:16     ` David Gow
2026-03-04 12:07       ` Miguel Ojeda
2026-03-05 23:55         ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98a8f99b-35c1-4de3-ae06-e5c1ac8c0adf@davidgow.net \
    --to=david@davidgow.net \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=brendan.higgins@linux.dev \
    --cc=dakr@kernel.org \
    --cc=davidgow@google.com \
    --cc=gary@garyguo.net \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=raemoar63@gmail.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®