From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: Hans de Goede <hdegoede@redhat.com>, <wsa@kernel.org>,
<jarkko.nikula@linux.intel.com>,
<andriy.shevchenko@linux.intel.com>,
<mika.westerberg@linux.intel.com>, <jsd@semihalf.com>
Cc: <linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<patches@opensource.cirrus.com>
Subject: Re: [PATCH] i2c: designware: Fix unbalanced suspended flag
Date: Fri, 9 Dec 2022 13:40:06 +0000 [thread overview]
Message-ID: <98a9b991-634c-f64e-d1c2-9cf92f5fe89f@opensource.cirrus.com> (raw)
In-Reply-To: <e9d113fb-5cd1-d93d-3d8f-fa9c1e55a8e2@redhat.com>
On 9/12/22 12:15, Hans de Goede wrote:
> Hi Richard,
>
> On 12/9/22 12:40, Richard Fitzgerald wrote:
>> Ensure that i2c_mark_adapter_suspended() is always balanced by a call to
>> i2c_mark_adapter_resumed().
>>
> I'm afraid that this is always going to run now, before this callback gets
> called drivers/base/power/main.c: device_resume_noirq() does:
>
Ok, what do you suggest as the fix?
If you post an alternate fix I can test it.
next prev parent reply other threads:[~2022-12-09 13:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 11:40 Richard Fitzgerald
2022-12-09 12:15 ` Hans de Goede
2022-12-09 12:29 ` Richard Fitzgerald
2022-12-09 13:36 ` Richard Fitzgerald
2022-12-09 14:22 ` Richard Fitzgerald
2022-12-09 18:16 ` Hans de Goede
2022-12-09 13:40 ` Richard Fitzgerald [this message]
2022-12-09 14:04 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98a9b991-634c-f64e-d1c2-9cf92f5fe89f@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=patches@opensource.cirrus.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®