From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Mans Rullgard <mans@mansr.com>,
Andrew Morton <akpm@linux-foundation.org>,
Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH v4 1/2] kernel.h: Update comment about simple_strto<foo>() functions
Date: Thu, 01 Aug 2019 12:58:08 -0700 [thread overview]
Message-ID: <98acdfce0da0d7c3b33571528064935c107cbbc5.camel@perches.com> (raw)
In-Reply-To: <20190801192904.41087-1-andriy.shevchenko@linux.intel.com>
On Thu, 2019-08-01 at 22:29 +0300, Andy Shevchenko wrote:
> There were discussions in the past about use cases for
> simple_strto<foo>() functions and, in some rare cases,
> they have a benefit over kstrto<foo>() ones.
[]
> diff --git a/include/linux/kernel.h b/include/linux/kernel.h
[]
> @@ -334,8 +334,7 @@ int __must_check kstrtoll(const char *s, unsigned int base, long long *res);
> * @res: Where to write the result of the conversion on success.
> *
> * Returns 0 on success, -ERANGE on overflow and -EINVAL on parsing error.
> - * Used as a replacement for the obsolete simple_strtoull. Return code must
> - * be checked.
> + * Used as a replacement for the simple_strtoull. Return code must be checked.
Using 'the' here is unnecessary and somewhat confusing.
Perhaps:
* Preferred over simple_strtoull() unless the end position is required
* Return value must be checked
>
next prev parent reply other threads:[~2019-08-01 19:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 19:29 Andy Shevchenko
2019-08-01 19:29 ` [PATCH v4 2/2] auxdisplay: charlcd: Deduplicate simple_strtoul() Andy Shevchenko
2019-08-01 19:50 ` [PATCH v4 1/2] kernel.h: Update comment about simple_strto<foo>() functions Miguel Ojeda
2019-08-26 13:43 ` Andy Shevchenko
2019-11-08 12:59 ` Andy Shevchenko
2019-08-01 19:58 ` Joe Perches [this message]
2019-08-02 7:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98acdfce0da0d7c3b33571528064935c107cbbc5.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®