From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755417AbcIRA76 (ORCPT ); Sat, 17 Sep 2016 20:59:58 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:49450 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754857AbcIRA7t (ORCPT ); Sat, 17 Sep 2016 20:59:49 -0400 Subject: Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift gpio_mxc_init() to subsys_initcall level' To: Shawn Guo , Vladimir Zapolskiy References: <9befb559-499a-dd70-cd44-60d5fce2e5d6@roeck-us.net> <99993063-6692-0870-12fa-64cf13d507f6@mentor.com> <20160918000845.GA15478@tiger> Cc: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Linus Walleij From: Guenter Roeck Message-ID: <98b08cff-c61e-71f4-056c-496602fbcad7@roeck-us.net> Date: Sat, 17 Sep 2016 17:59:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160918000845.GA15478@tiger> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/17/2016 05:08 PM, Shawn Guo wrote: > Hi Guenter, > > On Thu, Sep 15, 2016 at 04:35:04PM +0300, Vladimir Zapolskiy wrote: >> The proper fix in this particular case should be like this one: >> > > Does Vladimir's patch below fix your problem? > Yes, it does. Feel free to add Tested-by: Guenter Roeck to an official patch. Guenter > Shawn > >> diff --git a/arch/arm/mach-imx/mach-kzm_arm11_01.c b/arch/arm/mach-imx/mach-kzm_arm11_01.c >> index 31df4361996f..8288acfe7221 100644 >> --- a/arch/arm/mach-imx/mach-kzm_arm11_01.c >> +++ b/arch/arm/mach-imx/mach-kzm_arm11_01.c >> @@ -245,13 +245,17 @@ static void __init kzm_board_init(void) >> mxc_iomux_setup_multiple_pins(kzm_pins, >> ARRAY_SIZE(kzm_pins), "kzm"); >> - kzm_init_ext_uart(); >> - kzm_init_smsc9118(); >> kzm_init_imx_uart(); >> pr_info("Clock input source is 26MHz\n"); >> } >> +static void __init kzm_late_init(void) >> +{ >> + kzm_init_ext_uart(); >> + kzm_init_smsc9118(); >> +} >> + >> /* >> * This structure defines static mappings for the kzm-arm11-01 board. >> */ >> @@ -291,5 +295,6 @@ MACHINE_START(KZM_ARM11_01, "Kyoto Microcomputer Co., Ltd. KZM-ARM11-01") >> .init_irq = mx31_init_irq, >> .init_time = kzm_timer_init, >> .init_machine = kzm_board_init, >> + .init_late = kzm_late_init, >> .restart = mxc_restart, >> MACHINE_END >> -- >