From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012047.outbound.protection.outlook.com [40.107.209.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7280F2FF661 for ; Fri, 30 Jan 2026 22:00:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.47 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769810448; cv=fail; b=k9Y1Pg9oyLZDfS+ZctoflTCIrjXMpcE06g59YwNA9ThNWcjS4kZmcxO8+2m+6HYXOkjtUvZbl8jRyqCj2dbpGyFx/ngR1LCZPLX9l74cKi5Q/ATJDOKNJm6i8DggOuotsASlCKDKyfsImCGGd7B3OZBE6f5YJ7ZnnQKwO96frTk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769810448; c=relaxed/simple; bh=vj0Wo+tqgqHvyLw/MtWT+p3ljLte5gKQvtKfIOZeLtM=; h=Content-Type:Message-ID:Date:Cc:Subject:To:References:From: In-Reply-To:MIME-Version; b=fp5D54WejCb/BEknGogV9NEQwESVX6uBcoDPDbrQHNCeNMKdj2foD+fKHEkwCvECNPMonrKo7nO4oy0wSVI95pvx9bONgo4gYYDxYnPtKXI0d1Z11WK3tWcJf1/l4cDYYmuFYe4exrgrjyKn4jTXtAX+WHYg9DHdWzf2Bs0gCl4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=citrix.com; spf=pass smtp.mailfrom=citrix.com; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b=XtxyNlvK; arc=fail smtp.client-ip=40.107.209.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=citrix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=citrix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="XtxyNlvK" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ynUprqwHg1HAzxKSh3MgLVeSsxdU4VGogKlyFrm6DG5Rzq9fwZ+JOhT/SXi0ciYge9hjEPJg9rsZ9IFlqwWdLBgai/gMn70B+CbtXaJBxp8YFNI97Ghf1UNUuzKih1W4pEomsZMwkjOOzphC0xb1g0xuLK7uGXzPU6QeK8yL9EFniHNXaLBwerW+K1M5/+lsqAnwEvRB17dQir4apYhrKkA9gm99B/6KQYsu8IiIC0iZufYmLvABdWK66yADP8pj3nBlCDQCvFqSIG72oFkg+oraSt5zDbDoexCVM282aiCpYYKG7eaBZEwTLHcGQWjtHrq7hq2kfRrnfUmAs6CoWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LSZ59TakiPekmmWCKX7Jb1kGSFP+Ii6DAN+USbd+48k=; b=MzgKtj2c+xt5sMabHG5I/th33IOwXR1eOg2zXzm0NzCdQfSwH52NASamsAi+Tr0xPJ1Wj/huLaWDajyEhqkMn+HE6yZoDDgS5rtpX8ZMjvdzYmi7IknR8I9CVqSyGOLuI+pKU0u2MoZq1BZ5Es5AR96nfp/6m2vkkK2MIp5jYcU7sjVMiKdhMRxq3X67c4x9kXEm7Awj4RpznIKRYJsWL6wa45spbdidJFq8nOBSlL3wCgAp2ToVIU8r0SAICCBmFKfv/tcJ086GcECIkibCESUZGSSYRQfxm7hHwld1Dhb7BdpDJ5+lLpXDLUWAnWJnSGdVRDwaiPy0gOirg62kGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LSZ59TakiPekmmWCKX7Jb1kGSFP+Ii6DAN+USbd+48k=; b=XtxyNlvKDbNezc78fsakOK588krYJaImRW/FG+U29VcM8gDU+RRjKJxGE63mHx5ZeUTC4XWHZs23xtS3HTMZYFgeMJ5zZpU3VXRplC/2w748JBhZIFhKffgVqjNsZravqwaPx1UghlIxF1XuQOE120ifWNBrN5OEuPfXgLStt8Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by CH8PR03MB8225.namprd03.prod.outlook.com (2603:10b6:610:2c3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.11; Fri, 30 Jan 2026 22:00:43 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%6]) with mapi id 15.20.9564.008; Fri, 30 Jan 2026 22:00:43 +0000 Content-Type: multipart/mixed; boundary="------------ixUTIDLRlF0rtsRgHrfU8HWq" Message-ID: <98b13199-f427-4054-8f37-15b2219c1fa3@citrix.com> Date: Fri, 30 Jan 2026 22:00:38 +0000 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Peter Zijlstra , Josh Poimboeuf , Pawan Gupta , Dave Hansen , Nikolay Borisov , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] scripts/x86/intel: Add a script to update the old microcode list To: Sohil Mehta , Dave Hansen , Borislav Petkov , x86@kernel.org References: <20260130194753.672739-1-sohil.mehta@intel.com> Content-Language: en-GB From: Andrew Cooper In-Reply-To: <20260130194753.672739-1-sohil.mehta@intel.com> X-ClientProxiedBy: LO4P265CA0176.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::16) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|CH8PR03MB8225:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ef9bea9-6bd6-4c5a-9435-08de604b0368 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|6049299003|376014|1800799024|7416014|4053099003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QkNhRzBsWFhiZjQvcWJKYTNmK3hNTm9vUitKeW9WOEIzeFhjNFcwWHZ0eTdj?= =?utf-8?B?aVJsOTVVM1Vrd3FkZlpIRkpRbnhWYy92eU9qV0hqVWUxYVdIUWR5ejNBbTgw?= =?utf-8?B?cGEwS1Jkc2tlb08vSThIVktReERvTGYzM3RBK09WUWVyQXdEdktFSU5PTnhH?= =?utf-8?B?a2hhYVNUK1ZEaUFXTGVSTVM4RDQzNlJ3S0l1eG1vaW1zRFE0bFFYcDJNc3JJ?= =?utf-8?B?dlV6aUZwazhlcEhHQnJSeE1wbDFteTFBNlBGZUhXdVZXRXdHWVgwOUxBVjE1?= =?utf-8?B?VUF4OFZmMWVlV0x6V0V3dURYOTNGOTNIR0VsTE0yam9kYVBLOTB2bDl4cVR3?= =?utf-8?B?WXQ4Q0lKNXhlWEJ1bGhTUE43ajFnK3B4dGNSWnhsbGFOZFJwWmM3azVZa1Bl?= =?utf-8?B?VEhvYlE0L0MrQ1JtY3YxNGxRYjlXUHg3UGFvd0EvL01aNERWa2pTMklqY3No?= =?utf-8?B?eWU5bVF1YjBNQmJ5eTljYSt4NGVaSTlZN05tbGlybnh3MGloUHVKWGdSaGN1?= =?utf-8?B?WXBDWnlUNkNodUdWZnhtbk1BcVBlemQ3VVhmV1M2WVUrUVNQUE15Z2RHMHA1?= =?utf-8?B?eE1vdXdma2t6anFWdVdCMDJaNEJKWElwcVdtcmdQelRiTFo0L2k2Y21NVmtn?= =?utf-8?B?THVNS2NkS0tmYVJUb1NzT2kydnNhWUlzVmhVdU5YbCtncWlnMXdZZUJkTk1Z?= =?utf-8?B?ajdXM2s1blR0Sy9tVTRhMjkxM1RGK2ZWSGErQlZ4MHJXYVoxaEh3eVR0MG91?= =?utf-8?B?aFhSNFBNbHo5MWtBTkdzKzd0QkNCRnFOd1FuT1ZUNUhxb0c0ZUxwbDgwamlU?= =?utf-8?B?bytUWlFxMmVyQTlid0tOMFNvTm5HZlhyWjdDZ29HUlNYdHFQVVlhYW1xdFcw?= =?utf-8?B?c1Bma2VnNkRENFlhcmRRUXNQTHU0bE12ZDRFN1NXRm1xekh2TFdONWFYbzZn?= =?utf-8?B?V3d3aVFhc3FVZU12dlV2OVRaYmVuWnpPQitFdGxMbndUaUF4YXh0eW1uS1RH?= =?utf-8?B?WnA3Rkl6c3hrQUN4SnpQV0VESEVaSDUvQURSRGpLSjYrYTZXclU5VHQ2UDJL?= =?utf-8?B?bjNUNjVPRjhWaEp2WkRQREtuTXpNN3JNSjdEODRPR0NBZmxHRGxCVitrM2VN?= =?utf-8?B?ME5GVERkVVZIOE1nZmdsUlNwY2tkUENsZmdKOGg1UUZkaFdCcXB0dkNQMGtN?= =?utf-8?B?aHNtc256WnZxd0ljSGQwSXhyMTdFVTk2SzdxajIwM2ErVlYvQUxsNTFReW93?= =?utf-8?B?Y3diVzhNbjBpZk55Y0VyM1VrR1R1SElITDJjMkxQUk5uc2JtOWMyQUNkSG5a?= =?utf-8?B?N01DRjBvYlhFUHdENXB1dERVcEF1alc5dEJKWE1pbElkTFdXQXZPeDQ0QlQz?= =?utf-8?B?WlZTZ3prUU16Z1pvMnJsTVFiMUVpNjNiclZLZFpvWkw3VE1va3FrZW53ZjIx?= =?utf-8?B?MG9TOWJjSVVsL1pIYWFqVUc4dGt1c3ZsMFBqdDlzT0RCL1U4TW52ZGpXY0FL?= =?utf-8?B?c2xDMEYxWkIvUm1DRnk1L0tMT2UvVFZ2TGhwM3ZsV1FnTDF2YWJWUU4rUW1Q?= =?utf-8?B?NW9xNFNQY3lNRExWTFZnL1BwUjFyMjZaQWV1YjRrRmthOGJpZWM0OWNQVzZj?= =?utf-8?B?M0FJZ21YYU5nNjd1U0hYSlVVeERmTE1jZU5iL2M0V21LVFFYMHNiMC8ySUJQ?= =?utf-8?B?a2VRTTFWcDMyK2FQamcyM1pFWEczUjlOa21CMVgvU3ozZFEwOTBIa1N2MStW?= =?utf-8?B?dGVZNmlaWFJ5NmJER3NzcHJkaUtYTk9WdkJjL1BkMWYrOG5qQmZ2SFJYMjRV?= =?utf-8?B?NjV2N2NBck5KdFQycWtlYUlIUGNSeGhTSXVDQ1NnWlBCSkxvWC9wVm50Mm8y?= =?utf-8?B?M0p2K1RvdG5uTnYyU1hkblpLQjJvc05ISnl4T2NNSDhoMVUwcXNXREExNktC?= =?utf-8?B?WDBYMGN1cDN4NUxHTEc5TS93QlNwNVlmaVg3SlNCdVVMempKRzJIT2RSckV1?= =?utf-8?B?S205WXEzTktBdnRscHpMZmdkYkZoclN3cXF0bWo0ODRjSll1VlhNRjR6TTRO?= =?utf-8?B?clJXL1hrWGVnYWFnc3ZFVDFMT2F1UCtDTjVDcENkZmwzVm9oZVZPRTBRbjkz?= =?utf-8?Q?1N24MCfxMUmZ5h/+I88nrqM2m?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(6049299003)(376014)(1800799024)(7416014)(4053099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXRMZTFFNmk2WEh6bkZ2eHRZOTlYUnBpQVZFWEN3aFNWeHVRTkg2QmxqSXZW?= =?utf-8?B?V2hqRnVVNDYxRC9UUk1LWEhVemZEZXBnUGdUSGVzZUdXSmx4SW5iSGZMc09m?= =?utf-8?B?dTMxQUZWejcyZXFuVnk5d2lhbkVMR0xicFNWK3FxT1NhbWUvNHl1akpiTEJM?= =?utf-8?B?Zzd3UkhVTkl6Q1NmM1lhc0RneXBxTXdkWFhleGJSVXF2OHdiOWdPQ2poZVMr?= =?utf-8?B?aUZsZzJCazA4UG5yQ1dwclQ4d0F1WFpCK2hRK1lEc1UybzVacitCWUN2OGxv?= =?utf-8?B?elZoZWxyblNxbDN0bXB2RG5JZ25jN2xFdGRpNkxrc3QvMXdja2lNT2tqRytY?= =?utf-8?B?Sld1aFJiaStnVStkemVKWHozVjl2aHh3UURRQmhveHFnNXgrRHJwOEFxcHJt?= =?utf-8?B?Qy9takxXSWhpZXRlbWY0STg2R1llNDZ3ekVQYThleSt6WFE1eVp2R3orQ1o3?= =?utf-8?B?VkVHOXg3REpncmFSYXZ1RUNlWGdqZXRVdFdMU2J6ZW9xYkdaZ3VmZVNwT0xw?= =?utf-8?B?amhIOW5IK0E0cEtuQlhiZ3JLTWo1UW1lOUxnUHFrWG9TUnJ3ck1zNHdaRkRB?= =?utf-8?B?OHQyZDN6NkdrdW5Td05HMGpxOTU5azZZZmJuaFJ3UWN6dzV3SE5Bbk1tOGxF?= =?utf-8?B?bDFLNDZzcUdsWWxTcHlIelkrUjJHbmV2VlRpU1ovdzdjZ2NLL3dsek90QzFH?= =?utf-8?B?YVptLy9sSXIrdzMxUDdtTXltL2QrY1IzQWEyYk5DbXlyanlCenc4ZnJyeFU1?= =?utf-8?B?VnlWMDdObUQrMVM1TlgxVHpnejlvRVN1KzdkaFEwSXdteTZaTkFZZXo2MG05?= =?utf-8?B?WUtxMFNHZmJ1am5jRnB5VzZPZkVBOGtCeUlsNTc3YmdSQTFsaWRqMERQT2pu?= =?utf-8?B?Vml5WlgycFZ4Y3U1S29xVEJmTi9QOHIxTFVWcUgwdEpUeUxXaVhGTkNkSENX?= =?utf-8?B?YmdHTGFGeFpuV3lydStrQUxLenFSYzZBMmErTG1KbkZML1daTGxJQUtSdCtu?= =?utf-8?B?bkJ4elpMM0VtY1NjY09qY0JwcFBCMDdwT2xuUHNiTGlWakZYdzFKdFpTMXRJ?= =?utf-8?B?bllsSTZ1YUV4MnA3S2RTd3U1SmNxSXpnSzRQT1c5dXNJdEZJbkF6SmlUVlFz?= =?utf-8?B?aHBReGozUHBkcW1SNUNtOWFzdkpmSDlzQTB2elpSYUxRZ3czM0lHbXliYXVu?= =?utf-8?B?RVgrbG1vZHR6SlRsaDhTeEJqQkJSemgzeFVGRmVqRi95NGRubkRQRzJRcCt4?= =?utf-8?B?QStzNmMvUVVXR1JjVno2QlNXaUhMdnprYmJLZ3NZdU9TVUVOR1ZyVUlXaWtU?= =?utf-8?B?NUs0cUhxZjl0VEtobXBZNTBvOGw4cWFkTWNrRERlUlFMY0Q3YnZiM0FmL01v?= =?utf-8?B?UFBDZWJjZWhnNGp6QkNSSW1lZ3lTOWtWcTRmT3FXcWlocGkzNjQzS1FlNXFk?= =?utf-8?B?d2k2Y3M0bGNqdjRxODRSSStTcUdIS1lDTW5OQkJQRkpJOW5LOEtnOHhYZ0N2?= =?utf-8?B?ZzBaRGswd2RSTWNLTUVobEIveFVycU9NTHNramNzdG5lcTJhRTk4L2lrVDV3?= =?utf-8?B?bDlnblJlWWpYdGNzYURqbFpiZGlOWThadnhjZ05PQ2lpVW5zeHg5Z05NTXho?= =?utf-8?B?U2R2eFFkSlB4cTVFSWxvemcyeVcxTUpvMjd2Vy94TmphSGZNazRoWTVHdmNp?= =?utf-8?B?NkNBenhRL1lDRzlncVA4M3NnU1pZWERna3BTYURmS3dGZ1VkaTRSQmYzYk5W?= =?utf-8?B?azIyOFNjWmN0Umh5enV4RWR6OXZHcElhYW5xRjk1bTR5RjFRamNLZ0YxR3By?= =?utf-8?B?dFcxWHVJVE9NUmZrcmpISHovVGN4L010TTNkanZReXdzK0poSnR3Ym1HVk5i?= =?utf-8?B?Wnl0NHVRbEhxL1pjZGk0czhGVXlQWGJlZ0gwNXR4ZXNjK201c1lSS2Vpdmda?= =?utf-8?B?Z3VWamUrVlJYOFpaa3oveHZDUFM2RGwyTDVMMUJWdktoYW5GNHg1ZlF4U3Fs?= =?utf-8?B?cE1JTUZMeXZhVHFiOGh3ODRTUjdCNjdzQTZ0NUdQaitsUW1YelpObG55aEI2?= =?utf-8?B?Y3JISFpGRlZTT1gyWlNYRFUvT1NiNWd5N2hzc2VwbHlGUzFqMTBoSlB2Q1NJ?= =?utf-8?B?RzRxR0dDKzdEdHNIWC9nUjlNUUxQVERaS2hmQm8vVGpJTjM5bjV0SDBzVHVT?= =?utf-8?B?SWVSamFIMUFMNkgvWFh5aFJuQXJiaFRkUjlvNmdJQmZVV1R2ZUQwNjhuL0JP?= =?utf-8?B?QjVuTy9aODY1UEFuRmg0c3hmUDg5aXlMVWNJbVprZ0VEY3pQbk5kem9rTmR0?= =?utf-8?B?emFUUkdwUVliRjUvaS90Z0tEOWZVQ1krdndBYVNWK1M2NTZBOFZMZz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ef9bea9-6bd6-4c5a-9435-08de604b0368 X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2026 22:00:42.9925 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dTAghPp0QhbMA8V/OpVWHqfq+lVV1Szk5Oa32muqc4l/qRUGjd8Tpw8lfhKU+sYO8gVA0y4yZCk0gm4uXAuPQsioRxC2s8CPpJzWWwHN95E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH8PR03MB8225 --------------ixUTIDLRlF0rtsRgHrfU8HWq Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 30/01/2026 7:47 pm, Sohil Mehta wrote: > diff --git a/scripts/update-intel-ucode-defs.py b/scripts/update-intel-ucode-defs.py > new file mode 100755 > index 000000000000..50ec47cea1c5 > --- /dev/null > +++ b/scripts/update-intel-ucode-defs.py > @@ -0,0 +1,128 @@ > +#!/usr/bin/python3 > +# SPDX-License-Identifier: GPL-2.0 > +import argparse > +import re > +import shutil > +import subprocess > +import sys > +import os > + > +script = os.path.relpath(__file__) > + > +DESCRIPTION = f""" > +For Intel CPUs, update the microcode revisions that determine > +X86_BUG_OLD_MICROCODE. > + > +This script is intended to be run in response to releases of the > +official Intel microcode GitHub repository: > +https://github.com/intel/Intel-Linux-Processor-Microcode-Data-Files.git > + > +It takes the Intel microcode files as input and uses iucode-tool to > +extract the revision information. It prints the output in the format > +expected by intel-ucode-defs.h. > + > +Usage: > + ./{script} /path/to/microcode/files > /path/to/intel-ucode-defs.h > + > +Typically, someone at Intel would see a new public release, wait for at > +least three months to ensure the update is stable, run this script to > +refresh the intel-ucode-defs.h file, and send a patch upstream to update > +the mainline and stable versions. > + > +As always, there can be exceptions to the above process which should be > +supported by appropriate justification. > +""" > + > +parser = argparse.ArgumentParser(description=DESCRIPTION, > + formatter_class=argparse.RawDescriptionHelpFormatter) > +parser.add_argument('ucode_files', nargs='+', help='Path(s) to the microcode files') > + > +args = parser.parse_args() > + > +# Process the microcode files using iucode-tool > +if shutil.which("iucode-tool") is None: > + print("Error: iucode-tool not found, please install it", file=sys.stderr) > + sys.exit(1) > + > +cmd = ['iucode-tool', '--list-all' ] > +cmd.extend(args.ucode_files) > + > +process = subprocess.Popen(cmd, stdout=subprocess.PIPE, universal_newlines=True) > +process.wait() > +if process.returncode != 0: > + print("Error: iucode-tool ran into an error, exiting", file=sys.stderr) > + sys.exit(1) > + > +# Functions to extract family, model, and stepping > +def bits(val, bottom, top): > + mask = (1 << (top + 1 - bottom)) - 1 > + mask = mask << bottom > + return (val & mask) >> bottom return (val >> bottom) & mask > + > +def family(sig): > + if bits(sig, 8, 11) == 0xf: > + return bits(sig, 8, 11) + bits(sig, 20, 27) > + return bits(sig, 8, 11) > + > +def model(sig): > + return bits(sig, 4, 7) | (bits(sig, 16, 19) << 4) > + > +def step(sig): > + return bits(sig, 0, 3) > + > +# Parse the output of iucode-tool > +ucode_list = [] > +for line in process.stdout: > + if line.find(" sig ") == -1: > + continue > + sig = re.search('sig (0x[0-9a-fA-F]+)', line).group(1) > + rev = re.search('rev (0x[0-9a-fA-F]+)', line).group(1) > + pfm = re.search('pf_mask (0x[0-9a-fA-F]+)', line).group(1) > + sig = int(sig, 16) > + rev = int(rev, 16) > + pfm = int(pfm, 16) > + debug_rev = bits(rev, 31, 31) > + if debug_rev != 0: > + print("Error: Debug ucode file found, exiting", file=sys.stderr) > + sys.exit(1) > + > + ucrev = {} > + ucrev['sig'] = sig > + ucrev['platforms'] = pfm > + ucrev['rev'] = rev > + ucode_list.append(ucrev) > + > +# Remove duplicates, if any > +ucode_dict = {} > +for rev in ucode_list: > + ucode_key = (rev['sig'], rev['platforms']) > + existing = ucode_dict.get(ucode_key) > + if existing is not None: > + # If the existing one is newer, just move on: > + if existing['rev'] > rev['rev']: > + continue > + ucode_dict[ucode_key] = rev > + > +# Prepare the microcode entries > +ucode_entries = [] > +for ucode_key in ucode_dict: > + rev = ucode_dict[ucode_key] > + sig = rev['sig'] > + ucode_entries.append({ > + 'family': family(sig), > + 'model': model(sig), > + 'steppings': 1 << step(sig), > + 'platforms': rev['platforms'], > + 'rev': rev['rev'], > + 'sig': sig > + }) This is crying out for a small class, and for the use of set() Try the attached version, which is rather more pythonic. ~Andrew --------------ixUTIDLRlF0rtsRgHrfU8HWq Content-Type: text/x-python; charset=UTF-8; name="update-intel-ucode-defs.py" Content-Disposition: attachment; filename="update-intel-ucode-defs.py" Content-Transfer-Encoding: base64 IyEvdXNyL2Jpbi9weXRob24zCiMgU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAKaW1w b3J0IGFyZ3BhcnNlCmltcG9ydCByZQppbXBvcnQgc2h1dGlsCmltcG9ydCBzdWJwcm9jZXNzCmlt cG9ydCBzeXMKaW1wb3J0IG9zCgpzY3JpcHQgPSBvcy5wYXRoLnJlbHBhdGgoX19maWxlX18pCgpE RVNDUklQVElPTiA9IGYiIiIKRm9yIEludGVsIENQVXMsIHVwZGF0ZSB0aGUgbWljcm9jb2RlIHJl dmlzaW9ucyB0aGF0IGRldGVybWluZQpYODZfQlVHX09MRF9NSUNST0NPREUuCgpUaGlzIHNjcmlw dCBpcyBpbnRlbmRlZCB0byBiZSBydW4gaW4gcmVzcG9uc2UgdG8gcmVsZWFzZXMgb2YgdGhlCm9m ZmljaWFsIEludGVsIG1pY3JvY29kZSBHaXRIdWIgcmVwb3NpdG9yeToKaHR0cHM6Ly9naXRodWIu Y29tL2ludGVsL0ludGVsLUxpbnV4LVByb2Nlc3Nvci1NaWNyb2NvZGUtRGF0YS1GaWxlcy5naXQK Ckl0IHRha2VzIHRoZSBJbnRlbCBtaWNyb2NvZGUgZmlsZXMgYXMgaW5wdXQgYW5kIHVzZXMgaXVj b2RlLXRvb2wgdG8KZXh0cmFjdCB0aGUgcmV2aXNpb24gaW5mb3JtYXRpb24uIEl0IHByaW50cyB0 aGUgb3V0cHV0IGluIHRoZSBmb3JtYXQKZXhwZWN0ZWQgYnkgaW50ZWwtdWNvZGUtZGVmcy5oLgoK VXNhZ2U6CiAgICAuL3tzY3JpcHR9IC9wYXRoL3RvL21pY3JvY29kZS9maWxlcyA+IC9wYXRoL3Rv L2ludGVsLXVjb2RlLWRlZnMuaAoKVHlwaWNhbGx5LCBzb21lb25lIGF0IEludGVsIHdvdWxkIHNl ZSBhIG5ldyBwdWJsaWMgcmVsZWFzZSwgd2FpdCBmb3IgYXQKbGVhc3QgdGhyZWUgbW9udGhzIHRv IGVuc3VyZSB0aGUgdXBkYXRlIGlzIHN0YWJsZSwgcnVuIHRoaXMgc2NyaXB0IHRvCnJlZnJlc2gg dGhlIGludGVsLXVjb2RlLWRlZnMuaCBmaWxlLCBhbmQgc2VuZCBhIHBhdGNoIHVwc3RyZWFtIHRv IHVwZGF0ZQp0aGUgbWFpbmxpbmUgYW5kIHN0YWJsZSB2ZXJzaW9ucy4KCkFzIGFsd2F5cywgdGhl cmUgY2FuIGJlIGV4Y2VwdGlvbnMgdG8gdGhlIGFib3ZlIHByb2Nlc3Mgd2hpY2ggc2hvdWxkIGJl CnN1cHBvcnRlZCBieSBhcHByb3ByaWF0ZSBqdXN0aWZpY2F0aW9uLgoiIiIKCnBhcnNlciA9IGFy Z3BhcnNlLkFyZ3VtZW50UGFyc2VyKGRlc2NyaXB0aW9uPURFU0NSSVBUSU9OLAogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBmb3JtYXR0ZXJfY2xhc3M9YXJncGFyc2UuUmF3RGVzY3Jp cHRpb25IZWxwRm9ybWF0dGVyKQpwYXJzZXIuYWRkX2FyZ3VtZW50KCd1Y29kZV9maWxlcycsIG5h cmdzPScrJywgaGVscD0nUGF0aChzKSB0byB0aGUgbWljcm9jb2RlIGZpbGVzJykKCmFyZ3MgPSBw YXJzZXIucGFyc2VfYXJncygpCgojIFByb2Nlc3MgdGhlIG1pY3JvY29kZSBmaWxlcyB1c2luZyBp dWNvZGUtdG9vbAppZiBzaHV0aWwud2hpY2goIml1Y29kZS10b29sIikgaXMgTm9uZToKICAgIHBy aW50KCJFcnJvcjogaXVjb2RlLXRvb2wgbm90IGZvdW5kLCBwbGVhc2UgaW5zdGFsbCBpdCIsIGZp bGU9c3lzLnN0ZGVycikKICAgIHN5cy5leGl0KDEpCgpjbWQgPSBbJ2l1Y29kZS10b29sJywgJy0t bGlzdC1hbGwnIF0KY21kLmV4dGVuZChhcmdzLnVjb2RlX2ZpbGVzKQoKcHJvY2VzcyA9IHN1YnBy b2Nlc3MuUG9wZW4oY21kLCBzdGRvdXQ9c3VicHJvY2Vzcy5QSVBFLCB1bml2ZXJzYWxfbmV3bGlu ZXM9VHJ1ZSkKcHJvY2Vzcy53YWl0KCkKaWYgcHJvY2Vzcy5yZXR1cm5jb2RlICE9IDA6CiAgICBw cmludCgiRXJyb3I6IGl1Y29kZS10b29sIHJhbiBpbnRvIGFuIGVycm9yLCBleGl0aW5nIiwgZmls ZT1zeXMuc3RkZXJyKQogICAgc3lzLmV4aXQoMSkKCiMgRnVuY3Rpb25zIHRvIGV4dHJhY3QgZmFt aWx5LCBtb2RlbCwgYW5kIHN0ZXBwaW5nCmRlZiBiaXRzKHZhbCwgYm90dG9tLCB0b3ApOgogICAg bWFzayA9ICgxIDw8ICh0b3AgKyAxIC0gYm90dG9tKSkgLSAxCiAgICByZXR1cm4gKHZhbCA+PiBi b3R0b20pICYgbWFzawoKZGVmIGZhbWlseShzaWcpOgogICAgaWYgYml0cyhzaWcsIDgsIDExKSA9 PSAweGY6CiAgICAgICAgcmV0dXJuIGJpdHMoc2lnLCA4LCAxMSkgKyBiaXRzKHNpZywgMjAsIDI3 KQogICAgcmV0dXJuIGJpdHMoc2lnLCA4LCAxMSkKCmRlZiBtb2RlbChzaWcpOgogICAgcmV0dXJu IGJpdHMoc2lnLCA0LCA3KSAgfCAoYml0cyhzaWcsIDE2LCAxOSkgPDwgNCkKCmRlZiBzdGVwKHNp Zyk6CiAgICByZXR1cm4gYml0cyhzaWcsIDAsIDMpCgpjbGFzcyBVY29kZToKICAgIGRlZiBfX2lu aXRfXyhzZWxmLCBzaWcsIHBmbSwgcmV2KToKICAgICAgICBzZWxmLnNpZyA9IHNpZwogICAgICAg IHNlbGYucGxhdGZvcm1zID0gcGZtCiAgICAgICAgc2VsZi5yZXYgPSByZXYKCiAgICAgICAgc2Vs Zi5mYW1pbHkgPSBmYW1pbHkoc2lnKQogICAgICAgIHNlbGYubW9kZWwgPSBtb2RlbChzaWcpCiAg ICAgICAgc2VsZi5zdGVwcGluZ3MgPSAxIDw8IHN0ZXAoc2lnKQoKICAgICAgICBzZWxmLmtleSA9 IChzZWxmLmZhbWlseSwgc2VsZi5tb2RlbCwgc2VsZi5zdGVwcGluZ3MsIHNlbGYucGxhdGZvcm1z KQoKICAgIGRlZiBfX2VxX18oc2VsZiwgb3RoZXIpOgogICAgICAgIHJldHVybiBzZWxmLmtleSA9 PSBvdGhlci5rZXkKCiAgICBkZWYgX19oYXNoX18oc2VsZik6CiAgICAgICAgcmV0dXJuIGhhc2go c2VsZi5rZXkpCgogICAgZGVmIF9fc3RyX18oc2VsZik6CiAgICAgICAgcmV0dXJuICJ7IC5mbGFn cyA9IFg4Nl9DUFVfSURfRkxBR19FTlRSWV9WQUxJRCwgLnZlbmRvciA9IFg4Nl9WRU5ET1JfSU5U RUwsIC5mYW1pbHkgPSAweCV4LCAgLm1vZGVsID0gMHglMDJ4LCAuc3RlcHBpbmdzID0gMHglMDR4 LCAucGxhdGZvcm1fbWFzayA9IDB4JTAyeCwgLmRyaXZlcl9kYXRhID0gMHgleCB9LCIgJSBcCiAg ICAgICAgICAgIChzZWxmLmZhbWlseSwgc2VsZi5tb2RlbCwgc2VsZi5zdGVwcGluZ3MsIHNlbGYu cGxhdGZvcm1zLCBzZWxmLnJldikKCnVjb2RlcyA9IHNldCgpCgojIFBhcnNlIHRoZSBvdXRwdXQg b2YgaXVjb2RlLXRvb2wKZm9yIGxpbmUgaW4gcHJvY2Vzcy5zdGRvdXQ6CiAgICBpZiBsaW5lLmZp bmQoIiBzaWcgIikgPT0gLTE6CiAgICAgICAgY29udGludWUKICAgIHNpZyA9IHJlLnNlYXJjaCgn c2lnICgweFswLTlhLWZBLUZdKyknLCBsaW5lKS5ncm91cCgxKQogICAgcmV2ID0gcmUuc2VhcmNo KCdyZXYgKDB4WzAtOWEtZkEtRl0rKScsIGxpbmUpLmdyb3VwKDEpCiAgICBwZm0gPSByZS5zZWFy Y2goJ3BmX21hc2sgKDB4WzAtOWEtZkEtRl0rKScsIGxpbmUpLmdyb3VwKDEpCiAgICBzaWcgPSBp bnQoc2lnLCAxNikKICAgIHJldiA9IGludChyZXYsIDE2KQogICAgcGZtID0gaW50KHBmbSwgMTYp CiAgICBkZWJ1Z19yZXYgPSBiaXRzKHJldiwgMzEsIDMxKQogICAgaWYgZGVidWdfcmV2ICE9IDA6 CiAgICAgICAgcHJpbnQoIkVycm9yOiBEZWJ1ZyB1Y29kZSBmaWxlIGZvdW5kLCBleGl0aW5nIiwg ZmlsZT1zeXMuc3RkZXJyKQogICAgICAgIHN5cy5leGl0KDEpCgogICAgdWNvZGVzLmFkZChVY29k ZShzaWcsIHBmbSwgcmV2KSkKCmlmIG5vdCB1Y29kZXM6CiAgICBwcmludCgiRXJyb3I6IE5vIHZh bGlkIG1pY3JvY29kZSBmaWxlcyBmb3VuZCwgZXhpdGluZyIsIGZpbGU9c3lzLnN0ZGVycikKICAg IHN5cy5leGl0KDEpCgojIFNvcnQgYW5kIHByaW50IHRoZSBtaWNyb2NvZGUgZW50cmllcwpmb3Ig dSBpbiBzb3J0ZWQodWNvZGVzLCBrZXk9bGFtYmRhIHg6IHgua2V5KToKICAgIHByaW50KHUpCg== --------------ixUTIDLRlF0rtsRgHrfU8HWq--