From: Terry Bowman <terry.bowman@amd.com>
To: Chen Yu <yu.c.chen@intel.com>, youling257 <youling257@gmail.com>,
Kurt Garloff <kurt@garloff.de>, Bingsong Si <owen.si@ucloud.cn>,
"Artem S . Tashkinov" <aros@gmx.com>
Cc: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>,
Calvin Walton <calvin.walton@kepstin.ca>,
Borislav Petkov <bp@suse.de>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] tools/power/turbostat: Fix long time duration RAPL calculation
Date: Thu, 29 Apr 2021 14:47:12 -0500 [thread overview]
Message-ID: <98b16cc0-f69b-d443-8a75-076a8117946a@amd.com> (raw)
In-Reply-To: <cover.1619600637.git.yu.c.chen@intel.com>
Both patches look good to me. I tested both on AMD Epyc Rome. Iverified
the missing output is fixed and used instrumentationto verify the
sign-extension issues are resolved.
Please add:
Signed-off-by: Terry Bowman <Terry.Bowman@amd.com>
Regards,
Terry
On 4/28/21 4:08 AM, Chen Yu wrote:
> A combination of patch set to fix the recently introduced long time
> duration RAPL calculation issue found on AMD CPUs.
>
> Youling, Kurt, Bingsong, Artem, could you please confirm again
> if this patch set works for you on your platform?
>
> Bas Nieuwenhuizen (1):
> tools/power/turbostat: Fix turbostat for AMD Zen CPUs
>
> Calvin Walton (1):
> tools/power turbostat: Fix offset overflow issue in index converting
>
> tools/power/x86/turbostat/turbostat.c | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)
>
prev parent reply other threads:[~2021-04-29 19:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 9:08 Chen Yu
2021-04-28 9:09 ` [PATCH 1/2] tools/power/turbostat: Fix turbostat for AMD Zen CPUs Chen Yu
2021-04-28 9:09 ` [PATCH 2/2] tools/power turbostat: Fix offset overflow issue in index converting Chen Yu
2021-04-29 19:47 ` Terry Bowman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98b16cc0-f69b-d443-8a75-076a8117946a@amd.com \
--to=terry.bowman@amd.com \
--cc=aros@gmx.com \
--cc=bas@basnieuwenhuizen.nl \
--cc=bp@suse.de \
--cc=calvin.walton@kepstin.ca \
--cc=kurt@garloff.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=owen.si@ucloud.cn \
--cc=youling257@gmail.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®