From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB308C43219 for ; Tue, 30 Apr 2019 19:32:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 780262063F for ; Tue, 30 Apr 2019 19:32:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y3vY57Xs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726901AbfD3TcT (ORCPT ); Tue, 30 Apr 2019 15:32:19 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:50895 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726006AbfD3TcS (ORCPT ); Tue, 30 Apr 2019 15:32:18 -0400 Received: by mail-wm1-f68.google.com with SMTP id p21so5075397wmc.0; Tue, 30 Apr 2019 12:32:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VwcoE94rdoDgV1VfL7dXkP4guKkTeWDugiKCwb7SelE=; b=Y3vY57XsVL69Qz9vSUswirKwc6rPRSyTnWq8oR6ZqSHXBaYUVk6lhMS6T4XGMfVvRz YX8VZvOgwu2WE8OGl6iheOyQjYY4kwwp3SeBS+sLgd9NaRyfoMKbNcMszef2JjlYyc5y A9H0XPnfWSOlzjtWn2SwQVMcYn7PYJ1RcbX4emeLCN/3HSwHEJC0bsTUmbWr9y6wM/t0 AXp4QhBmc0J+YoKtb0GJUsmuO8+4IWj06vl8BCy/yTDfp8CBwDVGaMUHEBE/FLOfVUX7 fQdLV6XKUNnDUYq9HnjbgDfFVkQrn8n6KX+HGYsjJADRtku7ebWiWBMJ9eBnO7NUTcwc 1FSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VwcoE94rdoDgV1VfL7dXkP4guKkTeWDugiKCwb7SelE=; b=fYoKY/FY2RRLpPmxjC7WC8cAYrOmZdbwwdYUr7uNKNbdv2mqRBhIxB0BDuYumIQYAn /9mNDHR5tVs1OP47THugxXk4L3O+BbROT1I/JehP3F0LHu4I9DiTkhEFNkph5V2Syomg +LwrTjXYOXdhgTkS+6f5KNJqqTvhnZ9QR8cjvNUXc7qQHGqsVDKDdS4ggBhFlKsI6cBF K54WdF+JDKegoxUTdbPKlKcDDn7sf9MGu/R364NTu/n6tk2Y5byfZ1RVkdtn4glwp8Y8 68UfdA6YcqwPlyvGSM7DNF7716+nxFo3Q5sL90bLyGtdqDZ18VEEVWUhPWQfgf6zsn0P 2CdA== X-Gm-Message-State: APjAAAUuD0aGb0UvEMVQrm8URMhmm6IX+XuiYPz28Fnqrdwax8ErxYe5 CS415NQ/wnb6QS3ANf68diehENMt X-Google-Smtp-Source: APXvYqyne/P6d+tX6M5/o+xILX7VOrBUPVOftY9uaprYqCuCNHOBpYfgE0vScxuxshbef5cUd+zBFA== X-Received: by 2002:a1c:2d0e:: with SMTP id t14mr4238197wmt.33.1556652736795; Tue, 30 Apr 2019 12:32:16 -0700 (PDT) Received: from [192.168.1.19] (chf176.neoplus.adsl.tpnet.pl. [83.31.3.176]) by smtp.gmail.com with ESMTPSA id x20sm19191261wrg.29.2019.04.30.12.32.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Apr 2019 12:32:16 -0700 (PDT) Subject: Re: [PATCH v3 4/7] leds: TI LMU: Add common code for TI LMU devices To: Dan Murphy , Randy Dunlap , pavel@ucw.cz Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190430191730.19450-1-dmurphy@ti.com> <20190430191730.19450-5-dmurphy@ti.com> <7d161cbc-d6bd-83aa-3790-6c45fdf9521f@infradead.org> From: Jacek Anaszewski Message-ID: <98b7f0fd-6f94-b8a1-a367-77d8cae2a97e@gmail.com> Date: Tue, 30 Apr 2019 21:32:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/30/19 9:30 PM, Dan Murphy wrote: > Randy > > On 4/30/19 2:23 PM, Randy Dunlap wrote: >> On 4/30/19 12:17 PM, Dan Murphy wrote: >>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig >>> index da00b9ed5a5c..3ae24eaf4cde 100644 >>> --- a/drivers/leds/Kconfig >>> +++ b/drivers/leds/Kconfig >>> @@ -776,6 +776,14 @@ config LEDS_NIC78BX >>> To compile this driver as a module, choose M here: the module >>> will be called leds-nic78bx. >>> >>> +config LEDS_TI_LMU_COMMON >>> + tristate "LED driver for TI LMU" >> >> what does LMU mean? > > Lighting management unit it is defined in the DT documentation > >> >>> + depends on REGMAP >>> + help >>> + Say Y to enable the LED driver for TI LMU devices. >>> + This supports common features between the TI LM3532, LM3631, LM3632, >>> + LM3633, LM3695 and LM3697. >> >> Fix help indentation above to use tab + 2 spaces consistently. >> > > UGH I wish I had this comment 2 weeks ago. > But I can fix it I will amend this while merging, no need to resend. -- Best regards, Jacek Anaszewski