From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D2CFEB64DA for ; Thu, 22 Jun 2023 05:50:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230513AbjFVFuc (ORCPT ); Thu, 22 Jun 2023 01:50:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229682AbjFVFu3 (ORCPT ); Thu, 22 Jun 2023 01:50:29 -0400 Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E90EAC; Wed, 21 Jun 2023 22:50:28 -0700 (PDT) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35LJYs7j016592; Wed, 21 Jun 2023 22:50:10 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pfpt0220; bh=Y75bt0Jx0wSsfTOjNWsZv8qJpJNCXq/KYo/Qcs4d6Dg=; b=Ie3ie29G85lkbJG08lFtuRS/E/mh48dnJDBBWEOjGIv5tQEs4eX5ystePYoZa4AQt4+L LbfgOG/Oy2VVgg9fk4jJLpDkCTwIlIAHlMloiG/s5/JLMzN+mohjOahGzmqDZG37XC/k tKsnVTAVGSpy1hefbxiYxNqkVpf8fM9eKmik0DctlsacaZYVjl5DqVUi+bOskx9HP0+Z V3Ru7gxGvW5EGORbS+HK1++uZ8fREKUfoNRwxBOgrL9CZBx1NJH6+8IrYdVFx+5lia14 cAO3U3ICy8OCaCMKrjqFRik3WOtIcL9eyEW1qgEil5QE6/5i0VGeopmtoQemugohMvFU fA== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3rbyhq3shs-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 21 Jun 2023 22:50:10 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Wed, 21 Jun 2023 22:50:08 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Wed, 21 Jun 2023 22:50:08 -0700 Received: from [10.193.33.161] (unknown [10.193.33.161]) by maili.marvell.com (Postfix) with ESMTP id 00E573F7086; Wed, 21 Jun 2023 22:49:54 -0700 (PDT) Message-ID: <98b9dc2d-9232-d0e0-022e-2e8339b3cb66@marvell.com> Date: Thu, 22 Jun 2023 07:49:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [EXT] Re: [PATCH] net: atlantic: fix ring buffer alignment To: Jakub Kicinski , Simon Horman CC: Arnd Bergmann , "David S. Miller" , Eric Dumazet , Paolo Abeni , Arnd Bergmann , Nathan Chancellor , Nick Desaulniers , Tom Rix , , , References: <20230616092645.3384103-1-arnd@kernel.org> <20230620120038.0d9a261c@kernel.org> Content-Language: en-US From: Igor Russkikh In-Reply-To: <20230620120038.0d9a261c@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: KHJNdM6_oMskMlKCq_KuaXUGSm0Dil41 X-Proofpoint-GUID: KHJNdM6_oMskMlKCq_KuaXUGSm0Dil41 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-22_02,2023-06-16_01,2023-05-22_02 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jakub, Arnd, > On Fri, 16 Jun 2023 15:10:03 +0200 Simon Horman wrote: >> Perhaps it just me. But I do have trouble reconciling the description >> above with the structure below. As such, my suggest would be to simply >> delete it. > > Agreed that the comment is confusing seems to be incorrect post-change. > Flags for instance are overlapped with len, is_gso etc. so they can't be > a separate 8B at the end. > > Igor, please advise how you want to proceed. I do agree better to remove the comment at all - it explains almost nothing. Thats not a hardware related structure, so explicit pack is for sure not required. Acked-by: Igor Russkikh Regards, Igor