From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752692AbdBCVtg (ORCPT ); Fri, 3 Feb 2017 16:49:36 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:33031 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752268AbdBCVte (ORCPT ); Fri, 3 Feb 2017 16:49:34 -0500 Subject: Re: [PATCH v2 2/2] net: ethernet: bgmac: mac address change bug To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Jon Mason , David Miller References: <1486156133-5639-1-git-send-email-jon.mason@broadcom.com> <1486156133-5639-3-git-send-email-jon.mason@broadcom.com> <43694eda-e7fd-0df5-6bec-147770e04d5c@milecki.pl> Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Hari Vyas From: Florian Fainelli Message-ID: <98cd2c6a-8bd9-39c7-0288-ce84130627b5@gmail.com> Date: Fri, 3 Feb 2017 13:49:32 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <43694eda-e7fd-0df5-6bec-147770e04d5c@milecki.pl> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/03/2017 01:44 PM, Rafał Miłecki wrote: > On 02/03/2017 10:08 PM, Jon Mason wrote: >> From: Hari Vyas >> >> ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to >> bgmac_set_mac_address() but code assumed u8 *. This caused two bytes >> chopping and the wrong mac address was configured. >> >> Signed-off-by: Hari Vyas >> Signed-off-by: Jon Mason >> Fixes: 4e209001b86 ("bgmac: write mac address to hardware in >> ndo_set_mac_address") > > I think you were going to Cc stable? David takes care of queueing patches for -stable trees: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.txt#n114 -- Florian