From: Robin Murphy <robin.murphy@arm.com>
To: John Garry <john.garry@huawei.com>,
will@kernel.org, mark.rutland@arm.com
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, jean-philippe@linaro.org,
thunder.leizhen@huawei.com, shameerali.kolothum.thodi@huawei.com
Subject: Re: [PATCH] driver/perf: Remove ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3
Date: Mon, 1 Feb 2021 11:48:18 +0000 [thread overview]
Message-ID: <98ce3401-cac9-2111-5ae5-082808a6edc4@arm.com> (raw)
In-Reply-To: <1612175042-56866-1-git-send-email-john.garry@huawei.com>
On 2021-02-01 10:24, John Garry wrote:
> The ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3_PMU was added with the idea
> that a SMMUv3 PMCG would only exist on a system with an associated SMMUv3.
>
> However it is not the job of Kconfig to make these sorts of decisions (even
> if it were true), so remove the dependency.
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: John Garry <john.garry@huawei.com>
>
> diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig
> index 3075cf171f78..77522e5efe11 100644
> --- a/drivers/perf/Kconfig
> +++ b/drivers/perf/Kconfig
> @@ -62,7 +62,7 @@ config ARM_PMU_ACPI
>
> config ARM_SMMU_V3_PMU
> tristate "ARM SMMUv3 Performance Monitors Extension"
> - depends on ARM64 && ACPI && ARM_SMMU_V3
> + depends on ARM64 && ACPI
> help
> Provides support for the ARM SMMUv3 Performance Monitor Counter
> Groups (PMCG), which provide monitoring of transactions passing
>
next prev parent reply other threads:[~2021-02-01 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 10:24 John Garry
2021-02-01 11:48 ` Robin Murphy [this message]
2021-02-01 13:05 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98ce3401-cac9-2111-5ae5-082808a6edc4@arm.com \
--to=robin.murphy@arm.com \
--cc=jean-philippe@linaro.org \
--cc=john.garry@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=thunder.leizhen@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®