From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: Zhan Xusheng <zhanxusheng1024@gmail.com>
Cc: <ntfs3@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<stable@vger.kernel.org>, Zhan Xusheng <zhanxusheng@xiaomi.com>
Subject: Re: [PATCH] fs/ntfs3: fix syncing wrong inode on DIRSYNC cross-directory rename
Date: Fri, 22 May 2026 17:24:04 +0200 [thread overview]
Message-ID: <98d4d18b-542a-49ca-b27d-211f123e3ba9@paragon-software.com> (raw)
In-Reply-To: <20260506075554.7469-1-zhanxusheng@xiaomi.com>
On 5/6/26 09:55, Zhan Xusheng wrote:
> In ntfs3_rename(), when IS_DIRSYNC(new_dir) is true, the code syncs
> the renamed file inode instead of the target directory new_dir:
> if (IS_DIRSYNC(new_dir))
> ntfs_sync_inode(inode); /* should be new_dir */
>
> DIRSYNC requires that directory metadata changes are written to disk
> synchronously. Since new_dir was modified (a new directory entry was
> added), it is new_dir that must be synced to satisfy the guarantee,
> not the renamed file itself.
>
> This bug has existed since the initial ntfs3 implementation and was
> carried through the refactoring in commit 78ab59fee07f
> ("fs/ntfs3: Rework file operations").
>
> Fix by syncing new_dir instead of inode.
>
> Fixes: 4342306f0f0d ("fs/ntfs3: Add file operations and implementation")
> Cc: stable@vger.kernel.org
> Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
> ---
> v2:
> - Cc ntfs3@lists.linux.dev (was missing in v1, see
> https://lore.kernel.org/all/20260422152010.205694-1-zhanxusheng@xiaomi.com/).
> - Add Cc: stable@vger.kernel.org; this is a data-persistence bug under
> DIRSYNC and affects all ntfs3 since 4342306f0f0d.
> v1: https://lore.kernel.org/all/20260422152010.205694-1-zhanxusheng@xiaomi.com/
> ---
> fs/ntfs3/namei.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ntfs3/namei.c b/fs/ntfs3/namei.c
> index b2af8f695e60..64cde1a856f4 100644
> --- a/fs/ntfs3/namei.c
> +++ b/fs/ntfs3/namei.c
> @@ -340,7 +340,7 @@ static int ntfs_rename(struct mnt_idmap *idmap, struct inode *dir,
> ntfs_sync_inode(dir);
>
> if (IS_DIRSYNC(new_dir))
> - ntfs_sync_inode(inode);
> + ntfs_sync_inode(new_dir);
> }
>
> if (dir_ni != new_dir_ni)
Hello,
Sorry for the delay.
Applied, thank you.
Regards,
Konstantin
prev parent reply other threads:[~2026-05-22 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 15:20 Zhan Xusheng
2026-05-06 7:55 ` Zhan Xusheng
2026-05-22 15:24 ` Konstantin Komarov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98d4d18b-542a-49ca-b27d-211f123e3ba9@paragon-software.com \
--to=almaz.alexandrovich@paragon-software.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=zhanxusheng1024@gmail.com \
--cc=zhanxusheng@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®