From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9E2227877B for ; Wed, 10 Sep 2025 11:47:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757504841; cv=none; b=M0kE0NQqtyu3ULXL0uGm99kTs/ipRnNqfbK6uhJv8d6ULmI1saSQ6crhI6ydrj0bu0K1WlRrHDKVcxJNIk4xOEzuayTzLs5XOkimBR6DrXa+2wuAFWJKseejWgzCohPb7laC03AKOqON0vt9Oz8JuqvzyZh4GgMqQm7sz+Co1fQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757504841; c=relaxed/simple; bh=lbVleNB36fG112XJp199lcPL6rD2vaZRqT8hFjobxP0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lGKIvvK2OzwVuOWb+pxDPz+uEgfrgoV3rDlwFyjh7Ae/U7sxrjnUBuM+W3O1YtwXjt+cPImh4dD9BpJsrhbJoI9vmshvFQC/R65bY3WQI5k0ySrLUcnkJ/UB+UDtCldnGIfjGB4xOs0yvI6nrKByQuh/MaD6I9V+oFMnrJnOUfw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=bjc9Jpz0; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="bjc9Jpz0" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3c46686d1e6so4332556f8f.3 for ; Wed, 10 Sep 2025 04:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1757504838; x=1758109638; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=4b8l9UODp/FeCRZCFvzP4dsffoCBp+wjbwx4BoMSIwg=; b=bjc9Jpz0wsqoK1Q/e7o0LX2Zg06F2GnUSUuhk+iOYeh+a+N2xsZ4zALT+klTsofDM5 PivKeCDnbQbVPHZwTBDJq3YwET226q86w4rhHNlzXl+PyC7pB1xAvV1IJBSw8I6GEzAp DyU6J9VBdUZOtyWyReKFoyvCGGlwecOlTyc6Tfhi9/zs4RAxYoc9bd6jEwdJo8X04mjk soFKpxUYL8HiyZ05ObwARaNvv7gBvzVDeHG5aJh9wPcWMUce8WAvaL/07XIhiqzZDcjF h7lfltqaq/frL+Xlivl9YN7dpbHcTxyU7niLhI5h28Vz/B9rdvj0ASLNWXasbnhgXFSf 0hJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757504838; x=1758109638; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4b8l9UODp/FeCRZCFvzP4dsffoCBp+wjbwx4BoMSIwg=; b=ofWYumsmRZfj9yJwlvGcH6po1R0WRHJWji57zQonlha3wz3Xk7sPNTVLbZME7scrIn IcsLyIVyLD3YQV5iWaSFmROdUCcZSaTmnIt8SfNkuR4vY32/tSwbBmjqejzwyjQuYMIk fMXVDjFJTbBSB4rfq13kwQMeCFzX+2lOocJ3O3U6NE0dke2XqbHwousALf6eoa1Qvwg5 Iqwa0F00NZuOvudZChUkbT3jTGCAlj3zm4sRlcZk1GOCAEVd5aKCpfAn+EFnz1bt3aDd C9ccyTk1F1OJs4aw3NOX8FLgdc2QSn4Sw8OoLAUvFiZiusPwPT36nGn5UUwDNwL8eP4L jyMw== X-Gm-Message-State: AOJu0YxBbuOdDaBIIpHxon90/iQ5sYHvGbDIYX5K9clfVUIVhLwOskAq x5tDIT9aoc5dePNHzzEMWzRi/GADssXn7x9p91Wka/u/bUvb0bdIywtlgAw5+DBALNKFgJqeK1i mDvMy X-Gm-Gg: ASbGnctO99ht5Jf6kStMvm7g4QeroQT4FxHUYqFvrCKlPddhpqecZ85CtKOrVTr9NPv uJwIZ17Rx+ipNkz/LAUiqL/oB4rLDzls1S6l5fdQtNl/Fv4Hz9dECjZLPP9Yrt34v3AWV4BclFV 668NMxaEBB2PZVRZGi4eQxNEt3gCebTSu2AdZ82MNaJIjfFKtyHomU1YGAZcMUEsuU60GNiJMvQ j4PkuZlHDimLH6AeUIxyCTAKR45IeXIVMM91vkHpZRhY2NDM0NuQkoEFoETEFD7I6id+M1dV+mr 7eVLRN+1ScxFkMtBU9qZAzmc5WHo2P33QCnASsWrwZg+G8rYRu+kZTkuN548J8Qr9BVoZAzdqAP JsvkgybXoMDlzDy/aM8w6s70Em8HjEScKXUbH X-Google-Smtp-Source: AGHT+IHzDMf/jaVov1RUOe73ZJkbRYR7qCbsg0/lCE8ZJG90MzF2ZKZezbrOeFUqcZDoFKM+jB3U0w== X-Received: by 2002:a05:6000:25c8:b0:3e2:6d96:b4b4 with SMTP id ffacd0b85a97d-3e643555864mr10937053f8f.41.1757504838050; Wed, 10 Sep 2025 04:47:18 -0700 (PDT) Received: from [192.168.0.20] ([212.21.159.60]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e752238832sm6381943f8f.31.2025.09.10.04.47.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Sep 2025 04:47:17 -0700 (PDT) Message-ID: <98d80660-7140-43a2-b17c-07a0884996f8@suse.com> Date: Wed, 10 Sep 2025 14:47:16 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 02/15] x86/mce: Define BSP-only init To: Yazen Ghannam , x86@kernel.org, Tony Luck , "Rafael J. Wysocki" Cc: linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, Smita.KoralahalliChannabasappa@amd.com, Qiuxu Zhuo , linux-acpi@vger.kernel.org References: <20250908-wip-mca-updates-v6-0-eef5d6c74b9c@amd.com> <20250908-wip-mca-updates-v6-2-eef5d6c74b9c@amd.com> From: Nikolay Borisov Content-Language: en-US Autocrypt: addr=nik.borisov@suse.com; keydata= xsFNBGcrpvIBEAD5cAR5+qu30GnmPrK9veWX5RVzzbgtkk9C/EESHy9Yz0+HWgCVRoNyRQsZ 7DW7vE1KhioDLXjDmeu8/0A8u5nFMqv6d1Gt1lb7XzSAYw7uSWXLPEjFBtz9+fBJJLgbYU7G OpTKy6gRr6GaItZze+r04PGWjeyVUuHZuncTO7B2huxcwIk9tFtRX21gVSOOC96HcxSVVA7X N/LLM2EOL7kg4/yDWEhAdLQDChswhmdpHkp5g6ytj9TM8bNlq9I41hl/3cBEeAkxtb/eS5YR 88LBb/2FkcGnhxkGJPNB+4Siku7K8Mk2Y6elnkOctJcDvk29DajYbQnnW4nhfelZuLNupb1O M0912EvzOVI0dIVgR+xtosp66bYTOpX4Xb0fylED9kYGiuEAeoQZaDQ2eICDcHPiaLzh+6cc pkVTB0sXkWHUsPamtPum6/PgWLE9vGI5s+FaqBaqBYDKyvtJfLK4BdZng0Uc3ijycPs3bpbQ bOnK9LD8TYmYaeTenoNILQ7Ut54CCEXkP446skUMKrEo/HabvkykyWqWiIE/UlAYAx9+Ckho TT1d2QsmsAiYYWwjU8igXBecIbC0uRtF/cTfelNGrQwbICUT6kJjcOTpQDaVyIgRSlUMrlNZ XPVEQ6Zq3/aENA8ObhFxE5PLJPizJH6SC89BMKF3zg6SKx0qzQARAQABzSZOaWtvbGF5IEJv cmlzb3YgPG5pay5ib3Jpc292QHN1c2UuY29tPsLBkQQTAQoAOxYhBDuWB8EJLBUZCPjT3SRn XZEnyhfsBQJnK6byAhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJECRnXZEnyhfs XbIQAJxuUnelGdXbSbtovBNm+HF3LtT0XnZ0+DoR0DemUGuA1bZAlaOXGr5mvVbTgaoGUQIJ 3Ejx3UBEG7ZSJcfJobB34w1qHEDO0pN9orGIFT9Bic3lqhawD2r85QMcWwjsZH5FhyRx7P2o DTuUClLMO95GuHYQngBF2rHHl8QMJPVKsR18w4IWAhALpEApxa3luyV7pAAqKllfCNt7tmed uKmclf/Sz6qoP75CvEtRbfAOqYgG1Uk9A62C51iAPe35neMre3WGLsdgyMj4/15jPYi+tOUX Tc7AAWgc95LXyPJo8069MOU73htZmgH4OYy+S7f+ArXD7h8lTLT1niff2bCPi6eiAQq6b5CJ Ka4/27IiZo8tm1XjLYmoBmaCovqx5y5Xt2koibIWG3ZGD2I+qRwZ0UohKRH6kKVHGcrmCv0J YO8yIprxgoYmA7gq21BpTqw3D4+8xujn/6LgndLKmGESM1FuY3ymXgj5983eqaxicKpT9iq8 /a1j31tms4azR7+6Dt8H4SagfN6VbJ0luPzobrrNFxUgpjR4ZyQQ++G7oSRdwjfIh1wuCF6/ mDUNcb6/kA0JS9otiC3omfht47yQnvod+MxFk1lTNUu3hePJUwg1vT1te3vO5oln8lkUo9BU knlYpQ7QA2rDEKs+YWqUstr4pDtHzwQ6mo0rqP+zzsFNBGcrpvIBEADGYTFkNVttZkt6e7yA LNkv3Q39zQCt8qe7qkPdlj3CqygVXfw+h7GlcT9fuc4kd7YxFys4/Wd9icj9ZatGMwffONmi LnUotIq2N7+xvc4Xu76wv+QJpiuGEfCDB+VdZOmOzUPlmMkcJc/EDSH4qGogIYRu72uweKEq VfBI43PZIGpGJ7TjS3THX5WVI2YNSmuwqxnQF/iVqDtD2N72ObkBwIf9GnrOgxEyJ/SQq2R0 g7hd6IYk7SOKt1a8ZGCN6hXXKzmM6gHRC8fyWeTqJcK4BKSdX8PzEuYmAJjSfx4w6DoxdK5/ 9sVrNzaVgDHS0ThH/5kNkZ65KNR7K2nk45LT5Crjbg7w5/kKDY6/XiXDx7v/BOR/a+Ryo+lM MffN3XSnAex8cmIhNINl5Z8CAvDLUtItLcbDOv7hdXt6DSyb65CdyY8JwOt6CWno1tdjyDEG 5ANwVPYY878IFkOJLRTJuUd5ltybaSWjKIwjYJfIXuoyzE7OL63856MC/Os8PcLfY7vYY2LB cvKH1qOcs+an86DWX17+dkcKD/YLrpzwvRMur5+kTgVfXcC0TAl39N4YtaCKM/3ugAaVS1Mw MrbyGnGqVMqlCpjnpYREzapSk8XxbO2kYRsZQd8J9ei98OSqgPf8xM7NCULd/xaZLJUydql1 JdSREId2C15jut21aQARAQABwsF2BBgBCgAgFiEEO5YHwQksFRkI+NPdJGddkSfKF+wFAmcr pvICGwwACgkQJGddkSfKF+xuuxAA4F9iQc61wvAOAidktv4Rztn4QKy8TAyGN3M8zYf/A5Zx VcGgX4J4MhRUoPQNrzmVlrrtE2KILHxQZx5eQyPgixPXri42oG5ePEXZoLU5GFRYSPjjTYmP ypyTPN7uoWLfw4TxJqWCGRLsjnkwvyN3R4161Dty4Uhzqp1IkNhl3ifTDYEvbnmHaNvlvvna 7+9jjEBDEFYDMuO/CA8UtoVQXjy5gtOhZZkEsptfwQYc+E9U99yxGofDul7xH41VdXGpIhUj 4wjd3IbgaCiHxxj/M9eM99ybu5asvHyMo3EFPkyWxZsBlUN/riFXGspG4sT0cwOUhG2ZnExv XXhOGKs/y3VGhjZeCDWZ+0ZQHPCL3HUebLxW49wwLxvXU6sLNfYnTJxdqn58Aq4sBXW5Un0Q vfbd9VFV/bKFfvUscYk2UKPi9vgn1hY38IfmsnoS8b0uwDq75IBvup9pYFyNyPf5SutxhFfP JDjakbdjBoYDWVoaPbp5KAQ2VQRiR54lir/inyqGX+dwzPX/F4OHfB5RTiAFLJliCxniKFsM d8eHe88jWjm6/ilx4IlLl9/MdVUGjLpBi18X7ejLz3U2quYD8DBAGzCjy49wJ4Di4qQjblb2 pTXoEyM2L6E604NbDu0VDvHg7EXh1WwmijEu28c/hEB6DwtzslLpBSsJV0s1/jE= In-Reply-To: <20250908-wip-mca-updates-v6-2-eef5d6c74b9c@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/8/25 18:40, Yazen Ghannam wrote: > Currently, MCA initialization is executed identically on each CPU as > they are brought online. However, a number of MCA initialization tasks > only need to be done once. > > Define a function to collect all 'global' init tasks and call this from > the BSP only. Start with CPU features. > > Reviewed-by: Qiuxu Zhuo > Tested-by: Tony Luck > Reviewed-by: Tony Luck > Signed-off-by: Yazen Ghannam > @@ -2240,6 +2233,27 @@ DEFINE_IDTENTRY_RAW(exc_machine_check) > } > #endif > > +void mca_bsp_init(struct cpuinfo_x86 *c) > +{ > + u64 cap; > + > + if (!mce_available(c)) > + return; > + > + mce_flags.overflow_recov = cpu_feature_enabled(X86_FEATURE_OVERFLOW_RECOV); > + mce_flags.succor = cpu_feature_enabled(X86_FEATURE_SUCCOR); > + mce_flags.smca = cpu_feature_enabled(X86_FEATURE_SMCA); > + > + rdmsrq(MSR_IA32_MCG_CAP, cap); > + > + /* Use accurate RIP reporting if available. */ > + if ((cap & MCG_EXT_P) && MCG_EXT_CNT(cap) >= 9) > + mca_cfg.rip_msr = MSR_IA32_MCG_EIP; > + > + if (cap & MCG_SER_P) > + mca_cfg.ser = 1; > +} > + LGTM Reviewed-by: Nikolay Borisov nit: One question though for those CPUs which consist of P+E cores, is it mandated that both types of cores will have identical MCE architecture, I assume the x86 world will be a lot more unified than Arm's big.LITTLE ? > /* > * Called for each booted CPU to set up machine checks. > * Must be called with preempt off: >