From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Frank Wunderlich (linux)" <linux@fw-web.de>
Cc: "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Lee Jones" <lee@kernel.org>,
"Chunfeng Yun" <chunfeng.yun@mediatek.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Frank Wunderlich" <frank-w@public-files.de>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Daniel Golle" <daniel@makrotopia.org>,
"Sean Wang" <sean.wang@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org
Subject: Re: [PATCH v3 4/8] dt-bindings: phy: mtk-xs-phy: support type switch by pericfg
Date: Thu, 17 Apr 2025 14:07:39 +0200 [thread overview]
Message-ID: <98dbc394-3628-4244-81cd-6b7f36b47fa4@kernel.org> (raw)
In-Reply-To: <b59ccb4541f4eac24fd38a65de770c8c@fw-web.de>
On 17/04/2025 11:35, Frank Wunderlich (linux) wrote:
>>>>> + - description:
>>>>> + The first cell represents a phandle to syscon
>>>>
>>>> Don't repeat constraints in free form text. "Foo bar system
>>>> controller"
>>>> or "Phandle to foo bar system controller"
>>>
>>> i would write only "phandle to system controller". on mt7988 it is the
>>> topmisc syscon, but maybe on
>>> other SoC it is different name.
>>
>> This must be specific to what sort of system controller you point. You
>> are not interested in phandle to any system controller.
>
> how about phy configuration controller/register?
If that's distinctive enough to identify the controller and its
register, then sure.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-17 12:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 9:53 [PATCH v3 0/8] Add Bananapi R4 variants and add xsphy Frank Wunderlich
2025-04-16 9:53 ` [PATCH v3 1/8] dt-bindings: arm: mediatek: add bpi-r4 2g5 phy variant Frank Wunderlich
2025-04-17 6:28 ` Krzysztof Kozlowski
2025-04-16 9:53 ` [PATCH v3 2/8] arm64: dts: mediatek: mt7988a-bpi-r4: allow hw variants of bpi-r4 Frank Wunderlich
2025-04-16 9:53 ` [PATCH v3 3/8] dt-bindings: phy: mtk-xs-phy: Add mt7988 compatible Frank Wunderlich
2025-04-17 6:53 ` Krzysztof Kozlowski
2025-04-16 9:53 ` [PATCH v3 4/8] dt-bindings: phy: mtk-xs-phy: support type switch by pericfg Frank Wunderlich
2025-04-17 6:56 ` Krzysztof Kozlowski
2025-04-17 7:52 ` Frank Wunderlich (linux)
2025-04-17 7:59 ` Krzysztof Kozlowski
2025-04-17 9:35 ` Frank Wunderlich (linux)
2025-04-17 12:07 ` Krzysztof Kozlowski [this message]
2025-04-16 9:53 ` [PATCH v3 5/8] dt-bindings: mfd: syscon: Add mt7988-topmisc Frank Wunderlich
2025-04-16 9:53 ` [PATCH v3 6/8] phy: mediatek: xsphy: support type switch by pericfg Frank Wunderlich
2025-04-16 9:53 ` [PATCH v3 7/8] arm64: dts: mediatek: mt7988: Add xsphy for ssusb0/pcie2 Frank Wunderlich
2025-04-16 9:54 ` [PATCH v3 8/8] arm64: dts: mediatek: mt7988a-bpi-r4: enable xsphy Frank Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98dbc394-3628-4244-81cd-6b7f36b47fa4@kernel.org \
--to=krzk@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunfeng.yun@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux@fw-web.de \
--cc=matthias.bgg@gmail.com \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®