From: Eric Dumazet <eric.dumazet@gmail.com>
To: Yafang Shao <laoar.shao@gmail.com>, David Miller <davem@davemloft.net>
Cc: Song Liu <songliubraving@fb.com>, netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 net-next] tcp: use data length instead of skb->len in tcp_probe
Date: Tue, 29 May 2018 07:42:25 -0700 [thread overview]
Message-ID: <98df6d86-f237-b2d4-9f85-ce6d11c1ac4f@gmail.com> (raw)
In-Reply-To: <CALOAHbAzy_KfT0FcU9fumPKZgSaSOAAfY755TGxsJU7toB_1dA@mail.gmail.com>
On 05/29/2018 07:36 AM, Yafang Shao wrote:
> On Tue, May 29, 2018 at 10:15 PM, David Miller <davem@davemloft.net> wrote:
>> From: Yafang Shao <laoar.shao@gmail.com>
>> Date: Fri, 25 May 2018 18:14:05 +0800
>>
>>> skb->len is meaningless to user.
>>> data length could be more helpful, with which we can easily filter out
>>> the packet without payload.
>>>
>>> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
>>
>> Applied, thank you.
>
> Hi Dave,
>
> There's an update on this patch.
> Pls. see V4.
>
> And I will send a V5 patch per Eric's suggestion.
Ah, if it is merged it might be too late.
No big deal.
next prev parent reply other threads:[~2018-05-29 14:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 10:14 Yafang Shao
2018-05-25 21:59 ` Song Liu
2018-05-29 14:15 ` David Miller
2018-05-29 14:36 ` Yafang Shao
2018-05-29 14:42 ` Eric Dumazet [this message]
2018-05-29 14:46 ` Yafang Shao
2018-05-29 14:54 ` David Miller
2018-05-29 14:56 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98df6d86-f237-b2d4-9f85-ce6d11c1ac4f@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®