From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66CEF2F7AB8 for ; Thu, 22 Jan 2026 08:59:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769072359; cv=none; b=DfQduHcGov4ybptInasbglUgz/KjfSs4m+BelFNnK7g3WmnxI/CMAps+ES3eywz9XjmL5/K9UEgRG1tFLOdAeKD5Hf6BYVvMAX6jaHjkKZyyxmbgcfBfq1GVGcH1qLEsQS7CB1SlrBWp0WxwW4ZOw9SUXrZ5hzExZoEurLL8XlI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769072359; c=relaxed/simple; bh=3lbPi/bsw4Cc3WZOQXzyvTxdHo6csw9mkEk8ZHixWx0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f/txAq6x2XBmiuaF1FtyNg9ogOw/9E7MRWAtonbx6KQKz+sdsA1dzUCEOQWMDqD79VEwxZRHJeLId88fje77TzZ+83KJP2274Qw30mn1fYcYFsRbVJyktKmXerLRH3iO4dffq3AeqlUaTYFRidvRHQRJvMi+B999G+GyI2x5J5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Pbz1iPxa; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NRxrEGhm; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Pbz1iPxa"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NRxrEGhm" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60M7KmVi816316 for ; Thu, 22 Jan 2026 08:59:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CqVbn3OLR8tmVrU+l6rvOR1TWMyoigyowuSm5THHMRg=; b=Pbz1iPxaTE4GI4Gs Zm+n0a7sozcGDQOj3vyYcd3jCFG4ly/VDl979dj4prFlQif7qapLfKPWqwiNAsbO mY3df+dGaNBZ4m7ExLvMiVwlHaalTiy7NkU6E7S1GNkXyVVKshlN3eduS/AQdmbt jgnXe5p3uzO/dzboV2dof/C5Bb+K7tmO7g6YoRqZEuOh5AnscSiHknZ6RxOILVpM dqxra9V1cnZcN+s9i54PlMNRE2HKWjQ3D1PtK7xSXi1lTP57VImSt6OHppJ4dUve BnyOmZLsQnMYsjyy4uNFtSd4XunIdvrziugDJ2K6SQjYsuJnhbzGk34Mpzbi7dUX L61spA== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bu65v1u2t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 22 Jan 2026 08:59:16 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c6124a9fb86so991119a12.3 for ; Thu, 22 Jan 2026 00:59:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769072355; x=1769677155; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CqVbn3OLR8tmVrU+l6rvOR1TWMyoigyowuSm5THHMRg=; b=NRxrEGhmU42C1x5cMeybU8nKZeLtaZSlQsZSRpk7yABSyYowrEY/rzdCzDbgFI+rxb azkE4LBQH5mId2yGbiBEjnomJ0ngYdLsBZc3t66QbLMWmF5sIS+5OGTfnaStRXy1nDDj KmqMgFZAvag8hitCfgGWWCjx0GAC6pQltoJ+OUz9zKpKTIljPa88CMqFKLPK3e8nsiaY fTy91Md7GgbehCQolwD2T+oSyPt1Il54yIH6t6vUEbXQUQx9teSjkLrolJKHD9rqyCem qZ1O6ZeABqFlUstWJZr7NpQq1qUnxZIDe1uO6OlbuiAd6GZELdqltpjedVI/Hb6p0hu6 kEOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769072355; x=1769677155; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CqVbn3OLR8tmVrU+l6rvOR1TWMyoigyowuSm5THHMRg=; b=JDEcr/VTPZre7JKIe1uybGbbmlVykWrVDA8ncKiX3p7xbcFCnXLjuKCE3lKchJtDbs Jd++w9CLPtah2uIHNW3mpeJ9+12nbWtkwRmB9t0g7XROGrjaYtFR5cxbAcVNSK5ZgxX0 wxAdfycx08R0zuNjTbEuf9tD2lqz6DIwGx6gNLg35SFbl5QSF3/lSXnnFN/FtNYXED2/ +RuGoUAQ5nogs841ZVOGwL4+l83rCDgzUFcWBb1CTGmnRTTkCJoCKe42y4dGg+vPQlHk RA7zSlZkPMx49skHciYzH2zihE9UsQxXcMvCcq6u3UdfMQ5ErF7INsvnaGT2n9Zt3Vhx Ed1w== X-Forwarded-Encrypted: i=1; AJvYcCVBrTRaRvnobMgoOpTBoOhwlidS55DJmDXlDPLlbf/GEBisYXpk6semRWDiLvGo1Z9z9f+oEZl3hn6AHTk=@vger.kernel.org X-Gm-Message-State: AOJu0YwbLtf/+Pk0CdxYCCqmw7bLUZEtjYxsiyTkM+RZAH149BAKsaDv N6BVzHw9gn4pTYh4m5gnZFS7ZcAm9B8BZlJFtt+PIJt8vAHeTAVmwZ7hOd77AkxaZmhQHu1zgSG J5A5nHLive1nONJ8yEDhmGotMfdhTvHy568rruy6AyGkuPMyJOF9pH9TV6HQ0I3gA3D2oOFBMCr E= X-Gm-Gg: AZuq6aKziTkfJO0hKdaqJZUdSOcwAM/kMOaM9L5fhc1LP35AYb4BqJGzSJHfErsdU+Q erVn2aqYnuldQtKTYQmoVJJxF5jBmeB9KtSgTG3zIpmXOK5ZofR68ZZMChV6qjpldNXtIfl96OO cRu+0yTdr+sCY6p5FonVgdvtudIvedgQdXbWmdu4LlrOAgJAZ3TfI0j0bvBb1cR9nkt5rDCFpLU via5+ZvAo/UbWeW40ve1NEChy+PBRaa3dY5yu99Z62g/RM2ID95FNYcDjoYSB2WiFxYFFR9wjJx du6tMRr1cOJhy50ZC5wTyTQPPRuyGuzPyjQEz8LDVRLySP7NjZk0TpZC5X+wcKemHKV8Y4wqgzs qB0ll6qKPCZVG/0uvZyRz1dX/2ujky1LNUVD3u6F5qA== X-Received: by 2002:a05:6a21:62c1:b0:37b:98c3:4250 with SMTP id adf61e73a8af0-38e00c2c914mr19744984637.19.1769072355162; Thu, 22 Jan 2026 00:59:15 -0800 (PST) X-Received: by 2002:a05:6a21:62c1:b0:37b:98c3:4250 with SMTP id adf61e73a8af0-38e00c2c914mr19744955637.19.1769072354680; Thu, 22 Jan 2026 00:59:14 -0800 (PST) Received: from [10.218.35.45] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c5edf264b9csm16483068a12.15.2026.01.22.00.59.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jan 2026 00:59:14 -0800 (PST) Message-ID: <98e0f3a2-2191-47cb-8c7c-e80f012c83b7@oss.qualcomm.com> Date: Thu, 22 Jan 2026 14:29:09 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] PCI: qcom: enable Link retain logic for Hamoa To: Dmitry Baryshkov Cc: Vinod Koul , Neil Armstrong , Philipp Zabel , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org References: <20260109-link_retain-v1-0-7e6782230f4b@oss.qualcomm.com> <20260109-link_retain-v1-5-7e6782230f4b@oss.qualcomm.com> Content-Language: en-US From: Krishna Chaitanya Chundru In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: XCt5iGo74Y70NmxAr6Sev0ycQxCoSH1S X-Proofpoint-ORIG-GUID: XCt5iGo74Y70NmxAr6Sev0ycQxCoSH1S X-Authority-Analysis: v=2.4 cv=J8qnLQnS c=1 sm=1 tr=0 ts=6971e6e4 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=21QzX6uEHMqXofhgfOUA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIyMDA2MCBTYWx0ZWRfX2BWPT+pVFnyB c2ZnB7zxV45hxcj8uzKBYI4WycxnoSKPYDa0CwL8Fp/IeIBakgLfCqjw0Winr1JuCZqUf36pw/8 wDi8Q0aFJlmyeb0zdger6tarqZeSi48s/Aeb9g5cqYIeIqpLGw44XgcfJH6XlpUWPJEFJs0NWBE 1R+eLVF3hVM1If/fL78jyLUUdB5HdNdjQ/s3q2t9DSIwgFva/mwZsf0JPMlkNHizoDEHpeOQ7nm cNZL9CbJKr3fLehpilZCYA9h/zhJhtp+uvLqt5YUbVlSk/eLdaPxVRh1Fj9UDVYV8CQ6GdpJTm7 NHeBHw1iYbj0NCUaAsNg13va1AXGKs0WY0gVyLN1Y/zNxa/MF2veyNvBo8Z9TmowWQo86Y0nAf9 mdwjy2radyXZ6EFehcXoPckMqDCaOGNDbPJhibjw20/4Pza7ASNubngzJ81Kb58enAvhC62g8AX yIDGHqRcCWSSUdXVijg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-21_04,2026-01-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 bulkscore=0 phishscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601220060 On 1/9/2026 6:39 PM, Dmitry Baryshkov wrote: > On Fri, Jan 09, 2026 at 12:51:10PM +0530, Krishna Chaitanya Chundru wrote: >> The Hamoa platform supports keeping the PCIe link active across >> bootloader and kernel handoff. To take advantage of this, introduce a >> specific configuration (cfg_x1e80100) with link_retain = true and >> update the device match table to use it. > Why are we enabling it only for this platform? As mentioned in the cover letter we are not trusting every platform boot loaders, which have initialized the controller to max speed. That is we are restricting them to only for this platform. - Krishna Chaitanya. >> Signed-off-by: Krishna Chaitanya Chundru >> --- >> drivers/pci/controller/dwc/pcie-qcom.c | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c >> index bdd5bdb462c5f6814c8311be96411173456b6b14..975671a0dd4757074600d5a0966e94220bb18d8c 100644 >> --- a/drivers/pci/controller/dwc/pcie-qcom.c >> +++ b/drivers/pci/controller/dwc/pcie-qcom.c >> @@ -1531,6 +1531,12 @@ static const struct qcom_pcie_cfg cfg_sc8280xp = { >> .no_l0s = true, >> }; >> >> +static const struct qcom_pcie_cfg cfg_x1e80100 = { >> + .ops = &ops_1_21_0, >> + .no_l0s = true, >> + .link_retain = true, >> +}; >> + >> static const struct qcom_pcie_cfg cfg_fw_managed = { >> .firmware_managed = true, >> }; >> @@ -2168,7 +2174,7 @@ static const struct of_device_id qcom_pcie_match[] = { >> { .compatible = "qcom,pcie-sm8450-pcie0", .data = &cfg_1_9_0 }, >> { .compatible = "qcom,pcie-sm8450-pcie1", .data = &cfg_1_9_0 }, >> { .compatible = "qcom,pcie-sm8550", .data = &cfg_1_9_0 }, >> - { .compatible = "qcom,pcie-x1e80100", .data = &cfg_sc8280xp }, >> + { .compatible = "qcom,pcie-x1e80100", .data = &cfg_x1e80100 }, >> { } >> }; >> >> >> -- >> 2.34.1 >>