From: Markus Elfring <Markus.Elfring@web.de>
To: Wenyuan Li <2063309626@qq.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Andy Walls <awalls@md.metrocast.net>,
linux-media@vger.kernel.org
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Sean Young <sean@mess.org>,
gszhai@bjtu.edu.cn, 23120469@bjtu.edu.cn, 25125332@bjtu.edu.cn,
25125283@bjtu.edu.cn
Subject: Re: [PATCH v3] media: ir-i2c: add error handling for I2C send in get_key_adaptec()
Date: Fri, 27 Mar 2026 15:15:36 +0100 [thread overview]
Message-ID: <98e67723-5100-4a35-ac9d-26a2414037ec@web.de> (raw)
In-Reply-To: <tencent_F0B755C48BEB67380BA88ADF22C96E1FC407@qq.com>
…
> Fix this by:
> - Checking the return value of i2c_master_send()
> - Converting partial sends to -EIO while preserving kernel error codes
> - Adding dev_err_ratelimited() logging with %pe format
> - Adding similar error logging for the i2c_master_recv() path
See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.0-rc5#n94
…
> ---
> v2:
…
> ---
> v3:
…
> ---
> drivers/media/pci/ivtv/ivtv-i2c.c | 21 +++++++++++++++++++--
…
How do you think about to avoid the specification of redundant marker lines?
Regards,
Markus
next prev parent reply other threads:[~2026-03-27 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 10:30 Wenyuan Li
2026-03-27 14:15 ` Markus Elfring [this message]
2026-03-27 14:41 Wenyuan Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98e67723-5100-4a35-ac9d-26a2414037ec@web.de \
--to=markus.elfring@web.de \
--cc=2063309626@qq.com \
--cc=23120469@bjtu.edu.cn \
--cc=25125283@bjtu.edu.cn \
--cc=25125332@bjtu.edu.cn \
--cc=awalls@md.metrocast.net \
--cc=gszhai@bjtu.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sean@mess.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox