mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Schmidt <stefan@osg.samsung.com>
To: Ozgur Karatas <ozgur@member.fsf.org>,
	kaber@trash.net, David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fixed to checkpatch.pl errors to vlan_dev.c
Date: Mon, 5 Dec 2016 16:48:13 +0100	[thread overview]
Message-ID: <98f13d7e-69e5-a392-bd95-d615dbfcba3f@osg.samsung.com> (raw)
In-Reply-To: <52561480952041@web13j.yandex.ru>

Hello.

On 05/12/16 16:34, Ozgur Karatas wrote:
> Hello all,
>
> I will solve a checkpatch errors.
>
> Signed-off-by: Ozgur Karatas <ozgur@member.fsf.org>

The patch itself looks good, but please have a read about having a good 
commit message. I would suggest reading Documentation/SubmittingPatches 
section 14: The canonical patch format

Especially the parts about the subject line and summary.

>
> ---
>  net/8021q/vlan_dev.c                               |   2 +-
> diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
> index fbfacd5..2edb495 100644
> --- a/net/8021q/vlan_dev.c
> +++ b/net/8021q/vlan_dev.c
> @@ -738,7 +738,7 @@ static int vlan_dev_netpoll_setup(struct net_device *dev, struct netpoll_info *n
>
>  static void vlan_dev_netpoll_cleanup(struct net_device *dev)
>  {
> -       struct vlan_dev_priv *vlan= vlan_dev_priv(dev);
> +       struct vlan_dev_priv *vlan = vlan_dev_priv(dev);
>         struct netpoll *netpoll = vlan->netpoll;
>
>         if (!netpoll)
>

regards
Stefan Schmidt

      reply	other threads:[~2016-12-05 15:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-05 15:34 Ozgur Karatas
2016-12-05 15:48 ` Stefan Schmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98f13d7e-69e5-a392-bd95-d615dbfcba3f@osg.samsung.com \
    --to=stefan@osg.samsung.com \
    --cc=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ozgur@member.fsf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®