mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Saket Kumar Bhaskar <skb99@linux.ibm.com>,
	bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: hbathini@linux.ibm.com, sachinpb@linux.ibm.com,
	andrii@kernel.org, eddyz87@gmail.com, mykolal@fb.com,
	ast@kernel.org, martin.lau@linux.dev, song@kernel.org,
	yonghong.song@linux.dev, john.fastabend@gmail.com,
	kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com,
	jolsa@kernel.org, shuah@kernel.org
Subject: Re: [PATCH] selftests/bpf: Set CONFIG_PACKET=y for selftests
Date: Mon, 7 Jul 2025 14:31:32 +0200	[thread overview]
Message-ID: <98f27ecc-a69f-4bcb-a2d7-6fff91383225@iogearbox.net> (raw)
In-Reply-To: <20250707071735.705137-1-skb99@linux.ibm.com>

On 7/7/25 9:17 AM, Saket Kumar Bhaskar wrote:
> BPF selftest fails to build with below error:
> 
>    CLNG-BPF [test_progs] lsm_cgroup.bpf.o
> progs/lsm_cgroup.c:105:21: error: variable has incomplete type 'struct sockaddr_ll'
>    105 |         struct sockaddr_ll sa = {};
>        |                            ^
> progs/lsm_cgroup.c:105:9: note: forward declaration of 'struct sockaddr_ll'
>    105 |         struct sockaddr_ll sa = {};
>        |                ^
> 1 error generated.
> 
> lsm_cgroup selftest requires sockaddr_ll structure which is not there
> in vmlinux.h when the kernel is built with CONFIG_PACKET=m.
> 
> Enabling CONFIG_PACKET=y ensures that sockaddr_ll is available in vmlinux,
> allowing it to be captured in the generated vmlinux.h for bpf selftests.
> 
> Reported-by: Sachin P Bappalige <sachinpb@linux.ibm.com>
> Signed-off-by: Saket Kumar Bhaskar <skb99@linux.ibm.com>

Acked-by: Daniel Borkmann <daniel@iogearbox.net>

  reply	other threads:[~2025-07-07 12:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-07  7:17 Saket Kumar Bhaskar
2025-07-07 12:31 ` Daniel Borkmann [this message]
2025-07-07 15:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98f27ecc-a69f-4bcb-a2d7-6fff91383225@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=eddyz87@gmail.com \
    --cc=haoluo@google.com \
    --cc=hbathini@linux.ibm.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=mykolal@fb.com \
    --cc=sachinpb@linux.ibm.com \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=skb99@linux.ibm.com \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®