mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: Will Drewry <wad@chromium.org>, Kees Cook <keescook@chromium.org>
Cc: "Mickaël Salaün" <mic@digikod.net>,
	LKML <linux-kernel@vger.kernel.org>,
	"Andy Lutomirski" <luto@amacapital.net>,
	linux-kselftest@vger.kernel.org,
	"Shuah Khan" <shuahkh@osg.samsung.com>
Subject: Re: [PATCH v1] selftests: Make test_harness.h more generally available
Date: Mon, 1 May 2017 13:23:58 -0600	[thread overview]
Message-ID: <98f52134-e3b8-3eba-1f72-edefa3115647@kernel.org> (raw)
In-Reply-To: <CAAFS_9F_oYuDBGoG_db3i3EOVWnzSsm9uvirExMKUqYLAbBH6g@mail.gmail.com>

On 04/30/2017 12:22 PM, Will Drewry wrote:
> On Sun, Apr 30, 2017 at 12:39 PM, Kees Cook <keescook@chromium.org> wrote:
>>
>> On Sun, Apr 30, 2017 at 5:26 AM, Mickaël Salaün <mic@digikod.net> wrote:
>>> The seccomp/test_harness.h file contains useful helpers to build tests.
>>> Moving it to the selftest directory should benefit to other test
>>> components.
>>
>> Unless Shuah thinks this should live in a new include/ directory, this
>> looks fine to me.
>>
>> Acked-by: Kees Cook <keescook@chromium.org>
> 
> Same here!
> 
> Acked-by: Will Drewry <wad@chromium.org>
> 
>>

I think the location fine. It will be a good idea to write
documentation on how to use this harness. I would recommend
rename the file to kselftest_harness.h and a doc file
kselftest_harness.txt which will go into Documentation directory.

thanks,
- Shuah

      parent reply	other threads:[~2017-05-01 19:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-30 12:26 Mickaël Salaün
2017-04-30 17:39 ` Kees Cook
2017-04-30 18:22   ` Will Drewry
2017-05-01 15:11     ` Mickaël Salaün
2017-05-01 19:23     ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98f52134-e3b8-3eba-1f72-edefa3115647@kernel.org \
    --to=shuah@kernel.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mic@digikod.net \
    --cc=shuahkh@osg.samsung.com \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome