From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8605EC388F7 for ; Thu, 22 Oct 2020 13:09:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 074C924178 for ; Thu, 22 Oct 2020 13:09:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="G3EvcoqI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2899357AbgJVNJH (ORCPT ); Thu, 22 Oct 2020 09:09:07 -0400 Received: from mx2.suse.de ([195.135.220.15]:44886 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2442464AbgJVNJG (ORCPT ); Thu, 22 Oct 2020 09:09:06 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1603372145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xnl30XZmbkdq+DrOW7dw1rQEfgCFIhyaC9tjnrTpvhk=; b=G3EvcoqIsqGs4aDO2mpBJ1JGmOUd/OPq7oygh7b6FF+0GTcrKqbng6hgIBfCH3Os3t/dIS uV/OIsKhlCM/Y5jWNUEQDJNFCgoh3+eFZBMSrsIC/BSdBaokhWtsWh9fyjw5n6pfIj+qVs MIV16z6zFR4NJs+Ydt0K7f5fFIaSdI4= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A540AAC3F; Thu, 22 Oct 2020 13:09:05 +0000 (UTC) Subject: Re: [PATCH v2 3/5] xen/events: only register debug interrupt for 2-level events To: Jan Beulich Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Boris Ostrovsky , Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" References: <20201022094907.28560-1-jgross@suse.com> <20201022094907.28560-4-jgross@suse.com> <1de24e42-6cb7-4ecb-0eb2-c4a15dc8afc9@suse.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <98f76c98-00d5-3238-a54f-cce52419160f@suse.com> Date: Thu, 22 Oct 2020 15:09:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <1de24e42-6cb7-4ecb-0eb2-c4a15dc8afc9@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22.10.20 12:35, Jan Beulich wrote: > On 22.10.2020 11:49, Juergen Gross wrote: >> @@ -2080,10 +2080,12 @@ void __init xen_init_IRQ(void) >> int ret = -EINVAL; >> evtchn_port_t evtchn; >> >> - if (fifo_events) >> + if (xen_fifo_events) >> ret = xen_evtchn_fifo_init(); >> - if (ret < 0) >> + if (ret < 0) { >> xen_evtchn_2l_init(); >> + xen_fifo_events = false; >> + } > > Another note: While it may not matter right here, maybe better > first set the variable and the call the function? I don't think this is really important, TBH. This code is executed before other cpus are up and we'd have major other problems in case the sequence would really matter here. Juergen