From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.100 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793602372; b=S7Cpuc0Ih2HVa5+72s3k45jLJBkbnulFxgJwDLzRl7WFw08A4t2dALoCTcuAPlZTJmve aKQVdspFHi24PhZHfvOsvv7U6zs2vBpFSBD8ajJDqEb6+lq1xScIFemizL4Hb4MDdk+ku 3bX8hsi3OqOVh78ZOE53WQsKOG9qolf0cr2WkWJLRZn6tQKOEbwRWc+4L4pL2dbWeN6rK j2hIk5kv7YGfa0Sfg54ECkuCCNpgoAF1bjVshVMG7JqTR9TrHThhwxsWbhjfrzI0Cj4xa IobMlWEFvWEPOuy9GMLLnxXCLkuJWtbRYKzdnUXUdmqXVTw7Ygtn38Egm0N9h56JboA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793602372; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Cc:Subject:To:References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=bMXZ0dgVH4WoOSFJpLmJHiq7X2F+yW/TzcS8zHyoUHU=; b=hfnemI7UEKr+VghsCATY8twuCFqkEh2bx+Fif/6DFIAPg98RqTFq91zBe4mPR7jXjkbM +Z0JZ+oTAr/XunHo2h1YH2r2q+xjA0yPbbb5HZkmEG7t5fDlun+AYSHcmzzs8z9KAozyp OnkQQzJRplgggfxnBajftZ4gK8r3vYoy5VUmvvVC9uDTzy5JyLE+sKHyDJIfka4iTewSW 6ZXafLzkhSVpbEH0KhVvbjlpo+HHDhbBy7f99+lr+rrGaHx4Qow/8HTLj0TVM4HpX7mAZ k8sLbUipOc2MGeeymyarvhKzQtsc6gSKyAPvTOWgqTDAKKKIG5caY6tYqb3gBzDX1Ng== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=DVcZvFMg; arc=none smtp.remote-ip=95.215.58.100 Received: from mta1.migadu.com (out-100.mta1.migadu.com [95.215.58.100]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64926606A327 for ; Mon, 2 Nov 2026 06:52:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 64926606A327 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=DVcZvFMg X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=5hCLGLGXWdd30qKe7976AVeC000uZPY7d4C8iQIIm24=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793602368; v=1; x=1794207168; b=DVcZvFMgTh3vVE6FmYOznLQU4BXxwXV5ZoPkXInacPSY2LC+3bHKV1e2efcGLcBZp+G9yu45 VpYH3dsMZrGR8MJz+Gb/9Q3qrKjZElY9AEMdkHOPAGteOEeINKHmvOBSsPADug43zRH7YYwBAWL 6m3IBZHpDtB3TsB+8j8NOH0o= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 11fb00a865b394d4; Mon, 02 Nov 2026 06:52:48 +0000 X-Mizu-Trace-ID: 11fb00a865b394d4 X-Migadu-Flow: FLOW_OUT Message-ID: <98fae1e9-58e8-4564-b4f2-18e7a77b2abb@linux.dev> Date: Mon, 2 Nov 2026 14:52:38 +0800 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: shawn.lin@linux.dev, Ulf Hansson , Adrian Hunter , Florian Fainelli , Wolfram Sang , Oleksij Rempel , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Conor Dooley , Krzysztof Kozlowski , Krzysztof Kozlowski , Krzysztof Kozlowski Subject: Re: [PATCH v11 4/6] mmc: core: Split sdio_set_host_pm_flags() To: Kamal Dasu , linux-mmc@vger.kernel.org, Ulf Hansson References: <20261030181034.3811225-1-kamal.dasu@broadcom.com> <20261030181034.3811225-5-kamal.dasu@broadcom.com> From: Shawn Lin In-Reply-To: <20261030181034.3811225-5-kamal.dasu@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2026/10/31 星期六 2:10, Kamal Dasu 写道: > From: Ulf Hansson > > To prepare for a subsequent change, let's split up sdio_set_host_pm_flags() > allowing the second part of it to be used as an internal function for the > core. > Reviewed-by: Shawn Lin > Signed-off-by: Ulf Hansson > Signed-off-by: Kamal Dasu > --- > drivers/mmc/core/core.c | 10 ++++++++++ > drivers/mmc/core/core.h | 1 + > drivers/mmc/core/sdio_io.c | 7 +------ > 3 files changed, 12 insertions(+), 6 deletions(-) > > diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c > index 677e445dc48c..6cbb5ee6200c 100644 > --- a/drivers/mmc/core/core.c > +++ b/drivers/mmc/core/core.c > @@ -1422,6 +1422,16 @@ int mmc_handle_undervoltage(struct mmc_host *host) > return host->bus_ops->handle_undervoltage(host); > } > > +int mmc_set_host_pm_flags(struct mmc_host *host, mmc_pm_flag_t flags) > +{ > + if (flags & ~host->pm_caps) > + return -EINVAL; > + > + /* function suspend methods are serialized, hence no lock needed */ > + host->pm_flags |= flags; > + return 0; > +} > + > /* > * Assign a mmc bus handler to a host. Only one bus handler may control a > * host at any given time. > diff --git a/drivers/mmc/core/core.h b/drivers/mmc/core/core.h > index 9be2875608ce..d3a2ff00b18f 100644 > --- a/drivers/mmc/core/core.h > +++ b/drivers/mmc/core/core.h > @@ -64,6 +64,7 @@ int mmc_handle_undervoltage(struct mmc_host *host); > void mmc_regulator_register_undervoltage_notifier(struct mmc_host *host); > void mmc_regulator_unregister_undervoltage_notifier(struct mmc_host *host); > void mmc_undervoltage_workfn(struct work_struct *work); > +int mmc_set_host_pm_flags(struct mmc_host *host, mmc_pm_flag_t flags); > > static inline void mmc_delay(unsigned int ms) > { > diff --git a/drivers/mmc/core/sdio_io.c b/drivers/mmc/core/sdio_io.c > index 12716ec0e35d..99f857514b63 100644 > --- a/drivers/mmc/core/sdio_io.c > +++ b/drivers/mmc/core/sdio_io.c > @@ -726,12 +726,7 @@ int sdio_set_host_pm_flags(struct sdio_func *func, mmc_pm_flag_t flags) > > host = func->card->host; > > - if (flags & ~host->pm_caps) > - return -EINVAL; > - > - /* function suspend methods are serialized, hence no lock needed */ > - host->pm_flags |= flags; > - return 0; > + return mmc_set_host_pm_flags(host, flags); > } > EXPORT_SYMBOL_GPL(sdio_set_host_pm_flags); >