mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chao Yu <yuchao0@huawei.com>
To: sunqiuyang <sunqiuyang@huawei.com>,
	<linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
	<linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [PATCH 1/1] f2fs: merge equivalent flags F2FS_GET_BLOCK_[READ|DIO]
Date: Thu, 10 Aug 2017 18:45:26 +0800	[thread overview]
Message-ID: <98fd4a5d-bec8-af99-14a0-93a006437b8f@huawei.com> (raw)
In-Reply-To: <1502270850-34212-1-git-send-email-sunqiuyang@huawei.com>

On 2017/8/9 17:27, sunqiuyang wrote:
> From: Qiuyang Sun <sunqiuyang@huawei.com>
> 
> Currently, the two flags F2FS_GET_BLOCK_[READ|DIO] are totally equivalent
> and can be used interchangably in all scenarios they are involved in. 
> Neither of the flags is referenced in f2fs_map_blocks(), making them both 
> the default case. To remove the ambiguity, this patch merges both flags
> into F2FS_GET_BLOCK_DEFAULT, and introduces an enum for all distinct flags.
> 
> Signed-off-by: Qiuyang Sun <sunqiuyang@huawei.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

  reply	other threads:[~2017-08-10 10:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-09  9:27 sunqiuyang
2017-08-10 10:45 ` Chao Yu [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-08-08 10:27 sunqiuyang
2017-08-08 11:24 ` Chao Yu
2017-08-08 11:41   ` Sun Qiuyang
2017-08-09  1:13     ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98fd4a5d-bec8-af99-14a0-93a006437b8f@huawei.com \
    --to=yuchao0@huawei.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sunqiuyang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®