From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C707F36B for ; Fri, 28 Nov 2025 02:31:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764297090; cv=none; b=uWa1T+a3ooTVfrCGTBLpvjZ8eqI1+HDHxq7MrKXSlVscqxTmCz4JYYIPCDjMtlpdQ04t2ueT36vaRXtX1GOktpMX1NMh9ehSm61Phse6bYcG3oke7rfJ2QL6vowQe/JiENkg9RfvjxMmK2oieb1o8pgY8PJ/m1t64MCYOevTAic= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764297090; c=relaxed/simple; bh=aAZyIN4NkBzeVFEZE5oJMiW0bpmEGEQQtnBKFBPr5nM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PdV4YTrlItQzR0IkqF0X4dKHkWtNWIMddEnRVLfaCH+KrUKA+EmrtZ7AgPD0yKIT8lY25nT7kN+LsZVgGJPOPArn9TFWw4IGC3b3muoTFFlG9AOZSwZOxFAjbz9LPVI+5VItP75KOkgscg8++2xC5CLgFytNsnXWU1OPt/gmcUc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5A8391575; Thu, 27 Nov 2025 18:31:20 -0800 (PST) Received: from [10.164.18.52] (unknown [10.164.18.52]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C13E13F73B; Thu, 27 Nov 2025 18:31:25 -0800 (PST) Message-ID: <9900ca30-4d57-4a38-b319-b76d57038e52@arm.com> Date: Fri, 28 Nov 2025 08:01:22 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: Remove unreachable break after die To: Mark Rutland , Osama Abdelkader Cc: smostafa@google.com, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, will@kernel.org, linux-arm-kernel@lists.infradead.org References: <20251126222620.215245-1-osama.abdelkader@gmail.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 27/11/25 2:50 PM, Mark Rutland wrote: > On Thu, Nov 27, 2025 at 12:26:20AM +0200, Osama Abdelkader wrote: >> die() never returns, the break is unreachable in arch/arm64/kernel/traps.c > > Is the break causing some problem, e.g. a compiler warning? > > If not, then I don't see a reason to remove the break. > > There are many other instances of "die(...); break" throughout the > kernel, and this doesn't seem to be speecial. Agree with Mark. From switch case semantics perspective a break is expected here regardless what happens to control flow. > > Mark. > >> Signed-off-by: Osama Abdelkader >> --- >> arch/arm64/kernel/traps.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c >> index 681939ef5d16..81dd2d7759eb 100644 >> --- a/arch/arm64/kernel/traps.c >> +++ b/arch/arm64/kernel/traps.c >> @@ -1003,7 +1003,6 @@ int bug_brk_handler(struct pt_regs *regs, unsigned long esr) >> switch (report_bug(regs->pc, regs)) { >> case BUG_TRAP_TYPE_BUG: >> die("Oops - BUG", regs, esr); >> - break; >> >> case BUG_TRAP_TYPE_WARN: >> break; >> -- >> 2.43.0 >> >