From: Judith Mendez <jm@ti.com>
To: <linux-can@vger.kernel.org>, Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Schuyler Patton <spatton@ti.com>, Tero Kristo <kristo@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
<devicetree@vger.kernel.org>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Simon Horman <simon.horman@corigine.com>,
Conor Dooley <conor+dt@linaro.org>,
Tony Lindgren <tony@atomide.com>,
Chandrasekar Ramakrishnan <rcsekar@samsung.com>
Subject: Re: [PATCH v8 0/2] Enable multiple MCAN on AM62x
Date: Tue, 13 Jun 2023 12:41:55 -0500 [thread overview]
Message-ID: <9905aefb-0d27-a4d6-b72d-5b852dc04465@ti.com> (raw)
In-Reply-To: <20230530224820.303619-1-jm@ti.com>
Hi all,
On 5/30/23 5:48 PM, Judith Mendez wrote:
> On AM62x there are two MCANs in MCU domain. The MCANs in MCU domain
> were not enabled since there is no hardware interrupt routed to A53
> GIC interrupt controller. Therefore A53 Linux cannot be interrupted
> by MCU MCANs.
>
> This solution instantiates a hrtimer with 1 ms polling interval
> for MCAN device when there is no hardware interrupt property in
> DTB MCAN node. The hrtimer generates a recurring software interrupt
> which allows to call the isr. The isr will check if there is pending
> transaction by reading a register and proceed normally if there is.
> MCANs with hardware interrupt routed to A53 Linux will continue to
> use the hardware interrupt as expected.
>
> Timer polling method was tested on both classic CAN and CAN-FD
> at 125 KBPS, 250 KBPS, 1 MBPS and 2.5 MBPS with 4 MBPS bitrate
> switching.
>
> Letency and CPU load benchmarks were tested on 3x MCAN on AM62x.
> 1 MBPS timer polling interval is the better timer polling interval
> since it has comparable latency to hardware interrupt with the worse
> case being 1ms + CAN frame propagation time and CPU load is not
> substantial. Latency can be improved further with less than 1 ms
> polling intervals, howerver it is at the cost of CPU usage since CPU
> load increases at 0.5 ms.
>
> Note that in terms of power, enabling MCU MCANs with timer-polling
> implementation might have negative impact since we will have to wake
> up every 1 ms whether there are CAN packets pending in the RX FIFO or
> not. This might prevent the CPU from entering into deeper idle states
> for extended periods of time.
Was wondering if I am still pending some updates for this patch series?
Or if any other issues please let me know. (: Thanks all
~ Judith
prev parent reply other threads:[~2023-06-13 17:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 22:48 Judith Mendez
2023-05-30 22:48 ` [PATCH v8 1/2] dt-bindings: net: can: Remove interrupt properties for MCAN Judith Mendez
2023-05-31 4:30 ` Tony Lindgren
2023-05-30 22:48 ` [PATCH v8 2/2] can: m_can: Add hrtimer to generate software interrupt Judith Mendez
2023-05-31 4:30 ` Tony Lindgren
2023-06-14 7:02 ` Marc Kleine-Budde
2023-06-15 12:02 ` Hiago Franco
2023-06-13 17:41 ` Judith Mendez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9905aefb-0d27-a4d6-b72d-5b852dc04465@ti.com \
--to=jm@ti.com \
--cc=conor+dt@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rcsekar@samsung.com \
--cc=robh+dt@kernel.org \
--cc=simon.horman@corigine.com \
--cc=socketcan@hartkopp.net \
--cc=spatton@ti.com \
--cc=tony@atomide.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®