From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC2B67081E for ; Mon, 6 Jan 2025 20:39:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736195963; cv=none; b=p/X6j/ChQWT3JsoSR6mmktgJ7cYTJzlZy2dtvNkKX+ab2cJeGNz+c/bkTFP43ilAZ69Ui+M9y0rsvlk08UTtp0/wGGwmVDF4eaMCKa3LlRQ8i8LoMOrDsUVhL2go0ajkLTa6iEkwUn9b/+ppvsSs4fVCUspStav6AIig50qt7Kk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736195963; c=relaxed/simple; bh=ZirG2FXN9/wCaRb95O2bSulDC5lDfkzT7craeZU1cwM=; h=Date:From:To:cc:Subject:Message-ID:MIME-Version:Content-Type; b=rbhjnLuIOJTEOJ9JTXONI56aTCBVO5QfjNEfBnlwg61tmt0/4QCqwgJY8h90GLs/hRgDG0zRRIQ+ybqgi3+qqLWooDEcgKesw1y8HbrU/SJfl4oCwcEWVJ4+FsFxHyAbdKZjwdIRgj1As6wrJhWLGw5pYnWDXHOwWYgYZMORcLQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=38/ILmEB; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="38/ILmEB" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-219f6ca9a81so1035ad.1 for ; Mon, 06 Jan 2025 12:39:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736195961; x=1736800761; darn=vger.kernel.org; h=mime-version:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=/feXvx41WY0Y5uSvIiIaiHXPIaWH5bEIXOdNz6/teZM=; b=38/ILmEBiqzJGo+Ss7f5IDvfTvSiNI5/jriBL1WYsbxbsKe5iXOVgooKAaoqV4oPTJ tYhQDKxwcKiA2eE1d4WdFmf8LfKKWld2293MnDaDG8227hkbiqqGs/krScWQE7QEA87j u59jRbs2mzUeUImCJWX+GIfSiQPSPsJllWCky50TDirke9djPyTeF+WP2SvRB540V4cP 3A1zoVIPLMUpUN+yYOBxl01SMAltwjroihp7TSB9uat+OVEPlQBLUFll0hiZ98RAOaTD 6BL6y9fa28itTPDy/V89Yhl9aQ2A/lOBmL7fCJddZMs5C4z5JYwlGrXBMmXkW1k6yiMY izpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736195961; x=1736800761; h=mime-version:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/feXvx41WY0Y5uSvIiIaiHXPIaWH5bEIXOdNz6/teZM=; b=RSTtaMCQw8PhMjUKOLL4e8cwBMa6PSTu4IlZfjl7DjoHDOuUnZspGmuC4MWI4FeHsh Q+DlRh8cZZlzixSzNA3Zh6QtNfw+gx0SSCQrdhl5znUxkkbmoAt/QvYo2sdzr4Lv/U5k 94Yk2l6vuT/f6NIMLpcsJU5pn73KBkve6O7RflP+NipBim/XptZJZXFTmGZinaH5hF2n E65xoxGUl3guFaWSMP5rt/sxxVzJunqq3UO+V4SZLuhw1rSn6otS8TH5u8pBlEynxmm6 KHUM3CR7K38Y2T5qkzPWToVbbY/HnaO1wFCIuvT6nif4Y4vYBTAF8ojk2ezg1FDJo1rJ iHAw== X-Forwarded-Encrypted: i=1; AJvYcCVSH/rfiHeDKbNp0aK3Rs8ybrZSIGny06XReEo6g8D+u04CdrBDGZd34fzAs7V98j7jvNPa7KIuD8NIXo8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+Nhnx/KIEffyhbchM0/pxTK/uw+vOVk2pt04Qw5Q84gDfZrMw j0GkHl9MQSbAND+G/F+Vvjr6lg2A71EQBNVcbEKjdLoguWx8KWG8WkDqc4OJcg== X-Gm-Gg: ASbGncvU4+Vo3sv80+i+ihAoVQpe5bqMyDTEdD/lnqDEJMrkvqXFPrNKT29Kdq5Wjba +zgarOIyIcj2VQUlDnkqm57z26kBf4XwE0ifP4Enmlt+QjQnZ+QpzpSKPnMyvnhN+jZSIm0LLLi t1/mZivZNwu5Ir4xLSB32GBZNZNJArVJsMNKGL/DSv2jTc8bpZrIQmPb65wOA1oirPZDJwLjkXR GyXUOT+GGneV3nkRsPboA8AbGv3aUSrXuz0P2tMfycVzX69aTzDRlCc5kgPc/IpdKvRy+36NUcB UFOAtwsQhdk= X-Google-Smtp-Source: AGHT+IE8yDSy74qNWwK/CJ/pJsuiUAfdTgtsbE3xFKstciqapJysyrH8zJqldI03UDNH5NO6lJ/tPA== X-Received: by 2002:a17:903:2344:b0:216:25a2:2ed6 with SMTP id d9443c01a7336-21a7acc70bdmr380305ad.14.1736195960900; Mon, 06 Jan 2025 12:39:20 -0800 (PST) Received: from [2620:0:1008:15:bee6:75f5:6b93:9881] ([2620:0:1008:15:bee6:75f5:6b93:9881]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8dbbabsm33117383b3a.101.2025.01.06.12.39.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2025 12:39:20 -0800 (PST) Date: Mon, 6 Jan 2025 12:39:19 -0800 (PST) From: David Rientjes To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot cc: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , linux-kernel@vger.kernel.org Subject: [patch 1/2] sched/debug: Change need_resched warnings to pr_err Message-ID: <99090633-b625-ff07-fcf8-500d71f9ae13@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII need_resched warnings, if enabled, are treated as WARNINGs. If kernel.panic_on_warn is enabled, then this causes a kernel panic. It's highly unlikely that a panic is desired for these warnings, only a stack trace is normally required to debug and resolve. Thus, switch need_resched warnings to simply be a printk with an associated stack trace so they are no longer in scope for panic_on_warn. Signed-off-by: David Rientjes --- kernel/sched/debug.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c --- a/kernel/sched/debug.c +++ b/kernel/sched/debug.c @@ -1295,8 +1295,10 @@ void resched_latency_warn(int cpu, u64 latency) { static DEFINE_RATELIMIT_STATE(latency_check_ratelimit, 60 * 60 * HZ, 1); - WARN(__ratelimit(&latency_check_ratelimit), - "sched: CPU %d need_resched set for > %llu ns (%d ticks) " - "without schedule\n", - cpu, latency, cpu_rq(cpu)->ticks_without_resched); + if (likely(!__ratelimit(&latency_check_ratelimit))) + return; + + pr_err("sched: CPU %d need_resched set for > %llu ns (%d ticks) without schedule\n", + cpu, latency, cpu_rq(cpu)->ticks_without_resched); + dump_stack(); }