Re: [PATCH] drm/sitronix: Fix broken backwards-compatibility layer

[Thomas Zimmermann <tzimmermann@suse.de>]

Hi

Am 20.05.25 um 15:09 schrieb Geert Uytterhoeven:
> Hi Thomas,
>
> On Tue, 20 May 2025 at 15:04, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>> Am 20.05.25 um 14:40 schrieb Geert Uytterhoeven:
>>> When moving the Sitronix DRM drivers and renaming their Kconfig symbols,
>>> the old symbols were kept, aiming to provide a seamless migration path
>>> when running "make olddefconfig" or "make oldconfig".
>>>
>>> However, the old compatibility symbols are not visible.  Hence unless
>>> they are selected by another symbol (which they are not), they can never
>>> be enabled, and no backwards compatibility is provided.
>>>
>>> Fix this by making them visible, and inverting the selection logic.
>>> Add comments to make it clear why there are two symbols with the same
>>> description.
>> These symbols were only meant for variants of 'make oldconfig' to pick
>> up th enew symbols. They where never for being selected manually.
> But that pick-up does not work, unfortunately...
> (I know, I had one of them enabled in one of my configs ;-)

I see.

>
> The alternative is to just drop the old symbols, and ignore current users.
> Which is not that uncommon...

If there's no easy fix for the current setup, I'd prefer removing the 
old symbols.

Best regards
Thomas

>
> Gr{oetje,eeting}s,
>
>                          Geert
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)