From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B360DC4167B for ; Tue, 27 Dec 2022 19:24:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232105AbiL0TYq (ORCPT ); Tue, 27 Dec 2022 14:24:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231723AbiL0TYU (ORCPT ); Tue, 27 Dec 2022 14:24:20 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9CDB65A3 for ; Tue, 27 Dec 2022 11:23:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672169018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y7dbgHTngiyfazSG5sXwLfx+o+WyMctqSvzgKNLu/LU=; b=WJq1VkATQMtmUffPjF7oJkvOz/G22et3IVad+jZ0wFBjIVXmyOycEDqNqt5ICwkljD6qbA UAtBho+Df7kMei2+wNVt4Jk8AHV7IuDwrnQKeQ0oIyarPOCqaoGdxnQzWfthWy1GflI7Al ylF0wFjHaNNIDHV25VXm6A5mo2OOPXQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-311-L0-BS_1ZMkG4kxHR33TfyA-1; Tue, 27 Dec 2022 14:23:35 -0500 X-MC-Unique: L0-BS_1ZMkG4kxHR33TfyA-1 Received: by mail-wr1-f71.google.com with SMTP id d6-20020adf9b86000000b0028304dfbab5so323532wrc.15 for ; Tue, 27 Dec 2022 11:23:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y7dbgHTngiyfazSG5sXwLfx+o+WyMctqSvzgKNLu/LU=; b=YItehx2eoO0nvUeWyl1L5GbEESGmJNoTpKZMrd5cDMsyse2AODyxvOgUdxtTk5BaHW v69vV34baKNoL0+NQuAy1QlyT4Ir8RjTqka5kF6cPKf59OCe6Fxv8Q8BYXBOQ7mf5l43 aM7cX0fAhWi43sijfV+j+nlU3rj1PS2SjYJYBhQ7img+duAp9HMskIspVo4jmtvISP+z ClOX8ox64HKngX4oEgx7rsMlkKFSlWyCD4pwSSQKA6ixTdxTZGRBbDShSzH5w3Vd92yj sTxHCUR1nAQsEAsi88ZHVpEN65mnvGCmYLbIkcu8TqigMZ6LhYJ7TMkCO0nlmRZO4NoU q08A== X-Gm-Message-State: AFqh2kp3DSRxdkwGo62D9pz4Q+psbA77dRp67tPxzUaf5DyzfE/Nsldu JDFgKJNFQcpN3dZlcUT79oBrH6HJ3xe7++sZVXNuFCGL9m15bdFtxY/32fwq533i+wW0rCnCncE b+3WrLE+MX2Fo/ChshUa5IBHP X-Received: by 2002:a05:600c:3b90:b0:3d1:f0f1:ceb4 with SMTP id n16-20020a05600c3b9000b003d1f0f1ceb4mr16025411wms.19.1672169014395; Tue, 27 Dec 2022 11:23:34 -0800 (PST) X-Google-Smtp-Source: AMrXdXva0B2UHKhAop8zDawG+uzkPkYfVViqdOdvS3DOeaUVR1+zQGk160j5uLhQYZ6Be0X+v85V8g== X-Received: by 2002:a05:600c:3b90:b0:3d1:f0f1:ceb4 with SMTP id n16-20020a05600c3b9000b003d1f0f1ceb4mr16025401wms.19.1672169014169; Tue, 27 Dec 2022 11:23:34 -0800 (PST) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id q20-20020a1ce914000000b003b4935f04a4sm21286147wmc.5.2022.12.27.11.23.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Dec 2022 11:23:33 -0800 (PST) Message-ID: <9911d249-ccc0-7724-b0bc-17bcf2a524e8@redhat.com> Date: Tue, 27 Dec 2022 20:23:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 0/2] Recover from failure to probe GPU Content-Language: en-US To: Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= Cc: Thomas Zimmermann , Mario Limonciello , Alex Deucher , linux-efi@vger.kernel.org, Carlos Soriano Sanchez , amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20221222183012.1046-1-mario.limonciello@amd.com> <2761b1e1-508d-2c2c-f2d8-6f1be536723e@suse.de> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Alex, On 12/27/22 18:04, Alex Deucher wrote: [...] > > I think something like this would do the trick: > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index 2017b3466612..45aee27ab6b1 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -2141,6 +2141,11 @@ static int amdgpu_device_ip_early_init(struct > amdgpu_device *adev) > break; > } > > + /* Get rid of things like offb */ > + r = drm_aperture_remove_conflicting_pci_framebuffers(pdev, > &amdgpu_kms_driver); > + if (r) > + return r; > + > if (amdgpu_has_atpx() && > (amdgpu_is_atpx_hybrid() || > amdgpu_has_atpx_dgpu_power_cntl()) && > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > index b8cfa48fb296..4e74d7abc3c2 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > @@ -2123,11 +2123,6 @@ static int amdgpu_pci_probe(struct pci_dev *pdev, > } > #endif > > - /* Get rid of things like offb */ > - ret = drm_aperture_remove_conflicting_pci_framebuffers(pdev, > &amdgpu_kms_driver); > - if (ret) > - return ret; > - I'm not familiar with the amdgpu driver but yes, something like that is what I had in mind. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat