From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20ADCEB64DD for ; Tue, 1 Aug 2023 09:19:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230014AbjHAJTQ (ORCPT ); Tue, 1 Aug 2023 05:19:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231766AbjHAJSl (ORCPT ); Tue, 1 Aug 2023 05:18:41 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EAF92121 for ; Tue, 1 Aug 2023 02:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690881390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6K6y/X0lpa6BY0LxE0wc3D6uW028bWOkYEEOCtf5xMw=; b=F1iO+czbOWxnH131/1tV3T/VezJxXxn89wX4s7pqmQJXYnYoNqKMHJ6HQmbqQh1juUDSM8 W6tLUjvmgz7mijSHc/2DPoDvxmpsKcoC1mFagfqUiIUCS4ZwXTeu2v2RkZM+5kXSP3tZrP kIgV9EjNvP8FDL5siss5x0fpQLz3/y4= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-283-OiCUrQp0PoSF7oEJ_UHnVw-1; Tue, 01 Aug 2023 05:16:29 -0400 X-MC-Unique: OiCUrQp0PoSF7oEJ_UHnVw-1 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4054266d0beso12922531cf.0 for ; Tue, 01 Aug 2023 02:16:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690881388; x=1691486188; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=6K6y/X0lpa6BY0LxE0wc3D6uW028bWOkYEEOCtf5xMw=; b=V6KLfzYhvhAQ8n8bi/Z/RgVnKk2T5VQttcV/E/y6oRUgVj1DvyT5Y06NZD3axRhafS P9CImCChJEJYSzspiFJmfpQygzMu3BzbVmBcpoIgwV6rpxtcxWjR3curXh69FAAHwiu3 OUWByPIP8bxCTpEiVTyS1pH2eldE03WhdtEd0/TmtDTtRAktvXTPimjH8vz8k0dJoaMV LGjizt/NzANYkLhgkj7Qq0CM84WMsGHDLP0ddKSKdtc/NKrBTdftoyfNSw7VVd7DvGUg lhk4BICpbPmj1QzJMZIfjguWV2aff63XIYVioD0aeyav68m6dQtIuMOb49Oa+RUg86di iaZg== X-Gm-Message-State: ABy/qLbm0iT1iOACHB+oWmmege2elahFW9UZLN8UsmoNmKK4QCVHZP5T obazvhsYyPuSsVblekivf6Gj8aPhQqFBA9pM5siObUxYO5zbcbHAp1ZOgt6auc4yMn3Io+z0b4B BiU0rAfiPQui7XT0/gbm4YqYU X-Received: by 2002:ac8:7d90:0:b0:40a:6359:2120 with SMTP id c16-20020ac87d90000000b0040a63592120mr11996451qtd.0.1690881388638; Tue, 01 Aug 2023 02:16:28 -0700 (PDT) X-Google-Smtp-Source: APBJJlFsAGqmtM1V8U+ivRkVF/ZXpfBg5no8ZWT/4ga3JgRoRvBVkRVKkW2MgFfc8tHkIojui6RpFQ== X-Received: by 2002:ac8:7d90:0:b0:40a:6359:2120 with SMTP id c16-20020ac87d90000000b0040a63592120mr11996437qtd.0.1690881388400; Tue, 01 Aug 2023 02:16:28 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-225-251.dyn.eolo.it. [146.241.225.251]) by smtp.gmail.com with ESMTPSA id oo18-20020a05620a531200b007592f2016f4sm4009416qkn.110.2023.08.01.02.16.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 02:16:28 -0700 (PDT) Message-ID: <9912df2897bed863ad541807354d49db95970668.camel@redhat.com> Subject: Re: [PATCH v3 1/2] net: phy: at803x: fix the wol setting functions From: Paolo Abeni To: Leo Li , Andrew Lunn , Luo Jie Cc: Heiner Kallweit , Russell King , "David S . Miller" , Jakub Kicinski , David Bauer , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Viorel Suman , Wei Fang Date: Tue, 01 Aug 2023 11:16:24 +0200 In-Reply-To: References: <20230728215320.31801-1-leoyang.li@nxp.com> <20230728215320.31801-2-leoyang.li@nxp.com> <8071d8c5-1da3-47a0-9da2-a64ee80db6e5@lunn.ch> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2023-07-31 at 14:58 +0000, Leo Li wrote: > > -----Original Message----- > > From: Andrew Lunn > > Sent: Saturday, July 29, 2023 3:14 AM > > To: Leo Li > > Cc: Heiner Kallweit ; Russell King > > ; David S . Miller ; Jakub > > Kicinski ; David Bauer ; > > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Viorel Suman > > ; Wei Fang > > Subject: Re: [PATCH v3 1/2] net: phy: at803x: fix the wol setting funct= ions > >=20 > > On Fri, Jul 28, 2023 at 04:53:19PM -0500, Li Yang wrote: > > > In commit 7beecaf7d507 ("net: phy: at803x: improve the WOL feature"), > > > it seems not correct to use a wol_en bit in a 1588 Control Register > > > which is only available on AR8031/AR8033(share the same phy_id) to > > > determine if WoL is enabled. Change it back to use > > > AT803X_INTR_ENABLE_WOL for determining the WoL status which is > > > applicable on all chips supporting wol. Also update the > > > at803x_set_wol() function to only update the 1588 register on chips h= aving > > it. > >=20 > > Do chips which do not have the 1588 register not have WoL? Or WoL > > hardware is always enabled, but you still need to enable the interrupt. >=20 > Some of them do and some don't, which is removed in the other patch > from the series. Since I don't find the register to enable it, I > guess it always enabled. >=20 > >=20 > > Have you tested on a range of PHY? It might be better to split this pat= ch up a > > bit. If it causes regressions, having smaller patches can make it easie= r to find > > which change broken it. >=20 > No, I only have AR8035 to test with. Changes for other chips are > according to the datasheet. It would be good if others having the > hardware can test it too. Adding Luo Jie for awareness. @Luo Jie: do you have access to other chips handled by this driver other then AR8035? could you please test this series: https://patchwork.kernel.org/project/netdevbpf/list/?series=3D770734 ? Thanks! Paolo