From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932346AbcAKJ5d (ORCPT ); Mon, 11 Jan 2016 04:57:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35539 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759122AbcAKJ53 convert rfc822-to-8bit (ORCPT ); Mon, 11 Jan 2016 04:57:29 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1452381100-3187-1-git-send-email-chengang@emindsoft.com.cn> References: <1452381100-3187-1-git-send-email-chengang@emindsoft.com.cn> To: chengang@emindsoft.com.cn Cc: dhowells@redhat.com, trivial@kernel.org, akpm@linux-foundation.org, viro@zeniv.linux.org.uk, nicolas.iooss_linux@m4x.org, linux-kernel@vger.kernel.org, Chen Gang Subject: Re: [PATCH v2 trivial] include/linux/dcache.h: Cleanup code and comments MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <9915.1452506237.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Mon, 11 Jan 2016 09:57:17 +0000 Message-ID: <9916.1452506237@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org chengang@emindsoft.com.cn wrote: > -#define DCACHE_MISS_TYPE 0x00000000 /* Negative dentry (maybe fallthru to nowhere) */ > -#define DCACHE_WHITEOUT_TYPE 0x00100000 /* Whiteout dentry (stop pathwalk) */ > -#define DCACHE_DIRECTORY_TYPE 0x00200000 /* Normal directory */ > -#define DCACHE_AUTODIR_TYPE 0x00300000 /* Lookupless directory (presumed automount) */ > -#define DCACHE_REGULAR_TYPE 0x00400000 /* Regular file type (or fallthru to such) */ > -#define DCACHE_SPECIAL_TYPE 0x00500000 /* Other file type (or fallthru to such) */ > -#define DCACHE_SYMLINK_TYPE 0x00600000 /* Symlink (or fallthru to such) */ > +/* Negative dentry (maybe fallthru to nowhere) */ > +#define DCACHE_MISS_TYPE 0x00000000 > +/* Whiteout dentry (stop pathwalk) */ > +#define DCACHE_WHITEOUT_TYPE 0x00100000 > +/* Normal directory */ > +#define DCACHE_DIRECTORY_TYPE 0x00200000 > +/* Lookupless directory (presumed automount) */ > +#define DCACHE_AUTODIR_TYPE 0x00300000 > +/* Regular file type (or fallthru to such) */ > +#define DCACHE_REGULAR_TYPE 0x00400000 > +/* Other file type (or fallthru to such) */ > +#define DCACHE_SPECIAL_TYPE 0x00500000 > +/* Symlink (or fallthru to such) */ > +#define DCACHE_SYMLINK_TYPE 0x00600000 Please leave things like this as they were. > - * d_really_is_negative - Determine if a dentry is really negative (ignoring fallthroughs) > + * d_really_is_negative - Determine if a dentry is really negative (ignoring > + * fallthroughs) Does that break doc generation? Is fudging the comments actually worth breaking git blame? > -static inline int simple_positive(struct dentry *dentry) > +static inline bool simple_positive(struct dentry *dentry) This is worth doing - gcc actually produces better code sometimes with the int -> bool switch. This should be a separate patch. David